linux-stable/drivers/ntb
Dan Carpenter 776efefcaf NTB: ntb_tool: uninitialized heap data in tool_fn_write()
commit 45e1058b77 upstream.

The call to:

	ret = simple_write_to_buffer(buf, size, offp, ubuf, size);

will return success if it is able to write even one byte to "buf".
The value of "*offp" controls which byte.  This could result in
reading uninitialized data when we do the sscanf() on the next line.

This code is not really desigined to handle partial writes where
*offp is non-zero and the "buf" is preserved and re-used between writes.
Just ban partial writes and replace the simple_write_to_buffer() with
copy_from_user().

Fixes: 578b881ba9 ("NTB: Add tool test client")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-08-25 11:45:24 +02:00
..
hw ntb: intel: fix port config status offset for SPR 2022-01-28 10:19:16 -05:00
test NTB: ntb_tool: uninitialized heap data in tool_fn_write() 2022-08-25 11:45:24 +02:00
Kconfig New feature to add support for NTB virtual MSI interrupts, the ability 2019-07-21 09:46:59 -07:00
Makefile New feature to add support for NTB virtual MSI interrupts, the ability 2019-07-21 09:46:59 -07:00
core.c bus: Make remove callback return void 2021-07-21 11:53:42 +02:00
msi.c NTB/msi: Use struct_size() helper in devm_kzalloc() 2022-01-23 16:15:15 -05:00
ntb_transport.c bus: Make remove callback return void 2021-07-21 11:53:42 +02:00