Adam Vodopjan c8b89f10a4 ata: ahci: Fix PCS quirk application for suspend ... [ Upstream commit 37e14e4f37 ] Since kernel 5.3.4 my laptop (ICH8M controller) does not see Kingston SV300S37A60G SSD disk connected into a SATA connector on wake from suspend. The problem was introduced in c312ef1763 ("libata/ahci: Drop PCS quirk for Denverton and beyond"): the quirk is not applied on wake from suspend as it originally was. It is worth to mention the commit contained another bug: the quirk is not applied at all to controllers which require it. The fix commit 09d6ac8dc5 ("libata/ahci: Fix PCS quirk application") landed in 5.3.8. So testing my patch anywhere between commits c312ef1763 and 09d6ac8dc5 is pointless. Not all disks trigger the problem. For example nothing bad happens with Western Digital WD5000LPCX HDD. Test hardware: - Acer 5920G with ICH8M SATA controller - sda: some SATA HDD connnected into the DVD drive IDE port with a SATA-IDE caddy. It is a boot disk - sdb: Kingston SV300S37A60G SSD connected into the only SATA port Sample "dmesg --notime | grep -E '^(sd |ata)'" output on wake: sd 0:0:0:0: [sda] Starting disk sd 2:0:0:0: [sdb] Starting disk ata4: SATA link down (SStatus 4 SControl 300) ata3: SATA link down (SStatus 4 SControl 300) ata1.00: ACPI cmd ef/03:0c:00:00:00:a0 (SET FEATURES) filtered out ata1.00: ACPI cmd ef/03:42:00:00:00:a0 (SET FEATURES) filtered out ata1: FORCE: cable set to 80c ata5: SATA link down (SStatus 0 SControl 300) ata3: SATA link down (SStatus 4 SControl 300) ata3: SATA link down (SStatus 4 SControl 300) ata3.00: disabled sd 2:0:0:0: rejecting I/O to offline device ata3.00: detaching (SCSI 2:0:0:0) sd 2:0:0:0: [sdb] Start/Stop Unit failed: Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK sd 2:0:0:0: [sdb] Synchronizing SCSI cache sd 2:0:0:0: [sdb] Synchronize Cache(10) failed: Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK sd 2:0:0:0: [sdb] Stopping disk sd 2:0:0:0: [sdb] Start/Stop Unit failed: Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK Commit c312ef1763 dropped ahci_pci_reset_controller() which internally calls ahci_reset_controller() and applies the PCS quirk if needed after that. It was called each time a reset was required instead of just ahci_reset_controller(). This patch puts the function back in place. Fixes: c312ef1763 ("libata/ahci: Drop PCS quirk for Denverton and beyond") Signed-off-by: Adam Vodopjan <grozzly@protonmail.com> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-01-04 11:26:24 +01:00
..
Kconfig	…
Makefile	…
acard-ahci.c	…
ahci.c	ata: ahci: Fix PCS quirk application for suspend	2023-01-04 11:26:24 +01:00
ahci.h	ata: ahci: Match EM_MAX_SLOTS with SATA_PMP_MAX_PORTS	2022-10-29 10:08:30 +02:00
ahci_brcm.c	…
ahci_ceva.c	…
ahci_da850.c	…
ahci_dm816.c	…
ahci_imx.c	ata: ahci-imx: Fix MODULE_ALIAS	2022-10-29 10:08:30 +02:00
ahci_mtk.c	…
ahci_mvebu.c	…
ahci_octeon.c	…
ahci_platform.c	…
ahci_qoriq.c	…
ahci_seattle.c	…
ahci_st.c	…
ahci_sunxi.c	…
ahci_tegra.c	…
ahci_xgene.c	…
ata_generic.c	…
ata_piix.c	…
libahci.c	…
libahci_platform.c	ata: libahci_platform: Sanity check the DT child nodes number	2022-10-21 12:39:22 +02:00
libata-acpi.c	…
libata-core.c	libata: add ATA_HORKAGE_NOLPM for Pioneer BDR-207M and BDR-205	2022-09-27 08:20:37 +09:00
libata-eh.c	…
libata-pata-timings.c	…
libata-pmp.c	…
libata-sata.c	ata: libata: fix NCQ autosense logic	2022-12-31 13:25:50 +01:00
libata-scsi.c	ata: libata-core: do not issue non-internal commands once EH is pending	2022-11-26 09:27:33 +01:00
libata-sff.c	…
libata-trace.c	…
libata-transport.c	ata: libata-transport: fix error handling in ata_tdev_add()	2022-11-26 09:27:32 +01:00
libata-transport.h	…
libata-zpodd.c	…
libata.h	…
pata_acpi.c	…
pata_ali.c	…
pata_amd.c	…
pata_arasan_cf.c	…
pata_artop.c	…
pata_atiixp.c	…
pata_atp867x.c	…
pata_bk3710.c	…
pata_buddha.c	…
pata_cmd64x.c	…
pata_cmd640.c	…
pata_cs5520.c	…
pata_cs5530.c	…
pata_cs5535.c	…
pata_cs5536.c	…
pata_cypress.c	…
pata_efar.c	…
pata_ep93xx.c	…
pata_falcon.c	…
pata_ftide010.c	…
pata_gayle.c	…
pata_hpt3x2n.c	…
pata_hpt3x3.c	…
pata_hpt37x.c	…
pata_hpt366.c	…
pata_icside.c	…
pata_imx.c	…
pata_isapnp.c	…
pata_it821x.c	…
pata_it8213.c	…
pata_ixp4xx_cf.c	…
pata_jmicron.c	…
pata_legacy.c	ata: pata_legacy: fix pdc20230_set_piomode()	2022-11-10 18:17:17 +01:00
pata_macio.c	…
pata_marvell.c	…
pata_mpc52xx.c	…
pata_mpiix.c	…
pata_netcell.c	…
pata_ninja32.c	…
pata_ns87410.c	…
pata_ns87415.c	…
pata_octeon_cf.c	…
pata_of_platform.c	…
pata_oldpiix.c	…
pata_opti.c	…
pata_optidma.c	…
pata_palmld.c	ata: palmld: fix return value check in palmld_pata_probe()	2022-11-10 18:17:17 +01:00
pata_pcmcia.c	…
pata_pdc202xx_old.c	…
pata_pdc2027x.c	…
pata_piccolo.c	…
pata_platform.c	…
pata_pxa.c	…
pata_radisys.c	…
pata_rb532_cf.c	…
pata_rdc.c	…
pata_rz1000.c	…
pata_samsung_cf.c	…
pata_sc1200.c	…
pata_sch.c	…
pata_serverworks.c	…
pata_sil680.c	…
pata_sis.c	…
pata_sl82c105.c	…
pata_triflex.c	…
pata_via.c	…
pdc_adma.c	…
sata_dwc_460ex.c	…
sata_fsl.c	…
sata_gemini.c	…
sata_gemini.h	…
sata_highbank.c	…
sata_inic162x.c	…
sata_mv.c	…
sata_nv.c	…
sata_promise.c	…
sata_promise.h	…
sata_qstor.c	…
sata_rcar.c	…
sata_sil.c	…
sata_sil24.c	…
sata_sis.c	…
sata_svw.c	…
sata_sx4.c	…
sata_uli.c	…
sata_via.c	…
sata_vsc.c	…
sis.h	…