linux-stable/drivers/iio
Rasmus Villemoes d8c1111add iio: addac: ad74413r: fix integer promotion bug in ad74413_get_input_current_offset()
commit 980389d06d upstream.

The constant AD74413R_ADC_RESULT_MAX is defined via GENMASK, so its
type is "unsigned long".

Hence in the expression voltage_offset * AD74413R_ADC_RESULT_MAX,
voltage_offset is first promoted to unsigned long, and since it may be
negative, that results in a garbage value. For example, when range is
AD74413R_ADC_RANGE_5V_BI_DIR, voltage_offset is -2500 and
voltage_range is 5000, so the RHS of this assignment is, depending on
sizeof(long), either 826225UL or 3689348814709142UL, which after
truncation to int then results in either 826225 or 1972216214 being
the output from in_currentX_offset.

Casting to int avoids that promotion and results in the correct -32767
output.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Fixes: fea251b6a5 (iio: addac: add AD74413R driver)
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20221118123209.1658420-1-linux@rasmusvillemoes.dk
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-12-31 13:26:52 +01:00
..
accel iio: accel: bma400: Fix memory leak in bma400_get_steps_reg() 2022-12-02 17:43:10 +01:00
adc iio: adc128s052: add proper .data members in adc128_of_match table 2022-12-31 13:26:52 +01:00
addac iio: addac: ad74413r: fix integer promotion bug in ad74413_get_input_current_offset() 2022-12-31 13:26:52 +01:00
afe iio: afe: rescale: export symbols used during testing 2022-07-16 19:01:14 +01:00
amplifiers iio: amplifiers: ad8366: Fix alignment for DMA safety 2022-06-14 11:53:15 +01:00
buffer iio: core: Simplify the registration of kfifo buffers 2022-04-10 16:25:46 +01:00
cdc
chemical iio: chemical: scd4x: Switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() 2022-07-18 18:48:17 +01:00
common iio: cros: Register FIFO callback after sensor is registered 2022-07-18 18:29:13 +01:00
dac iio: dac: ad5593r: Fix i2c read protocol requirements 2022-10-21 12:37:34 +02:00
dummy Bitmap patches for 5.19-rc1 2022-06-04 14:04:27 -07:00
filter iio:filter:admv8818: select REGMAP_SPI for ADMV8818 2022-04-04 09:19:01 +01:00
frequency IIO new device support, features and minor fixes for 5.20 2022-07-14 15:04:49 +02:00
gyro iio: gyro: itg3200: Switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() 2022-07-18 18:48:18 +01:00
health iio: health: afe4404: Fix oob read in afe4404_[read|write]_raw 2022-12-08 11:30:14 +01:00
humidity IIO new device support, features and minor fixes for 5.20 2022-07-14 15:04:49 +02:00
imu iio: adis: add '__adis_enable_irq()' implementation 2022-12-31 13:26:26 +01:00
light iio: light: rpr0521: add missing Kconfig dependencies 2022-12-08 11:30:14 +01:00
magnetometer iio: magnetometer: yas530: Change data type of hard_offsets to signed 2022-10-21 12:38:37 +02:00
multiplexer iio: multiplexer: Make use of device properties 2022-04-04 09:11:24 +01:00
orientation
position
potentiometer iio: potentiometer: mcp4131: Fix alignment for DMA safety 2022-06-14 11:53:19 +01:00
potentiostat iio: lmp91000: Remove no-op trigger ops 2021-11-17 17:51:38 +00:00
pressure iio: pressure: ms5611: changed hardcoded SPI speed to value limited 2022-11-26 09:27:47 +01:00
proximity iio: proximity: cros_ec_mkbp: Switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() 2022-07-18 18:48:18 +01:00
resolver iio: resolver: ad2s90: Fix alignment for DMA safety 2022-06-14 11:53:19 +01:00
temperature iio: temperature: ltc2983: make bulk write buffer DMA-safe 2022-12-31 13:26:26 +01:00
test iio: test: rework Kconfig to support modules 2022-07-16 19:03:41 +01:00
trigger iio: trigger: sysfs: fix possible memory leak in iio_sysfs_trig_init() 2022-11-26 09:27:47 +01:00
Kconfig iio: add filter subfolder 2021-12-16 17:29:46 +00:00
Makefile iio: add filter subfolder 2021-12-16 17:29:46 +00:00
TODO
iio_core.h
iio_core_trigger.h
industrialio-buffer.c iio: Don't use bare "unsigned" 2022-07-01 11:19:08 +01:00
industrialio-configfs.c
industrialio-core.c iio: Use per-device lockdep class for mlock 2022-10-21 12:38:43 +02:00
industrialio-event.c iio: fix memory leak in iio_device_register_eventset() 2022-12-31 13:26:52 +01:00
industrialio-sw-device.c iio: Don't use bare "unsigned" 2022-07-01 11:19:08 +01:00
industrialio-sw-trigger.c iio: core: Fix entry not deleted when iio_register_sw_trigger_type() fails 2022-12-02 17:43:10 +01:00
industrialio-trigger.c iio: Be consistent with allocation result tests. 2022-07-18 18:29:30 +01:00
industrialio-triggered-event.c
inkern.c iio: inkern: fix return value in devm_of_iio_channel_get_by_name() 2022-10-21 12:38:37 +02:00