linux-stable/drivers/platform
ChiYuan Huang cb29811d98 regulator: core: Use different devices for resource allocation and DT lookup
[ Upstream commit 8f3cbcd6b4 ]

Following by the below discussion, there's the potential UAF issue
between regulator and mfd.
https://lore.kernel.org/all/20221128143601.1698148-1-yangyingliang@huawei.com/

From the analysis of Yingliang

CPU A				|CPU B
mt6370_probe()			|
  devm_mfd_add_devices()	|
				|mt6370_regulator_probe()
				|  regulator_register()
				|    //allocate init_data and add it to devres
				|    regulator_of_get_init_data()
i2c_unregister_device()		|
  device_del()			|
    devres_release_all()	|
      // init_data is freed	|
      release_nodes()		|
				|  // using init_data causes UAF
				|  regulator_register()

It's common to use mfd core to create child device for the regulator.
In order to do the DT lookup for init data, the child that registered
the regulator would pass its parent as the parameter. And this causes
init data resource allocated to its parent, not itself. The issue happen
when parent device is going to release and regulator core is still doing
some operation of init data constraint for the regulator of child device.

To fix it, this patch expand 'regulator_register' API to use the
different devices for init data allocation and DT lookup.

Reported-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
Link: https://lore.kernel.org/r/1670311341-32664-1-git-send-email-u0084500@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-12-31 13:26:47 +01:00
..
chrome platform/chrome: cros_ec_typec: zero out stale pointers 2022-12-31 13:25:47 +01:00
goldfish platform: goldfish: pipe: Use platform_get_irq() to get the interrupt 2022-03-18 13:55:21 +01:00
mellanox platform/mellanox: mlxbf-pmc: Fix event typo 2022-12-31 13:25:48 +01:00
mips MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error. 2022-06-09 22:24:19 +02:00
olpc platform/olpc: Fix uninitialized data in debugfs write 2022-07-28 20:40:15 +02:00
surface platform/surface: aggregator_registry: Add support for Surface Laptop 5 2022-12-02 17:43:15 +01:00
x86 regulator: core: Use different devices for resource allocation and DT lookup 2022-12-31 13:26:47 +01:00
Kconfig platform/x86: Kconfig: Remove unnecessary "if X86" 2022-06-27 09:37:49 +02:00
Makefile platform: Add Surface platform directory 2020-10-27 12:51:03 +01:00