linux-stable/drivers/watchdog
Mika Westerberg bdec1b9924 watchdog: iTCO_wdt: Set NO_REBOOT if the watchdog is not already running
[ Upstream commit ef9b7bf52c ]

Daniel reported that the commit 1ae3e78c08 ("watchdog: iTCO_wdt: No
need to stop the timer in probe") makes QEMU implementation of the iTCO
watchdog not to trigger reboot anymore when NO_REBOOT flag is initially
cleared using this option (in QEMU command line):

  -global ICH9-LPC.noreboot=false

The problem with the commit is that it left the unconditional setting of
NO_REBOOT that is not cleared anymore when the kernel keeps pinging the
watchdog (as opposed to the previous code that called iTCO_wdt_stop()
that cleared it).

Fix this so that we only set NO_REBOOT if the watchdog was not initially
running.

Fixes: 1ae3e78c08 ("watchdog: iTCO_wdt: No need to stop the timer in probe")
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20221028062750.45451-1-mika.westerberg@linux.intel.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-12-31 13:26:29 +01:00
..
Kconfig
Makefile
acquirewdt.c
advantechwdt.c
alim1535_wdt.c
alim7101_wdt.c
apple_wdt.c
ar7_wdt.c
arm_smc_wdt.c
armada_37xx_wdt.c
asm9260_wdt.c
aspeed_wdt.c
at91rm9200_wdt.c
at91sam9_wdt.c
at91sam9_wdt.h
ath79_wdt.c
bcm47xx_wdt.c
bcm2835_wdt.c
bcm7038_wdt.c
bcm_kona_wdt.c
bd9576_wdt.c
booke_wdt.c
cadence_wdt.c
cpu5wdt.c
cpwd.c
da9052_wdt.c
da9055_wdt.c
da9062_wdt.c
da9063_wdt.c
davinci_wdt.c
db8500_wdt.c
diag288_wdt.c
digicolor_wdt.c
dw_wdt.c
ebc-c384_wdt.c
ep93xx_wdt.c
eurotechwdt.c
f71808e_wdt.c
ftwdt010_wdt.c
gef_wdt.c
geodewdt.c
gpio_wdt.c
gxp-wdt.c
hpwdt.c
i6300esb.c
iTCO_vendor.h
iTCO_vendor_support.c
iTCO_wdt.c
ib700wdt.c
ibmasr.c
ie6xx_wdt.c
imgpdc_wdt.c
imx2_wdt.c
imx7ulp_wdt.c
imx_sc_wdt.c
indydog.c
intel-mid_wdt.c
it87_wdt.c
it8712f_wdt.c
ixp4xx_wdt.c
jz4740_wdt.c
keembay_wdt.c
kempld_wdt.c
lantiq_wdt.c
loongson1_wdt.c
lpc18xx_wdt.c
m54xx_wdt.c
machzwd.c
max63xx_wdt.c
max77620_wdt.c
mei_wdt.c
mena21_wdt.c
menf21bmc_wdt.c
menz69_wdt.c
meson_gxbb_wdt.c
meson_wdt.c
mixcomwd.c
mlx_wdt.c
moxart_wdt.c
mpc8xxx_wdt.c
msc313e_wdt.c
mt7621_wdt.c
mtk_wdt.c
mtx-1_wdt.c
ni903x_wdt.c
nic7018_wdt.c
npcm_wdt.c
nv_tco.c
nv_tco.h
octeon-wdt-main.c
octeon-wdt-nmi.S
of_xilinx_wdt.c
omap_wdt.c
omap_wdt.h
orion_wdt.c
pc87413_wdt.c
pcwd.c
pcwd_pci.c
pcwd_usb.c
pic32-dmt.c
pic32-wdt.c
pika_wdt.c
pm8916_wdt.c
pnx4008_wdt.c
pretimeout_noop.c
pretimeout_panic.c
pseries-wdt.c
qcom-wdt.c
rave-sp-wdt.c
rc32434_wdt.c
rdc321x_wdt.c
realtek_otto_wdt.c
renesas_wdt.c
retu_wdt.c
riowd.c
rn5t618_wdt.c
rt2880_wdt.c
rtd119x_wdt.c
rti_wdt.c
rza_wdt.c
rzg2l_wdt.c
rzn1_wdt.c
s3c2410_wdt.c
sa1100_wdt.c
sama5d4_wdt.c
sb_wdog.c
sbc60xxwdt.c
sbc7240_wdt.c
sbc8360.c
sbc_epx_c3.c
sbc_fitpc2_wdt.c
sbsa_gwdt.c
sc520_wdt.c
sc1200wdt.c
sch311x_wdt.c
scx200_wdt.c
shwdt.c
simatic-ipc-wdt.c
sl28cpld_wdt.c
smsc37b787_wdt.c
softdog.c
sp805_wdt.c
sp5100_tco.c
sp5100_tco.h
sprd_wdt.c
st_lpc_wdt.c
stm32_iwdg.c
stmp3xxx_rtc_wdt.c
stpmic1_wdt.c
sun4v_wdt.c
sunplus_wdt.c
sunxi_wdt.c
tegra_wdt.c
tqmx86_wdt.c
ts72xx_wdt.c
ts4800_wdt.c
twl4030_wdt.c
txx9wdt.c
uniphier_wdt.c
via_wdt.c
visconti_wdt.c
w83627hf_wdt.c
w83877f_wdt.c
w83977f_wdt.c
wafer5823wdt.c
watchdog_core.c
watchdog_core.h
watchdog_dev.c
watchdog_hrtimer_pretimeout.c
watchdog_pretimeout.c
watchdog_pretimeout.h
wd501p.h
wdat_wdt.c
wdrtas.c
wdt.c
wdt285.c
wdt977.c
wdt_pci.c
wm831x_wdt.c
wm8350_wdt.c
xen_wdt.c
ziirave_wdt.c