Changbin Du c550f0055c modules: wait do_free_init correctly ... [ Upstream commit 8f8cd6c0a4 ] The synchronization here is to ensure the ordering of freeing of a module init so that it happens before W+X checking. It is worth noting it is not that the freeing was not happening, it is just that our sanity checkers raced against the permission checkers which assume init memory is already gone. Commit 1a7b7d9220 ("modules: Use vmalloc special flag") moved calling do_free_init() into a global workqueue instead of relying on it being called through call_rcu(..., do_free_init), which used to allowed us call do_free_init() asynchronously after the end of a subsequent grace period. The move to a global workqueue broke the gaurantees for code which needed to be sure the do_free_init() would complete with rcu_barrier(). To fix this callers which used to rely on rcu_barrier() must now instead use flush_work(&init_free_wq). Without this fix, we still could encounter false positive reports in W+X checking since the rcu_barrier() here can not ensure the ordering now. Even worse, the rcu_barrier() can introduce significant delay. Eric Chanudet reported that the rcu_barrier introduces ~0.1s delay on a PREEMPT_RT kernel. [ 0.291444] Freeing unused kernel memory: 5568K [ 0.402442] Run /sbin/init as init process With this fix, the above delay can be eliminated. Link: https://lkml.kernel.org/r/20240227023546.2490667-1-changbin.du@huawei.com Fixes: 1a7b7d9220 ("modules: Use vmalloc special flag") Signed-off-by: Changbin Du <changbin.du@huawei.com> Tested-by: Eric Chanudet <echanude@redhat.com> Acked-by: Luis Chamberlain <mcgrof@kernel.org> Cc: Xiaoyi Su <suxiaoyi@huawei.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-03-26 18:20:52 -04:00
..
Kconfig	module: Move module's Kconfig items in kernel/module/	2022-07-12 12:07:25 -07:00
Makefile	…
debug_kmemleak.c	…
decompress.c	module/decompress: use vmalloc() for gzip decompression workspace	2023-11-20 11:52:03 +01:00
internal.h	dyndbg: gather __dyndbg[] state into struct _ddebug_info	2022-09-07 17:04:48 +02:00
kallsyms.c	kallsyms: Make module_kallsyms_on_each_symbol generally available	2024-01-05 15:18:40 +01:00
kdb.c	…
livepatch.c	…
main.c	modules: wait do_free_init correctly	2024-03-26 18:20:52 -04:00
procfs.c	module: Modify module_flags() to accept show_state argument	2022-07-14 17:40:23 -07:00
signing.c	…
strict_rwx.c	…
sysfs.c	…
tracking.c	module: tracking: Keep a record of tainted unloaded modules only	2022-10-10 12:16:19 -07:00
tree_lookup.c	…
version.c	…