linux-stable/security/keys
Jarkko Sakkinen 681935009f KEYS: trusted: Do not use WARN when encode fails
commit 050bf3c793 upstream.

When asn1_encode_sequence() fails, WARN is not the correct solution.

1. asn1_encode_sequence() is not an internal function (located
   in lib/asn1_encode.c).
2. Location is known, which makes the stack trace useless.
3. Results a crash if panic_on_warn is set.

It is also noteworthy that the use of WARN is undocumented, and it
should be avoided unless there is a carefully considered rationale to
use it.

Replace WARN with pr_err, and print the return value instead, which is
only useful piece of information.

Cc: stable@vger.kernel.org # v5.13+
Fixes: f221974525 ("security: keys: trusted: use ASN.1 TPM2 key format for the blobs")
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-05-25 16:21:35 +02:00
..
encrypted-keys Revert "KEYS: encrypted: Add check for strsep" 2024-01-25 15:27:52 -08:00
trusted-keys KEYS: trusted: Do not use WARN when encode fails 2024-05-25 16:21:35 +02:00
Kconfig
Makefile
big_key.c
compat.c
compat_dh.c
dh.c
gc.c keys, dns: Allow key types (eg. DNS) to be reclaimed immediately on expiry 2024-01-01 12:38:58 +00:00
internal.h keys, dns: Allow key types (eg. DNS) to be reclaimed immediately on expiry 2024-01-01 12:38:58 +00:00
key.c keys: Fix overwrite of key expiration on instantiation 2024-05-17 11:56:23 +02:00
keyctl.c security: keys: perform capable check only on privileged operations 2023-09-13 09:42:23 +02:00
keyctl_pkey.c
keyring.c
permission.c
persistent.c
proc.c keys, dns: Allow key types (eg. DNS) to be reclaimed immediately on expiry 2024-01-01 12:38:58 +00:00
process_keys.c
request_key.c keys: Fix linking a duplicate key to a keyring's assoc_array 2023-07-27 08:50:24 +02:00
request_key_auth.c
sysctl.c
user_defined.c