Magnus Karlsson 3e7722c31d xsk: fix refcount underflow in error path ... commit 85c2c79a07 upstream. Fix a refcount underflow problem reported by syzbot that can happen when a system is running out of memory. If xp_alloc_tx_descs() fails, and it can only fail due to not having enough memory, then the error path is triggered. In this error path, the refcount of the pool is decremented as it has incremented before. However, the reference to the pool in the socket was not nulled. This means that when the socket is closed later, the socket teardown logic will think that there is a pool attached to the socket and try to decrease the refcount again, leading to a refcount underflow. I chose this fix as it involved adding just a single line. Another option would have been to move xp_get_pool() and the assignment of xs->pool to after the if-statement and using xs_umem->pool instead of xs->pool in the whole if-statement resulting in somewhat simpler code, but this would have led to much more churn in the code base perhaps making it harder to backport. Fixes: ba3beec2ec ("xsk: Fix possible crash when multiple sockets are created") Reported-by: syzbot+8ada0057e69293a05fd4@syzkaller.appspotmail.com Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> Link: https://lore.kernel.org/r/20230809142843.13944-1-magnus.karlsson@gmail.com Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-08-16 18:32:26 +02:00
..
Kconfig	…
Makefile	…
xdp_umem.c	…
xdp_umem.h	…
xsk.c	xsk: fix refcount underflow in error path	2023-08-16 18:32:26 +02:00
xsk.h	…
xsk_buff_pool.c	…
xsk_diag.c	…
xsk_queue.c	…
xsk_queue.h	xsk: Elide base_addr comparison in xp_unaligned_validate_desc	2023-04-13 15:00:11 +02:00
xskmap.c	bpf: Centralize permissions checks for all BPF map types	2023-08-11 12:14:15 +02:00