Dmitry Torokhov 1e54beadc5 kvm/vfio: ensure kvg instance stays around in kvm_vfio_group_add() ... [ Upstream commit 9e0f4f2918 ] kvm_vfio_group_add() creates kvg instance, links it to kv->group_list, and calls kvm_vfio_file_set_kvm() with kvg->file as an argument after dropping kv->lock. If we race group addition and deletion calls, kvg instance may get freed by the time we get around to calling kvm_vfio_file_set_kvm(). Previous iterations of the code did not reference kvg->file outside of the critical section, but used a temporary variable. Still, they had similar problem of the file reference being owned by kvg structure and potential for kvm_vfio_group_del() dropping it before kvm_vfio_group_add() had a chance to complete. Fix this by moving call to kvm_vfio_file_set_kvm() under the protection of kv->lock. We already call it while holding the same lock when vfio group is being deleted, so it should be safe here as well. Fixes: 2fc1bec158 ("kvm: set/clear kvm to/from vfio_group when group add/delete") Reviewed-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Link: https://lore.kernel.org/r/20230714224538.404793-1-dmitry.torokhov@gmail.com Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-09-13 09:48:21 +02:00
..
Kconfig	KVM: Opt out of generic hardware enabling on s390 and PPC	2022-12-29 15:48:37 -05:00
Makefile.kvm	KVM: Reinstate gfn_to_pfn_cache with invalidation support	2022-01-07 10:44:44 -05:00
async_pf.c	KVM: Add helpers to wake/query blocking vCPU	2021-12-08 04:24:54 -05:00
async_pf.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 504	2019-06-19 17:09:56 +02:00
binary_stats.c	KVM: stats: remove dead stores	2021-08-13 03:35:15 -04:00
coalesced_mmio.c	KVM: Destroy target device if coalesced MMIO unregistration fails	2023-02-01 11:25:05 -08:00
coalesced_mmio.h	…
dirty_ring.c	KVM: Support dirty ring in conjunction with bitmap	2022-11-10 13:11:58 +00:00
eventfd.c	KVM: x86/ioapic: Resample the pending state of an IRQ when unmasking	2023-03-27 10:13:28 -04:00
irqchip.c	KVM: replace direct irq.h inclusion	2022-11-09 12:31:37 -05:00
kvm_main.c	KVM: Grab a reference to KVM for VM and vCPU stats file descriptors	2023-08-03 10:26:01 +02:00
kvm_mm.h	kvm: Remove the unused macro KVM_MMU_READ_{,UN}LOCK()	2022-12-27 06:00:51 -05:00
pfncache.c	KVM: Skip unnecessary "unmap" if gpc is already valid during refresh	2022-11-30 19:25:24 +00:00
vfio.c	kvm/vfio: ensure kvg instance stays around in kvm_vfio_group_add()	2023-09-13 09:48:21 +02:00
vfio.h	…