Dan Williams b50bb50392 cxl/core: Fix potential payload size confusion in cxl_mem_get_poison() ... [ Upstream commit 4b759dd576 ] A recent change to cxl_mem_get_records_log() [1] highlighted a subtle nuance of looping calls to cxl_internal_send_cmd(), i.e. that cxl_internal_send_cmd() modifies the 'size_out' member of the @mbox_cmd argument. That mechanism is useful for communicating underflow, but it is unwanted when reusing @mbox_cmd for a subsequent submission. It turns out that cxl_xfer_log() avoids this scenario by always redefining @mbox_cmd each iteration. Update cxl_mem_get_records_log() and cxl_mem_get_poison() to follow the same style as cxl_xfer_log(), i.e. re-define @mbox_cmd each iteration. The cxl_mem_get_records_log() change is just a style fixup, but the cxl_mem_get_poison() change is a potential fix, per Alison [2]: Poison list retrieval can hit this case if the MORE flag is set and a follow on read of the list delivers more records than the previous read. ie. device gives one record, sets the _MORE flag, then gives 5. Not an urgent fix since this behavior has not been seen in the wild, but worth tracking as a fix. Cc: Kwangjin Ko <kwangjin.ko@sk.com> Cc: Alison Schofield <alison.schofield@intel.com> Fixes: ed83f7ca39 ("cxl/mbox: Add GET_POISON_LIST mailbox command") Link: http://lore.kernel.org/r/20240402081404.1106-2-kwangjin.ko@sk.com [1] Link: http://lore.kernel.org/r/ZhAhAL/GOaWFrauw@aschofie-mobl2 [2] Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com> Reviewed-by: Alison Schofield <alison.schofield@intel.com> Link: https://lore.kernel.org/r/171235441633.2716581.12330082428680958635.stgit@dwillia2-xfh.jf.intel.com Signed-off-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-05-02 16:32:35 +02:00
..
core	cxl/core: Fix potential payload size confusion in cxl_mem_get_poison()	2024-05-02 16:32:35 +02:00
Kconfig	cxl: fix CONFIG_FW_LOADER dependency	2023-07-14 14:32:22 -06:00
Makefile	cxl/pmem: Introduce nvdimm_security_ops with ->get_flags() operation	2022-11-30 16:30:47 -08:00
acpi.c	cxl/acpi: Fix load failures due to single window creation failure	2024-03-01 13:34:59 +01:00
cxl.h	cxl/port: Fix missing target list lock	2024-01-25 15:35:55 -08:00
cxlmem.h	cxl/memdev: Fix sanitize vs decoder setup locking	2023-11-20 11:59:30 +01:00
cxlpci.h	cxl/pci: Find and register CXL PMU devices	2023-05-30 11:20:35 -07:00
mem.c	Merge branch 'for-6.5/cxl-rch-eh' into for-6.5/cxl	2023-06-25 18:56:13 -07:00
pci.c	cxl/core/regs: Rename @dev to @host in struct cxl_register_map	2023-11-20 11:59:31 +01:00
pmem.c	cxl/mbox: Move mailbox related driver state to its own data structure	2023-06-25 14:31:08 -07:00
pmu.h	cxl/pci: Find and register CXL PMU devices	2023-05-30 11:20:35 -07:00
port.c	Merge branch 'for-6.5/cxl-rch-eh' into for-6.5/cxl	2023-06-25 18:56:13 -07:00
security.c	Merge branch 'for-6.5/cxl-type-2' into for-6.5/cxl	2023-06-25 17:16:51 -07:00