linux-stable/fs/fuse
Danny Lin 885d4c31a4 fuse: fix leaked ENOSYS error on first statx call
commit eb4b691b91 upstream.

FUSE attempts to detect server support for statx by trying it once and
setting no_statx=1 if it fails with ENOSYS, but consider the following
scenario:

- Userspace (e.g. sh) calls stat() on a file
  * succeeds
- Userspace (e.g. lsd) calls statx(BTIME) on the same file
  - request_mask = STATX_BASIC_STATS | STATX_BTIME
  - first pass: sync=true due to differing cache_mask
  - statx fails and returns ENOSYS
  - set no_statx and retry
  - retry sets mask = STATX_BASIC_STATS
  - now mask == cache_mask; sync=false (time_before: still valid)
  - so we take the "else if (stat)" path
  - "err" is still ENOSYS from the failed statx call

Fix this by zeroing "err" before retrying the failed call.

Fixes: d3045530bd ("fuse: implement statx")
Cc: stable@vger.kernel.org # v6.6
Signed-off-by: Danny Lin <danny@orbstack.dev>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-04-27 17:11:42 +02:00
..
Kconfig dax: remove CONFIG_DAX_DRIVER 2021-12-04 08:58:51 -08:00
Makefile fuse: move ioctl to separate source file 2021-04-12 15:04:30 +02:00
acl.c fs.idmapped.v6.3 2023-02-20 11:53:11 -08:00
control.c fuse: convert to ctime accessor functions 2023-07-24 10:29:59 +02:00
cuse.c driver core: class: remove module * from class_create() 2023-03-17 15:16:33 +01:00
dax.c fuse: dax: set fc->dax to NULL in fuse_dax_conn_free() 2023-12-20 17:01:52 +01:00
dev.c fuse_dev_ioctl(): switch to fdget() 2023-04-20 22:55:35 -04:00
dir.c fuse: fix leaked ENOSYS error on first statx call 2024-04-27 17:11:42 +02:00
file.c fuse: fix VM_MAYSHARE and direct_io_allow_mmap 2024-04-03 15:28:20 +02:00
fuse_i.h fuse: don't unhash root 2024-04-03 15:28:25 +02:00
inode.c fuse: don't unhash root 2024-04-03 15:28:25 +02:00
ioctl.c fuse: ioctl: translate ENOSYS in outarg 2023-06-21 11:17:36 +02:00
readdir.c fuse: cache btime 2023-08-21 12:14:59 +02:00
virtio_fs.c dax: enable dax fault handler to report VM_FAULT_HWPOISON 2023-06-26 07:54:23 -06:00
xattr.c fs.idmapped.v6.3 2023-02-20 11:53:11 -08:00