Vitaly Prosyak 74cd204c7a drm/sched: fix null-ptr-deref in init entity ... commit f34e8bb7d6 upstream. The bug can be triggered by sending an amdgpu_cs_wait_ioctl to the AMDGPU DRM driver on any ASICs with valid context. The bug was reported by Joonkyo Jung <joonkyoj@yonsei.ac.kr>. For example the following code: static void Syzkaller2(int fd) { union drm_amdgpu_ctx arg1; union drm_amdgpu_wait_cs arg2; arg1.in.op = AMDGPU_CTX_OP_ALLOC_CTX; ret = drmIoctl(fd, 0x140106442 /* amdgpu_ctx_ioctl */, &arg1); arg2.in.handle = 0x0; arg2.in.timeout = 0x2000000000000; arg2.in.ip_type = AMD_IP_VPE /* 0x9 */; arg2->in.ip_instance = 0x0; arg2.in.ring = 0x0; arg2.in.ctx_id = arg1.out.alloc.ctx_id; drmIoctl(fd, 0xc0206449 /* AMDGPU_WAIT_CS * /, &arg2); } The ioctl AMDGPU_WAIT_CS without previously submitted job could be assumed that the error should be returned, but the following commit 1decbf6bb0 modified the logic and allowed to have sched_rq equal to NULL. As a result when there is no job the ioctl AMDGPU_WAIT_CS returns success. The change fixes null-ptr-deref in init entity and the stack below demonstrates the error condition: [ +0.000007] BUG: kernel NULL pointer dereference, address: 0000000000000028 [ +0.007086] #PF: supervisor read access in kernel mode [ +0.005234] #PF: error_code(0x0000) - not-present page [ +0.005232] PGD 0 P4D 0 [ +0.002501] Oops: 0000 [#1] PREEMPT SMP KASAN NOPTI [ +0.005034] CPU: 10 PID: 9229 Comm: amd_basic Tainted: G B W L 6.7.0+ #4 [ +0.007797] Hardware name: ASUS System Product Name/ROG STRIX B550-F GAMING (WI-FI), BIOS 1401 12/03/2020 [ +0.009798] RIP: 0010:drm_sched_entity_init+0x2d3/0x420 [gpu_sched] [ +0.006426] Code: 80 00 00 00 00 00 00 00 e8 1a 81 82 e0 49 89 9c 24 c0 00 00 00 4c 89 ef e8 4a 80 82 e0 49 8b 5d 00 48 8d 7b 28 e8 3d 80 82 e0 <48> 83 7b 28 00 0f 84 28 01 00 00 4d 8d ac 24 98 00 00 00 49 8d 5c [ +0.019094] RSP: 0018:ffffc90014c1fa40 EFLAGS: 00010282 [ +0.005237] RAX: 0000000000000001 RBX: 0000000000000000 RCX: ffffffff8113f3fa [ +0.007326] RDX: fffffbfff0a7889d RSI: 0000000000000008 RDI: ffffffff853c44e0 [ +0.007264] RBP: ffffc90014c1fa80 R08: 0000000000000001 R09: fffffbfff0a7889c [ +0.007266] R10: ffffffff853c44e7 R11: 0000000000000001 R12: ffff8881a719b010 [ +0.007263] R13: ffff88810d412748 R14: 0000000000000002 R15: 0000000000000000 [ +0.007264] FS: 00007ffff7045540(0000) GS:ffff8883cc900000(0000) knlGS:0000000000000000 [ +0.008236] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ +0.005851] CR2: 0000000000000028 CR3: 000000011912e000 CR4: 0000000000350ef0 [ +0.007175] Call Trace: [ +0.002561] <TASK> [ +0.002141] ? show_regs+0x6a/0x80 [ +0.003473] ? __die+0x25/0x70 [ +0.003124] ? page_fault_oops+0x214/0x720 [ +0.004179] ? preempt_count_sub+0x18/0xc0 [ +0.004093] ? __pfx_page_fault_oops+0x10/0x10 [ +0.004590] ? srso_return_thunk+0x5/0x5f [ +0.004000] ? vprintk_default+0x1d/0x30 [ +0.004063] ? srso_return_thunk+0x5/0x5f [ +0.004087] ? vprintk+0x5c/0x90 [ +0.003296] ? drm_sched_entity_init+0x2d3/0x420 [gpu_sched] [ +0.005807] ? srso_return_thunk+0x5/0x5f [ +0.004090] ? _printk+0xb3/0xe0 [ +0.003293] ? __pfx__printk+0x10/0x10 [ +0.003735] ? asm_sysvec_apic_timer_interrupt+0x1b/0x20 [ +0.005482] ? do_user_addr_fault+0x345/0x770 [ +0.004361] ? exc_page_fault+0x64/0xf0 [ +0.003972] ? asm_exc_page_fault+0x27/0x30 [ +0.004271] ? add_taint+0x2a/0xa0 [ +0.003476] ? drm_sched_entity_init+0x2d3/0x420 [gpu_sched] [ +0.005812] amdgpu_ctx_get_entity+0x3f9/0x770 [amdgpu] [ +0.009530] ? finish_task_switch.isra.0+0x129/0x470 [ +0.005068] ? __pfx_amdgpu_ctx_get_entity+0x10/0x10 [amdgpu] [ +0.010063] ? __kasan_check_write+0x14/0x20 [ +0.004356] ? srso_return_thunk+0x5/0x5f [ +0.004001] ? mutex_unlock+0x81/0xd0 [ +0.003802] ? srso_return_thunk+0x5/0x5f [ +0.004096] amdgpu_cs_wait_ioctl+0xf6/0x270 [amdgpu] [ +0.009355] ? __pfx_amdgpu_cs_wait_ioctl+0x10/0x10 [amdgpu] [ +0.009981] ? srso_return_thunk+0x5/0x5f [ +0.004089] ? srso_return_thunk+0x5/0x5f [ +0.004090] ? __srcu_read_lock+0x20/0x50 [ +0.004096] drm_ioctl_kernel+0x140/0x1f0 [drm] [ +0.005080] ? __pfx_amdgpu_cs_wait_ioctl+0x10/0x10 [amdgpu] [ +0.009974] ? __pfx_drm_ioctl_kernel+0x10/0x10 [drm] [ +0.005618] ? srso_return_thunk+0x5/0x5f [ +0.004088] ? __kasan_check_write+0x14/0x20 [ +0.004357] drm_ioctl+0x3da/0x730 [drm] [ +0.004461] ? __pfx_amdgpu_cs_wait_ioctl+0x10/0x10 [amdgpu] [ +0.009979] ? __pfx_drm_ioctl+0x10/0x10 [drm] [ +0.004993] ? srso_return_thunk+0x5/0x5f [ +0.004090] ? __kasan_check_write+0x14/0x20 [ +0.004356] ? srso_return_thunk+0x5/0x5f [ +0.004090] ? _raw_spin_lock_irqsave+0x99/0x100 [ +0.004712] ? __pfx__raw_spin_lock_irqsave+0x10/0x10 [ +0.005063] ? __pfx_arch_do_signal_or_restart+0x10/0x10 [ +0.005477] ? srso_return_thunk+0x5/0x5f [ +0.004000] ? preempt_count_sub+0x18/0xc0 [ +0.004237] ? srso_return_thunk+0x5/0x5f [ +0.004090] ? _raw_spin_unlock_irqrestore+0x27/0x50 [ +0.005069] amdgpu_drm_ioctl+0x7e/0xe0 [amdgpu] [ +0.008912] __x64_sys_ioctl+0xcd/0x110 [ +0.003918] do_syscall_64+0x5f/0xe0 [ +0.003649] ? noist_exc_debug+0xe6/0x120 [ +0.004095] entry_SYSCALL_64_after_hwframe+0x6e/0x76 [ +0.005150] RIP: 0033:0x7ffff7b1a94f [ +0.003647] Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <41> 89 c0 3d 00 f0 ff ff 77 1f 48 8b 44 24 18 64 48 2b 04 25 28 00 [ +0.019097] RSP: 002b:00007fffffffe0a0 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ +0.007708] RAX: ffffffffffffffda RBX: 000055555558b360 RCX: 00007ffff7b1a94f [ +0.007176] RDX: 000055555558b360 RSI: 00000000c0206449 RDI: 0000000000000003 [ +0.007326] RBP: 00000000c0206449 R08: 000055555556ded0 R09: 000000007fffffff [ +0.007176] R10: 0000000000000000 R11: 0000000000000246 R12: 00007fffffffe5d8 [ +0.007238] R13: 0000000000000003 R14: 000055555555cba8 R15: 00007ffff7ffd040 [ +0.007250] </TASK> v2: Reworked check to guard against null ptr deref and added helpful comments (Christian) Cc: Christian Koenig <christian.koenig@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Luben Tuikov <ltuikov89@gmail.com> Cc: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Cc: Joonkyo Jung <joonkyoj@yonsei.ac.kr> Cc: Dokyung Song <dokyungs@yonsei.ac.kr> Cc: <jisoo.jang@yonsei.ac.kr> Cc: <yw9865@yonsei.ac.kr> Signed-off-by: Vitaly Prosyak <vitaly.prosyak@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Fixes: 56e449603f ("drm/sched: Convert the GPU scheduler to variable number of run-queues") Link: https://patchwork.freedesktop.org/patch/msgid/20240315023926.343164-1-vitaly.prosyak@amd.com Signed-off-by: Christian König <christian.koenig@amd.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-04-03 15:11:59 +02:00
..
accel	eventfd: simplify eventfd_signal()	2024-04-03 15:11:23 +02:00
accessibility	speakup: Fix 8bit characters from direct synth	2024-04-03 15:11:21 +02:00
acpi	ACPI: scan: Fix device check notification handling	2024-03-26 18:18:21 -04:00
amba	…
android	binder: signal epoll threads of self-work	2024-02-23 09:51:40 +01:00
ata	scsi: sd: Fix TCG OPAL unlock on system resume	2024-04-03 15:11:54 +02:00
atm	atm: idt77252: fix a memleak in open_card_ubr0	2024-02-16 19:14:21 +01:00
auxdisplay	…
base	PM: sleep: wakeirq: fix wake irq warning in system suspend	2024-04-03 15:11:16 +02:00
bcma	…
block	aoe: fix the potential use-after-free problem in aoecmd_cfg_pkts	2024-03-26 18:18:01 -04:00
bluetooth	Bluetooth: btnxpuart: Fix btnxpuart_close	2024-04-03 15:11:19 +02:00
bus	bus: mhi: ep: check the correct variable in mhi_ep_register_controller()	2024-03-26 18:18:51 -04:00
cache	cache: ax45mp_cache: Align end size to cache boundary in ax45mp_dma_cache_wback()	2024-03-01 13:41:57 +01:00
cdrom	…
cdx	cdx: Unlock on error path in rescan_store()	2024-01-25 15:45:25 -08:00
char	tpm,tpm_tis: Avoid warning splat at shutdown	2024-04-03 15:11:24 +02:00
clk	clk: qcom: mmcc-msm8974: fix terminating of frequency table arrays	2024-04-03 15:11:14 +02:00
clocksource	clocksource/drivers/arm_global_timer: Fix maximum prescaler value	2024-04-03 15:11:42 +02:00
comedi	comedi: comedi_test: Prevent timers rescheduling during deletion	2024-03-26 18:18:50 -04:00
connector	connector/cn_proc: revert "connector: Fix proc_event_num_listeners count not cleared"	2024-02-23 09:51:36 +01:00
counter	…
cpufreq	cpufreq: dt: always allocate zeroed cpumask	2024-04-03 15:11:28 +02:00
cpuidle	cpuidle: haltpoll: Do not enable interrupts when entering idle	2024-01-25 15:44:40 -08:00
crypto	crypto: sun8i-ce - Fix use after free in unprepare	2024-04-03 15:11:35 +02:00
cxl	cxl/trace: Properly initialize cxl_poison region name	2024-04-03 15:11:29 +02:00
dax	…
dca	…
devfreq	PM / devfreq: Synchronize devfreq_monitor_[start/stop]	2024-02-05 20:16:46 +00:00
dio	…
dma	dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA	2024-03-26 18:18:29 -04:00
dma-buf	…
dpll	dpll: fix dpll_xa_ref_*_del() for multiple registrations	2024-03-26 18:18:25 -04:00
edac	EDAC/thunderx: Fix possible out-of-bounds string access	2024-01-25 15:44:37 -08:00
eisa	…
extcon	extcon: fix possible name leak in extcon_dev_register()	2024-02-05 20:17:04 +00:00
firewire	firewire: ohci: prevent leak of left-over IRQ on unbind	2024-04-03 15:11:37 +02:00
firmware	x86/efistub: Reinstate soft limit for initrd loading	2024-04-03 15:11:47 +02:00
fpga	eventfd: simplify eventfd_signal()	2024-04-03 15:11:23 +02:00
fsi	…
gnss	…
gpio	gpiolib: Pass consumer device through to core in devm_fwnode_gpiod_get_index()	2024-03-26 18:18:20 -04:00
gpu	drm/sched: fix null-ptr-deref in init entity	2024-04-03 15:11:59 +02:00
greybus	greybus: gb-beagleplay: Remove use of pad bytes	2024-01-25 15:45:23 -08:00
hid	HID: amd_sfh: Avoid disabling the interrupt	2024-03-26 18:18:40 -04:00
hsi	…
hte	…
hv	x86/hyperv: Use per cpu initial stack for vtl context	2024-03-26 18:18:52 -04:00
hwmon	hwmon: (amc6821) add of_match table	2024-04-03 15:11:20 +02:00
hwspinlock	…
hwtracing	hwtracing: hisi_ptt: Move type check to the beginning of hisi_ptt_pmu_event_init()	2024-03-26 18:18:51 -04:00
i2c	i2c: i801: Avoid potential double call to gpiod_remove_lookup_table	2024-04-03 15:11:41 +02:00
i3c	i3c: dw: Disable IBI IRQ depends on hot-join and SIR enabling	2024-03-26 18:18:46 -04:00
idle	x86: Fix CPUIDLE_FLAG_IRQ_ENABLE leaking timer reprogram	2024-01-25 15:44:37 -08:00
iio	iio: imu: inv_mpu6050: fix FIFO parsing when empty	2024-04-03 15:11:41 +02:00
infiniband	eventfd: simplify eventfd_signal()	2024-04-03 15:11:23 +02:00
input	Input: xpad - add additional HyperX Controller Identifiers	2024-04-03 15:11:36 +02:00
interconnect	interconnect: qcom: sm8550: Enable sync_state	2024-02-23 09:51:32 +01:00
iommu	iommu/dma: Force swiotlb_max_mapping_size on an untrusted device	2024-04-03 15:11:43 +02:00
ipack	…
irqchip	irqchip/renesas-rzg2l: Prevent spurious interrupts when setting trigger type	2024-04-03 15:11:44 +02:00
isdn	…
leds	leds: trigger: netdev: Fix kernel panic on interface rename trig notify	2024-04-03 15:11:19 +02:00
macintosh	…
mailbox	mailbox: arm_mhuv2: Fix a bug for mhuv2_sender_interrupt	2024-02-05 20:17:03 +00:00
mcb	…
md	dm snapshot: fix lockup in dm_exception_table_exit	2024-04-03 15:11:33 +02:00
media	media: nxp: imx8-isi: Mark all crossbar sink pads as MUST_CONNECT	2024-04-03 15:11:08 +02:00
memory	memory: tegra: Correct DLA client names	2024-03-26 18:18:17 -04:00
memstick	…
message	…
mfd	mfd: intel-lpss: Introduce QUIRK_CLOCK_DIVIDER_UNITY for XPS 9530	2024-04-03 15:11:45 +02:00
misc	mei: me: add arrow lake point H DID	2024-04-03 15:11:39 +02:00
mmc	sdhci-of-dwcmshc: disable PM runtime in dwcmshc_remove()	2024-04-03 15:11:50 +02:00
most	…
mtd	mtd: rawnand: Constrain even more when continuous reads are enabled	2024-04-03 15:11:28 +02:00
mux	…
net	net: ll_temac: platform_get_resource replaced by wrong function	2024-04-03 15:11:51 +02:00
nfc	…
ntb	NTB: fix possible name leak in ntb_register_device()	2024-03-26 18:18:34 -04:00
nubus	…
nvdimm	…
nvme	nvme: fix reconnection fail due to reserved tag allocation	2024-03-26 18:18:55 -04:00
nvmem	nvmem: meson-efuse: fix function pointer type mismatch	2024-04-03 15:11:20 +02:00
of	of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing	2024-03-06 14:53:54 +00:00
opp	OPP: debugfs: Fix warning around icc_get_name()	2024-03-26 18:18:26 -04:00
parisc	parisc/power: Fix power soft-off button emulation on qemu	2024-01-31 16:20:56 -08:00
parport	parport: parport_serial: Add Brainboxes device IDs and geometry	2024-01-20 11:53:02 +01:00
pci	PCI: hv: Fix ring buffer size calculation	2024-04-03 15:11:22 +02:00
pcmcia	…
peci	…
perf	perf: RISCV: Fix panic on pmu overflow handler	2024-03-26 18:17:55 -04:00
phy	phy: tegra: xusb: Add API to retrieve the port number of phy	2024-04-03 15:11:20 +02:00
pinctrl	gpio: nomadik: fix offset bug in nmk_pmx_set()	2024-03-26 18:18:41 -04:00
platform	platform/x86/intel/tpmi: Change vsec offset to u64	2024-04-03 15:11:24 +02:00
pmdomain	pmdomain: qcom: rpmhpd: Drop SA8540P gfx.lvl	2024-03-26 18:18:06 -04:00
pnp	PNP: ACPI: fix fortify warning	2024-02-05 20:16:45 +00:00
power	power: supply: mm8013: fix "not charging" detection	2024-03-26 18:18:42 -04:00
powercap	powercap: intel_rapl_tpmi: Fix System Domain probing	2024-04-03 15:11:10 +02:00
pps	…
ps3	…
ptp	ptp: ocp: fix bug in unregistering the DPLL subsystem	2023-12-29 08:37:23 +00:00
pwm	pwm: img: fix pwm clock lookup	2024-04-03 15:11:45 +02:00
rapidio	…
ras	…
regulator	regulator: userspace-consumer: add module device table	2024-03-26 18:18:20 -04:00
remoteproc	remoteproc: virtio: Fix wdg cannot recovery remote processor	2024-04-03 15:11:06 +02:00
reset	…
rpmsg	rpmsg: virtio: Free driver_override when rpmsg_remove()	2024-01-31 16:20:55 -08:00
rtc	rtc: mt6397: select IRQ_DOMAIN instead of depending on it	2024-03-26 18:18:52 -04:00
s390	s390/zcrypt: fix reference counting on zcrypt card objects	2024-04-03 15:11:25 +02:00
sbus	…
scsi	scsi: libsas: Fix disk not being scanned in after being removed	2024-04-03 15:11:59 +02:00
sh	…
siox	…
slimbus	slimbus: core: Remove usage of the deprecated ida_simple_xx() API	2024-04-03 15:11:20 +02:00
soc	soc: fsl: qbman: Use raw spinlock for cgr_lock	2024-04-03 15:11:25 +02:00
soundwire	soundwire: fix initializing sysfs for same devices on different buses	2024-01-31 16:20:53 -08:00
spi	spi: spi-mt65xx: Fix NULL pointer access in interrupt handler	2024-03-26 18:18:59 -04:00
spmi	spmi: mediatek: Fix UAF on device remove	2024-02-05 20:17:04 +00:00
ssb	…
staging	staging: vc04_services: fix information leak in create_component()	2024-04-03 15:11:54 +02:00
target	scsi: target: pscsi: Fix bio_put() for error case	2024-03-01 13:41:46 +01:00
tc	…
tee	tee: optee: Fix kernel panic caused by incorrect error handling	2024-04-03 15:11:40 +02:00
thermal	thermal: devfreq_cooling: Fix perf state when calculate dfc res_util	2024-04-03 15:11:50 +02:00
thunderbolt	thunderbolt: Fix NULL pointer dereference in tb_port_update_credits()	2024-04-03 15:11:36 +02:00
tty	Revert "tty: serial: simplify qcom_geni_serial_send_chunk_fifo()"	2024-04-03 15:11:39 +02:00
ufs	scsi: ufs: qcom: Provide default cycles_in_1us value	2024-04-03 15:11:54 +02:00
uio	uio: Fix use-after-free in uio_open	2024-01-20 11:53:01 +01:00
usb	usb: dwc3: pci: Drop duplicate ID	2024-04-03 15:11:58 +02:00
vdpa	eventfd: simplify eventfd_signal()	2024-04-03 15:11:23 +02:00
vfio	vfio/pds: Make sure migration file isn't accessed after reset	2024-04-03 15:11:53 +02:00
vhost	eventfd: simplify eventfd_signal()	2024-04-03 15:11:23 +02:00
video	backlight: lp8788: Fully initialize backlight_properties during probe	2024-03-26 18:18:43 -04:00
virt	eventfd: simplify eventfd_signal()	2024-04-03 15:11:23 +02:00
virtio	virtio: reenable config if freezing device failed	2024-04-03 15:11:30 +02:00
w1	…
watchdog	watchdog: stm32_iwdg: initialize default timeout	2024-03-26 18:18:47 -04:00
xen	eventfd: simplify eventfd_signal()	2024-04-03 15:11:23 +02:00
zorro	…
Kconfig	…
Makefile	…