Changbin Du 8c61e3beb0 modules: wait do_free_init correctly ... [ Upstream commit 8f8cd6c0a4 ] The synchronization here is to ensure the ordering of freeing of a module init so that it happens before W+X checking. It is worth noting it is not that the freeing was not happening, it is just that our sanity checkers raced against the permission checkers which assume init memory is already gone. Commit 1a7b7d9220 ("modules: Use vmalloc special flag") moved calling do_free_init() into a global workqueue instead of relying on it being called through call_rcu(..., do_free_init), which used to allowed us call do_free_init() asynchronously after the end of a subsequent grace period. The move to a global workqueue broke the gaurantees for code which needed to be sure the do_free_init() would complete with rcu_barrier(). To fix this callers which used to rely on rcu_barrier() must now instead use flush_work(&init_free_wq). Without this fix, we still could encounter false positive reports in W+X checking since the rcu_barrier() here can not ensure the ordering now. Even worse, the rcu_barrier() can introduce significant delay. Eric Chanudet reported that the rcu_barrier introduces ~0.1s delay on a PREEMPT_RT kernel. [ 0.291444] Freeing unused kernel memory: 5568K [ 0.402442] Run /sbin/init as init process With this fix, the above delay can be eliminated. Link: https://lkml.kernel.org/r/20240227023546.2490667-1-changbin.du@huawei.com Fixes: 1a7b7d9220 ("modules: Use vmalloc special flag") Signed-off-by: Changbin Du <changbin.du@huawei.com> Tested-by: Eric Chanudet <echanude@redhat.com> Acked-by: Luis Chamberlain <mcgrof@kernel.org> Cc: Xiaoyi Su <suxiaoyi@huawei.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-03-26 18:19:55 -04:00
..
Kconfig	module: add debugging auto-load duplicate module support	2023-04-19 17:26:01 -07:00
Makefile	module: add debugging auto-load duplicate module support	2023-04-19 17:26:01 -07:00
debug_kmemleak.c	…
decompress.c	module/decompress: use kvmalloc() consistently	2023-11-20 11:59:37 +01:00
dups.c	module: include internal.h in module/dups.c	2023-05-02 20:33:36 -07:00
internal.h	kbuild: generate KSYMTAB entries by modpost	2023-06-22 21:17:10 +09:00
kallsyms.c	modpost, kallsyms: Treat add '$'-prefixed symbols as mapping symbols	2023-07-24 12:09:47 -07:00
kdb.c	module: replace module_layout with module_memory	2023-03-09 12:55:15 -08:00
kmod.c	module: add debugging auto-load duplicate module support	2023-04-19 17:26:01 -07:00
livepatch.c	livepatch: fix ELF typos	2023-03-09 11:08:24 +01:00
main.c	modules: wait do_free_init correctly	2024-03-26 18:19:55 -04:00
procfs.c	module: replace module_layout with module_memory	2023-03-09 12:55:15 -08:00
signing.c	…
stats.c	module: Fix use-after-free bug in read_file_mod_stats()	2023-05-22 14:13:13 -07:00
strict_rwx.c	module: replace module_layout with module_memory	2023-03-09 12:55:15 -08:00
sysfs.c	…
tracking.c	module: add debug stats to help identify memory pressure	2023-04-18 11:15:24 -07:00
tree_lookup.c	module: replace module_layout with module_memory	2023-03-09 12:55:15 -08:00
version.c	…