Sven Schnelle 6d559e70b3 workqueue: Fix selection of wake_cpu in kick_pool() ... commit 57a01eafdc upstream. With cpu_possible_mask=0-63 and cpu_online_mask=0-7 the following kernel oops was observed: smp: Bringing up secondary CPUs ... smp: Brought up 1 node, 8 CPUs Unable to handle kernel pointer dereference in virtual kernel address space Failing address: 0000000000000000 TEID: 0000000000000803 [..] Call Trace: arch_vcpu_is_preempted+0x12/0x80 select_idle_sibling+0x42/0x560 select_task_rq_fair+0x29a/0x3b0 try_to_wake_up+0x38e/0x6e0 kick_pool+0xa4/0x198 __queue_work.part.0+0x2bc/0x3a8 call_timer_fn+0x36/0x160 __run_timers+0x1e2/0x328 __run_timer_base+0x5a/0x88 run_timer_softirq+0x40/0x78 __do_softirq+0x118/0x388 irq_exit_rcu+0xc0/0xd8 do_ext_irq+0xae/0x168 ext_int_handler+0xbe/0xf0 psw_idle_exit+0x0/0xc default_idle_call+0x3c/0x110 do_idle+0xd4/0x158 cpu_startup_entry+0x40/0x48 rest_init+0xc6/0xc8 start_kernel+0x3c4/0x5e0 startup_continue+0x3c/0x50 The crash is caused by calling arch_vcpu_is_preempted() for an offline CPU. To avoid this, select the cpu with cpumask_any_and_distribute() to mask __pod_cpumask with cpu_online_mask. In case no cpu is left in the pool, skip the assignment. tj: This doesn't fully fix the bug as CPUs can still go down between picking the target CPU and the wake call. Fixing that likely requires adding cpu_online() test to either the sched or s390 arch code. However, regardless of how that is fixed, workqueue shouldn't be picking a CPU which isn't online as that would result in unpredictable and worse behavior. Signed-off-by: Sven Schnelle <svens@linux.ibm.com> Fixes: 8639ecebc9 ("workqueue: Implement non-strict affinity scope for unbound workqueues") Cc: stable@vger.kernel.org # v6.6+ Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-05-17 12:15:02 +02:00
..
bpf	bpf: Check bloom filter map value size	2024-05-17 12:14:39 +02:00
cgroup	cgroup/cpuset: Fix retval in update_cpumask()	2024-02-29 10:30:35 -10:00
configs	hardening: Provide Kconfig fragments for basic options	2023-09-22 09:50:55 -07:00
debug	kdb: Fix a potential buffer overflow in kdb_local()	2024-01-17 17:19:06 +00:00
dma	swiotlb: initialise restricted pool list_head when SWIOTLB_DYNAMIC=y	2024-05-17 12:14:35 +02:00
entry	entry: Respect changes to system call number by trace_sys_enter()	2024-04-03 15:32:33 +02:00
events	uprobes: use pagesize-aligned virtual address when replacing pages	2024-01-25 23:52:20 -08:00
futex	futex: Prevent the reuse of stale pi_state	2024-01-19 12:58:17 +01:00
gcov	gcov: annotate struct gcov_iterator with __counted_by	2023-10-18 14:43:22 -07:00
irq	genirq: Introduce IRQF_COND_ONESHOT and use it in pinctrl-amd	2024-04-03 15:32:45 +02:00
kcsan	mm: delete checks for xor_unlock_is_negative_byte()	2023-10-18 14:34:17 -07:00
livepatch	livepatch: Fix missing newline character in klp_resolve_symbols()	2023-09-20 11:24:18 +02:00
locking	RCU pull request for v6.8	2024-01-12 16:35:58 -08:00
module	Revert "crypto: pkcs7 - remove sha1 support"	2024-04-03 15:32:31 +02:00
power	PM: s2idle: Make sure CPUs will wakeup directly on resume	2024-04-17 11:23:25 +02:00
printk	dump_stack: Do not get cpu_sync for panic CPU	2024-04-13 13:09:58 +02:00
rcu	rcu/nocb: Fix WARN_ON_ONCE() in the rcu_nocb_bypass_lock()	2024-04-13 13:10:04 +02:00
sched	sched/eevdf: Prevent vlag from going out of bounds in reweight_eevdf()	2024-05-02 16:35:34 +02:00
time	Fix memory leak in posix_clock_open()	2024-04-03 15:32:32 +02:00
trace	tracing: hide unused ftrace_event_id_fops	2024-04-17 11:23:35 +02:00
.gitignore	…
Kconfig.freezer	…
Kconfig.hz	…
Kconfig.kexec	kexec: select CRYPTO from KEXEC_FILE instead of depending on it	2023-12-20 13:46:19 -08:00
Kconfig.locks	…
Kconfig.preempt	…
Makefile	kernel/numa.c: Move logging out of numa.h	2023-12-20 19:26:30 -05:00
acct.c	fs: rename __mnt_{want,drop}_write*() helpers	2023-09-11 15:05:50 +02:00
async.c	header cleanups for 6.8	2024-01-10 16:43:55 -08:00
audit.c	audit: Send netlink ACK before setting connection in auditd_set	2023-11-12 22:33:49 -05:00
audit.h	…
audit_fsnotify.c	…
audit_tree.c	As usual, lots of singleton and doubleton patches all over the tree and	2023-11-02 20:53:31 -10:00
audit_watch.c	audit: don't WARN_ON_ONCE(!current->mm) in audit_exe_compare()	2023-11-14 17:34:27 -05:00
auditfilter.c	…
auditsc.c	audit,io_uring: io_uring openat triggers audit reference count underflow	2023-10-13 18:34:46 +02:00
backtracetest.c	…
bounds.c	bounds: Use the right number of bits for power-of-two CONFIG_NR_CPUS	2024-05-02 16:35:35 +02:00
capability.c	…
cfi.c	…
compat.c	…
configs.c	…
context_tracking.c	…
cpu.c	cpu: Re-enable CPU mitigations by default for !X86 architectures	2024-05-02 16:35:28 +02:00
cpu_pm.c	…
crash_core.c	mm: turn folio_test_hugetlb into a PageType	2024-05-02 16:35:32 +02:00
crash_dump.c	…
cred.c	cred: get rid of CONFIG_DEBUG_CREDENTIALS	2023-12-15 14:19:48 -08:00
delayacct.c	…
dma.c	…
exec_domain.c	…
exit.c	exit: wait_task_zombie: kill the no longer necessary spin_lock_irq(siglock)	2024-02-07 21:20:33 -08:00
exit.h	exit: add internal include file with helpers	2023-09-21 12:03:50 -06:00
extable.c	…
fail_function.c	…
fork.c	fork: defer linking file vma until vma is fully initialized	2024-04-27 17:13:04 +02:00
freezer.c	Linux 6.7-rc6	2023-12-23 15:52:13 +01:00
gen_kheaders.sh	…
groups.c	groups: Convert group_info.usage to refcount_t	2023-09-29 11:28:39 -07:00
hung_task.c	…
iomem.c	…
irq_work.c	…
jump_label.c	…
kallsyms.c	…
kallsyms_internal.h	…
kallsyms_selftest.c	Modules changes for v6.6-rc1	2023-08-29 17:32:32 -07:00
kallsyms_selftest.h	…
kcmp.c	file: convert to SLAB_TYPESAFE_BY_RCU	2023-10-19 11:02:48 +02:00
kcov.c	…
kexec.c	kernel: kexec: copy user-array safely	2023-10-09 16:59:47 +10:00
kexec_core.c	kexec: do syscore_shutdown() in kernel_kexec	2024-01-12 15:20:47 -08:00
kexec_elf.c	…
kexec_file.c	kexec_file: fix incorrect temp_start value in locate_mem_hole_top_down()	2023-12-29 12:22:25 -08:00
kexec_internal.h	…
kheaders.c	…
kprobes.c	kprobes: Fix possible use-after-free issue on kprobe registration	2024-04-17 11:23:36 +02:00
ksyms_common.c	…
ksysfs.c	…
kthread.c	As usual, lots of singleton and doubleton patches all over the tree and	2023-11-02 20:53:31 -10:00
latencytop.c	…
module_signature.c	…
notifier.c	…
nsproxy.c	…
numa.c	kernel/numa.c: Move logging out of numa.h	2023-12-20 19:26:30 -05:00
padata.c	padata: Fix refcnt handling in padata_free_shell()	2023-10-27 18:04:24 +08:00
panic.c	panic: Flush kernel log buffer at the end	2024-04-13 13:09:58 +02:00
params.c	params: Fix multi-line comment style	2023-12-01 09:51:44 -08:00
pid.c	file: remove __receive_fd()	2023-12-12 14:24:14 +01:00
pid_namespace.c	wait: Remove uapi header file from main header file	2023-12-20 19:26:31 -05:00
pid_sysctl.h	…
profile.c	…
ptrace.c	Quite a lot of kexec work this time around. Many singleton patches in	2024-01-09 11:46:20 -08:00
range.c	…
reboot.c	Thermal control updates for 6.8-rc1	2024-01-09 16:20:17 -08:00
regset.c	…
relay.c	kernel: relay: remove relay_file_splice_read dead code, doesn't work	2023-12-29 12:22:27 -08:00
resource.c	Quite a lot of kexec work this time around. Many singleton patches in	2024-01-09 11:46:20 -08:00
resource_kunit.c	…
rseq.c	…
scftorture.c	…
scs.c	…
seccomp.c	file: remove __receive_fd()	2023-12-12 14:24:14 +01:00
signal.c	kernel/signal.c: simplify force_sig_info_to_task(), kill recalc_sigpending_and_wake()	2023-12-10 17:21:32 -08:00
smp.c	CSD lock commits for v6.7	2023-10-30 17:56:53 -10:00
smpboot.c	kthread: add kthread_stop_put	2023-10-04 10:41:57 -07:00
smpboot.h	…
softirq.c	…
stackleak.c	…
stacktrace.c	stacktrace: fix kernel-doc typo	2023-12-29 12:22:29 -08:00
static_call.c	…
static_call_inline.c	…
stop_machine.c	…
sys.c	prctl: generalize PR_SET_MDWE support check to be per-arch	2024-04-03 15:32:37 +02:00
sys_ni.c	lsm/stable-6.8 PR 20240105	2024-01-09 12:57:46 -08:00
sysctl-test.c	…
sysctl.c	asm-generic updates for v6.7	2023-11-01 15:28:33 -10:00
task_work.c	task_work: add kerneldoc annotation for 'data' argument	2023-09-19 13:21:32 -07:00
taskstats.c	taskstats: fill_stats_for_tgid: use for_each_thread()	2023-10-04 10:41:57 -07:00
torture.c	torture: Print out torture module parameters	2023-09-24 17:24:01 +02:00
tracepoint.c	…
tsacct.c	…
ucount.c	…
uid16.c	…
uid16.h	…
umh.c	…
up.c	smp: Change function signatures to use call_single_data_t	2023-09-13 14:59:24 +02:00
user-return-notifier.c	…
user.c	binfmt_misc: enable sandboxed mounts	2023-10-11 08:46:01 -07:00
user_namespace.c	mnt_idmapping: decouple from namespaces	2023-11-28 14:08:47 +01:00
usermode_driver.c	…
utsname.c	…
utsname_sysctl.c	…
vhost_task.c	…
watch_queue.c	watch_queue: fix kcalloc() arguments order	2023-12-21 13:17:54 +01:00
watchdog.c	watchdog: if panicking and we dumped everything, don't re-enable dumping	2023-12-29 12:22:30 -08:00
watchdog_buddy.c	…
watchdog_perf.c	…
workqueue.c	workqueue: Fix selection of wake_cpu in kick_pool()	2024-05-17 12:15:02 +02:00
workqueue_internal.h	…