6e9b01909a
__napi_alloc_skb() is napi_alloc_skb() with the added flexibility of choosing gfp_mask. This is a NAPI function, so GFP_ATOMIC is implied. The only practical choice the caller has is whether to set __GFP_NOWARN. But that's a false choice, too, allocation failures in atomic context will happen, and printing warnings in logs, effectively for a packet drop, is both too much and very likely non-actionable. This leads me to a conclusion that most uses of napi_alloc_skb() are simply misguided, and should use __GFP_NOWARN in the first place. We also have a "standard" way of reporting allocation failures via the queue stat API (qstats::rx-alloc-fail). The direct motivation for this patch is that one of the drivers used at Meta calls napi_alloc_skb() (so prior to this patch without __GFP_NOWARN), and the resulting OOM warning is the top networking warning in our fleet. Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com> Reviewed-by: Simon Horman <horms@kernel.org> Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://lore.kernel.org/r/20240327040213.3153864-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
||
|---|---|---|
| .. | ||
| damon | ||
| active_mm.rst | ||
| balance.rst | ||
| free_page_reporting.rst | ||
| highmem.rst | ||
| hmm.rst | ||
| hugetlbfs_reserv.rst | ||
| hwpoison.rst | ||
| index.rst | ||
| ksm.rst | ||
| memory-model.rst | ||
| mmu_notifier.rst | ||
| numa.rst | ||
| overcommit-accounting.rst | ||
| page_frags.rst | ||
| page_migration.rst | ||
| page_owner.rst | ||
| page_table_check.rst | ||
| remap_file_pages.rst | ||
| split_page_table_lock.rst | ||
| vmalloced-kernel-stacks.rst | ||
| z3fold.rst | ||
| zsmalloc.rst | ||