Christoph Hellwig 906b4dcc18 md: fix a lock order reversal in md_alloc ... [ Upstream commit 7df835a32a ] Commit b0140891a8 ("md: Fix race when creating a new md device.") not only moved assigning mddev->gendisk before calling add_disk, which fixes the races described in the commit log, but also added a mddev->open_mutex critical section over add_disk and creation of the md kobj. Adding a kobject after add_disk is racy vs deleting the gendisk right after adding it, but md already prevents against that by holding a mddev->active reference. On the other hand taking this lock added a lock order reversal with what is not disk->open_mutex (used to be bdev->bd_mutex when the commit was added) for partition devices, which need that lock for the internal open for the partition scan, and a recent commit also takes it for non-partitioned devices, leading to further lockdep splatter. Fixes: b0140891a8 ("md: Fix race when creating a new md device.") Fixes: d626338735 ("block: support delayed holder registration") Reported-by: syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com Signed-off-by: Christoph Hellwig <hch@lst.de> Tested-by: syzbot+fadc0aaf497e6a493b9f@syzkaller.appspotmail.com Reviewed-by: NeilBrown <neilb@suse.de> Signed-off-by: Song Liu <songliubraving@fb.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-10-06 15:31:15 +02:00
..
bcache	bcache: add proper error unwinding in bcache_device_init	2021-09-22 11:47:49 +02:00
persistent-data	dm thin metadata: Fix use-after-free in dm_bm_set_read_only	2021-09-22 11:48:10 +02:00
dm-bio-prison-v1.c
dm-bio-prison-v1.h
dm-bio-prison-v2.c
dm-bio-prison-v2.h
dm-bio-record.h	dm bio record: save/restore bi_end_io and bi_integrity	2020-03-25 08:06:07 +01:00
dm-bufio.c	dm bufio: subtract the number of initial sectors in dm_bufio_get_device_size	2021-03-11 14:04:59 +01:00
dm-builtin.c
dm-cache-background-tracker.c
dm-cache-background-tracker.h
dm-cache-block-types.h
dm-cache-metadata.c	dm cache metadata: Avoid returning cmd->bm wild pointer on error	2020-09-09 19:04:31 +02:00
dm-cache-metadata.h
dm-cache-policy-internal.h
dm-cache-policy-smq.c	treewide: Use array_size() in vzalloc()	2018-06-12 16:19:22 -07:00
dm-cache-policy.c
dm-cache-policy.h
dm-cache-target.c	dm cache: fix a crash due to incorrect work item cancelling	2020-03-11 14:15:05 +01:00
dm-core.h	dm: fix deadlock when swapping to encrypted device	2021-03-04 09:39:57 +01:00
dm-crypt.c	dm crypt: Avoid percpu_counter spinlock contention in crypt_page_alloc()	2021-09-22 11:47:59 +02:00
dm-delay.c	dm delay: fix a crash when invalid device is specified	2019-05-25 18:23:39 +02:00
dm-era-target.c	dm era: Update in-core bitset after committing the metadata	2021-03-04 09:39:59 +01:00
dm-exception-store.c
dm-exception-store.h
dm-flakey.c	dm flakey: Properly corrupt multi-page bios.	2019-12-05 09:20:36 +01:00
dm-integrity.c	dm integrity: conditionally disable "recalculate" feature	2021-01-30 13:32:13 +01:00
dm-io.c
dm-ioctl.c	dm ioctl: fix out of bounds array access when no devices	2021-03-30 14:36:59 +02:00
dm-kcopyd.c	dm kcopyd: always complete failed jobs	2019-08-29 08:28:55 +02:00
dm-linear.c	dm: Check for device sector overflow if CONFIG_LBDAF is not set	2019-01-26 09:32:42 +01:00
dm-log-userspace-base.c
dm-log-userspace-transfer.c
dm-log-userspace-transfer.h
dm-log-writes.c	dm log writes: make sure super sector log updates are written in order	2019-07-03 13:14:45 +02:00
dm-log.c
dm-mpath.c	dm mpath: switch paths in dm_blk_ioctl() code path	2020-06-25 15:32:49 +02:00
dm-mpath.h
dm-path-selector.c
dm-path-selector.h
dm-queue-length.c
dm-raid.c	dm raid: fix inconclusive reshape layout on fast raid4/5/6 table reload sequences	2021-05-22 10:59:21 +02:00
dm-raid1.c	dm: Check for device sector overflow if CONFIG_LBDAF is not set	2019-01-26 09:32:42 +01:00
dm-region-hash.c	- Error path bug fix for overflow tests (Dan)	2018-06-12 18:28:00 -07:00
dm-round-robin.c
dm-rq.c	dm rq: fix double free of blk_mq_tag_set in dev remove after table load fails	2021-05-22 10:59:23 +02:00
dm-rq.h
dm-service-time.c
dm-snap-persistent.c	block: fix an integer overflow in logical block size	2020-01-23 08:21:29 +01:00
dm-snap-transient.c
dm-snap.c	dm snapshot: properly fix a crash when an origin has no snapshots	2021-06-03 08:38:04 +02:00
dm-stats.c	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
dm-stats.h
dm-stripe.c
dm-switch.c	treewide: Use array_size() in vmalloc()	2018-06-12 16:19:22 -07:00
dm-sysfs.c
dm-table.c	dm table: fix zoned iterate_devices based device capability checks	2021-03-11 14:05:01 +01:00
dm-target.c	dm mpath: fix missing call of path selector type->end_io	2019-09-16 08:22:12 +02:00
dm-thin-metadata.c	dm thin metadata: Fix use-after-free in dm_bm_set_read_only	2021-09-22 11:48:10 +02:00
dm-thin-metadata.h	dm thin: fix passdown_double_checking_shared_status()	2019-01-31 08:14:38 +01:00
dm-thin.c	dm thin: add sanity checks to thin-pool and external snapshot creation	2019-04-05 22:32:59 +02:00
dm-uevent.c
dm-uevent.h
dm-unstripe.c	dm: Check for device sector overflow if CONFIG_LBDAF is not set	2019-01-26 09:32:42 +01:00
dm-verity-fec.c	dm verity fec: fix misaligned RS roots IO	2021-04-28 13:16:50 +02:00
dm-verity-fec.h	dm verity fec: fix misaligned RS roots IO	2021-04-28 13:16:50 +02:00
dm-verity-target.c	dm verity: add root hash pkcs#7 signature verification	2021-03-30 14:37:02 +02:00
dm-verity.h
dm-writecache.c	dm writecache: fix writing beyond end of underlying device when shrinking	2021-07-28 11:13:44 +02:00
dm-zero.c
dm-zoned-metadata.c	dm zoned: return NULL if dmz_get_zone_for_reclaim() fails to find a zone	2020-06-25 15:32:58 +02:00
dm-zoned-reclaim.c	dm zoned: return NULL if dmz_get_zone_for_reclaim() fails to find a zone	2020-06-25 15:32:58 +02:00
dm-zoned-target.c	dm zoned: assign max_io_len correctly	2020-07-09 09:37:12 +02:00
dm-zoned.h	dm zoned: reduce overhead of backing device checks	2019-12-17 20:34:53 +01:00
dm.c	dm: fix deadlock when swapping to encrypted device	2021-03-04 09:39:57 +01:00
dm.h
Kconfig
Makefile
md-bitmap.c	md/bitmap: wait for external bitmap writes to complete during tear down	2021-05-22 10:59:24 +02:00
md-bitmap.h	md: Avoid namespace collision with bitmap API	2018-08-01 15:49:39 -07:00
md-cluster.c	md/cluster: fix deadlock when node is doing resync job	2020-12-30 11:26:16 +01:00
md-cluster.h
md-faulty.c
md-linear.c	md: improve handling of bio with REQ_PREFLUSH in md_flush_request()	2019-12-17 20:34:55 +01:00
md-linear.h
md-multipath.c	md: improve handling of bio with REQ_PREFLUSH in md_flush_request()	2019-12-17 20:34:55 +01:00
md-multipath.h
md.c	md: fix a lock order reversal in md_alloc	2021-10-06 15:31:15 +02:00
md.h	md: improve handling of bio with REQ_PREFLUSH in md_flush_request()	2019-12-17 20:34:55 +01:00
raid0.c	md: add feature flag MD_FEATURE_RAID0_LAYOUT	2020-06-25 15:33:10 +02:00
raid0.h	md/raid0: avoid RAID0 data corruption due to layout confusion.	2019-10-05 13:10:12 +02:00
raid1-10.c
raid1.c	md/raid1: properly indicate failure when ending a failed write request	2021-05-22 10:59:20 +02:00
raid1.h
raid5-cache.c	md/raid5: fix 'out of memory' during raid cache recovery	2019-02-06 17:30:16 +01:00
raid5-log.h	md/raid5-cache: disable reshape completely	2018-08-31 17:38:09 -07:00
raid5-ppl.c
raid5.c	md/raid5: fix oops during stripe resizing	2020-11-05 11:08:45 +01:00
raid5.h	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md	2018-06-09 12:01:36 -07:00
raid10.c	md/raid10: initialize r10_bio->read_slot before use.	2021-01-06 14:44:58 +01:00
raid10.h