mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 22:26:55 +00:00
7d802c8098
After commit 9ed7bfc795 ("sctp: fix memory leak in
sctp_stream_outq_migrate()"), sctp_sched_set_sched() is the only
place calling sched->free(), and it can actually be replaced by
sched->free_sid() on each stream, and yet there's already a loop
to traverse all streams in sctp_sched_set_sched().
This patch adds a function sctp_sched_free_sched() where it calls
sched->free_sid() for each stream to replace sched->free() calls
in sctp_sched_set_sched() and then deletes the unused free member
from struct sctp_sched_ops.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Link: https://lore.kernel.org/r/e10aac150aca2686cb0bd0570299ec716da5a5c0.1669849471.git.lucien.xin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
62 lines
2.3 KiB
C
62 lines
2.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/* SCTP kernel implementation
|
|
* (C) Copyright Red Hat Inc. 2017
|
|
*
|
|
* These are definitions used by the stream schedulers, defined in RFC
|
|
* draft ndata (https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-11)
|
|
*
|
|
* Please send any bug reports or fixes you make to the
|
|
* email addresses:
|
|
* lksctp developers <linux-sctp@vger.kernel.org>
|
|
*
|
|
* Written or modified by:
|
|
* Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
|
|
*/
|
|
|
|
#ifndef __sctp_stream_sched_h__
|
|
#define __sctp_stream_sched_h__
|
|
|
|
struct sctp_sched_ops {
|
|
/* Property handling for a given stream */
|
|
int (*set)(struct sctp_stream *stream, __u16 sid, __u16 value,
|
|
gfp_t gfp);
|
|
int (*get)(struct sctp_stream *stream, __u16 sid, __u16 *value);
|
|
|
|
/* Init the specific scheduler */
|
|
int (*init)(struct sctp_stream *stream);
|
|
/* Init a stream */
|
|
int (*init_sid)(struct sctp_stream *stream, __u16 sid, gfp_t gfp);
|
|
/* free a stream */
|
|
void (*free_sid)(struct sctp_stream *stream, __u16 sid);
|
|
|
|
/* Enqueue a chunk */
|
|
void (*enqueue)(struct sctp_outq *q, struct sctp_datamsg *msg);
|
|
/* Dequeue a chunk */
|
|
struct sctp_chunk *(*dequeue)(struct sctp_outq *q);
|
|
/* Called only if the chunk fit the packet */
|
|
void (*dequeue_done)(struct sctp_outq *q, struct sctp_chunk *chunk);
|
|
/* Sched all chunks already enqueued */
|
|
void (*sched_all)(struct sctp_stream *steam);
|
|
/* Unched all chunks already enqueued */
|
|
void (*unsched_all)(struct sctp_stream *steam);
|
|
};
|
|
|
|
int sctp_sched_set_sched(struct sctp_association *asoc,
|
|
enum sctp_sched_type sched);
|
|
int sctp_sched_get_sched(struct sctp_association *asoc);
|
|
int sctp_sched_set_value(struct sctp_association *asoc, __u16 sid,
|
|
__u16 value, gfp_t gfp);
|
|
int sctp_sched_get_value(struct sctp_association *asoc, __u16 sid,
|
|
__u16 *value);
|
|
void sctp_sched_dequeue_done(struct sctp_outq *q, struct sctp_chunk *ch);
|
|
|
|
void sctp_sched_dequeue_common(struct sctp_outq *q, struct sctp_chunk *ch);
|
|
int sctp_sched_init_sid(struct sctp_stream *stream, __u16 sid, gfp_t gfp);
|
|
struct sctp_sched_ops *sctp_sched_ops_from_stream(struct sctp_stream *stream);
|
|
|
|
void sctp_sched_ops_register(enum sctp_sched_type sched,
|
|
struct sctp_sched_ops *sched_ops);
|
|
void sctp_sched_ops_prio_init(void);
|
|
void sctp_sched_ops_rr_init(void);
|
|
|
|
#endif /* __sctp_stream_sched_h__ */
|