Javier Martinez Canillas 02109faee1 fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove ... [ Upstream commit d258d00fb9 ] The driver is calling framebuffer_release() in its .remove callback, but this will cause the struct fb_info to be freed too early. Since it could be that a reference is still hold to it if user-space opened the fbdev. This would lead to a use-after-free error if the framebuffer device was unregistered but later a user-space process tries to close the fbdev fd. To prevent this, move the framebuffer_release() call to fb_ops.fb_destroy instead of doing it in the driver's .remove callback. Strictly speaking, the code flow in the driver is still wrong because all the hardware cleanupd (i.e: iounmap) should be done in .remove while the software cleanup (i.e: releasing the framebuffer) should be done in the .fb_destroy handler. But this at least makes to match the behavior before commit 27599aacba ("fbdev: Hot-unplug firmware fb devices on forced removal"). Fixes: 27599aacba ("fbdev: Hot-unplug firmware fb devices on forced removal") Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20220505220540.366218-1-javierm@redhat.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-05-18 10:28:12 +02:00
..
backlight	backlight: qcom-wled: Respect enabled-strings in set_brightness	2021-12-22 11:18:46 +00:00
console	fbcon: Add option to enable legacy hardware acceleration	2022-02-02 15:16:26 +01:00
fbdev	fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove	2022-05-18 10:28:12 +02:00
logo
display_timing.c
hdmi.c	video: fix some kernel-doc markups	2020-11-16 18:23:16 +01:00
Kconfig
Makefile
of_display_timing.c	video: Fix kernel-doc warnings in of_display_timing + of_videomode	2020-11-29 22:42:17 +01:00
of_videomode.c	video: Fix kernel-doc warnings in of_display_timing + of_videomode	2020-11-29 22:42:17 +01:00
vgastate.c
videomode.c