Namhyung Kim c418d7a675 perf lock contention: Add a missing NULL check ... [ Upstream commit f3408580ba ] I got a report for a failure in BPF verifier on a recent kernel with perf lock contention command. It checks task->sighand->siglock without checking if sighand is NULL or not. Let's add one. ; if (&curr->sighand->siglock == (void *)lock) 265: (79) r1 = *(u64 *)(r0 +2624) ; frame1: R0_w=trusted_ptr_task_struct(off=0,imm=0) ; R1_w=rcu_ptr_or_null_sighand_struct(off=0,imm=0) 266: (b7) r2 = 0 ; frame1: R2_w=0 267: (0f) r1 += r2 R1 pointer arithmetic on rcu_ptr_or_null_ prohibited, null-check it first processed 164 insns (limit 1000000) max_states_per_insn 1 total_states 15 peak_states 15 mark_read 5 -- END PROG LOAD LOG -- libbpf: prog 'contention_end': failed to load: -13 libbpf: failed to load object 'lock_contention_bpf' libbpf: failed to load BPF skeleton 'lock_contention_bpf': -13 Failed to load lock-contention BPF skeleton lock contention BPF setup failed lock contention did not detect any lock contention Fixes: 1811e82767 ("perf lock contention: Track and show siglock with address") Reviewed-by: Ian Rogers <irogers@google.com> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Song Liu <song@kernel.org> Cc: bpf@vger.kernel.org Signed-off-by: Namhyung Kim <namhyung@kernel.org> Link: https://lore.kernel.org/r/20240409225542.1870999-1-namhyung@kernel.org Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-04-27 17:11:34 +02:00
..
accounting
arch	x86/CPU/AMD: Add X86_FEATURE_ZEN1	2024-04-10 16:35:47 +02:00
bootconfig
bpf	tools/resolve_btfids: Fix cross-compilation to non-host endianness	2024-03-26 18:19:27 -04:00
build	perf cs-etm: Bump minimum OpenCSD version to ensure a bugfix is present	2024-02-05 20:14:31 +00:00
certs
cgroup	iocost_monitor: improve it by adding iocg wait_ms	2023-08-08 15:43:03 -06:00
counter
crypto/ccp	crypto: ccp - Fix some unfused tests	2023-11-20 11:59:18 +01:00
debugging
edid
firewire
firmware
gpio
hv	hv/hv_kvp_daemon: Some small fixes for handling NM keyfiles	2023-12-03 07:33:02 +01:00
iio	tools: iio: replace seekdir() in iio_generic_buffer	2024-04-13 13:07:38 +02:00
include	tools/resolve_btfids: fix build with musl libc	2024-04-03 15:29:03 +02:00
kvm/kvm_stat
laptop
leds
lib	libperf evlist: Avoid out-of-bounds access	2024-04-13 13:07:36 +02:00
memory-model
mm	tools/mm: fix undefined reference to pthread_once	2023-09-05 10:13:45 -07:00
net/ynl	tools: ynl: fix setting presence bits in simple nests	2024-04-10 16:35:41 +02:00
objtool	objtool: Fix UNWIND_HINT_{SAVE,RESTORE} across basic blocks	2024-03-26 18:19:35 -04:00
pci
pcmcia
perf	perf lock contention: Add a missing NULL check	2024-04-27 17:11:34 +02:00
power	tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num()	2024-04-13 13:07:31 +02:00
rcu
scripts	tools build: Add 3-component logical version comparators	2023-08-03 16:59:40 -03:00
spi
testing	net: change maximum number of UDP segments to 128	2024-04-27 17:11:32 +02:00
thermal
time
tracing	tools/rtla: Fix Makefile compiler options for clang	2024-02-23 09:25:15 +01:00
usb
verification	tools/rv: Fix Makefile compiler options for clang	2024-02-23 09:25:14 +01:00
virtio	tools/virtio: Add dma sync api for virtio test	2023-10-16 05:32:23 -04:00
wmi
workqueue	workqueue: Implement non-strict affinity scope for unbound workqueues	2023-08-07 15:57:25 -10:00
Makefile