Alban Crequy 02f8211b75 bpf, lpm: fix lookup bug in map_delete_elem ... [ Upstream commit 7c0cdf0b39 ] trie_delete_elem() was deleting an entry even though it was not matching if the prefixlen was correct. This patch adds a check on matchlen. Reproducer: $ sudo bpftool map create /sys/fs/bpf/mylpm type lpm_trie key 8 value 1 entries 128 name mylpm flags 1 $ sudo bpftool map update pinned /sys/fs/bpf/mylpm key hex 10 00 00 00 aa bb cc dd value hex 01 $ sudo bpftool map dump pinned /sys/fs/bpf/mylpm key: 10 00 00 00 aa bb cc dd value: 01 Found 1 element $ sudo bpftool map delete pinned /sys/fs/bpf/mylpm key hex 10 00 00 00 ff ff ff ff $ echo $? 0 $ sudo bpftool map dump pinned /sys/fs/bpf/mylpm Found 0 elements A similar reproducer is added in the selftests. Without the patch: $ sudo ./tools/testing/selftests/bpf/test_lpm_map test_lpm_map: test_lpm_map.c:485: test_lpm_delete: Assertion `bpf_map_delete_elem(map_fd, key) == -1 && errno == ENOENT' failed. Aborted With the patch: test_lpm_map runs without errors. Fixes: e454cf5958 ("bpf: Implement map_delete_elem for BPF_MAP_TYPE_LPM_TRIE") Cc: Craig Gallek <kraig@google.com> Signed-off-by: Alban Crequy <alban@kinvolk.io> Acked-by: Craig Gallek <kraig@google.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-03-23 20:09:51 +01:00
..
accounting
arch	tools uapi: fix RISC-V 64-bit support	2019-02-20 10:25:39 +01:00
bpf	bpftool: fix percpu maps updating	2019-03-13 14:02:34 -07:00
build	perf build: Don't unconditionally link the libbfd feature test to -liberty and -lz	2019-02-12 19:47:16 +01:00
cgroup
firewire
gpio
hv	Tools: hv: kvp: Fix a warning of buffer overflow with gcc 8.0.1	2019-02-12 19:46:59 +01:00
iio	tools: iio: iio_generic_buffer: make num_loops signed	2019-02-15 08:10:10 +01:00
include	tools uapi: fix Alpha support	2019-02-20 10:25:45 +01:00
kvm/kvm_stat	tools/kvm_stat: cut down decimal places in update interval dialog	2018-10-01 15:40:59 +02:00
laptop
leds
lib	bpf: libbpf: retry map creation without the name	2019-02-12 19:47:00 +01:00
memory-model	tools/memory-model: Rename litmus tests to comply to norm7	2018-07-17 09:30:36 +02:00
nfsd
objtool	objtool: Fix segfault in .cold detection with -ffunction-sections	2018-12-17 09:24:33 +01:00
pci	tools: PCI: Add MSI-X support	2018-07-19 11:47:13 +01:00
pcmcia
perf	perf trace: Support multiple "vfs_getname" probes	2019-03-13 14:02:37 -07:00
power	tools/power/x86/intel_pstate_tracer: Fix non root execution for post processing a trace file	2019-02-12 19:47:12 +01:00
scripts
spi
testing	bpf, lpm: fix lookup bug in map_delete_elem	2019-03-23 20:09:51 +01:00
thermal/tmon
time
usb	tools: usb: ffs-test: Fix build on big endian systems	2018-07-17 10:12:51 +03:00
virtio	virtio: fix test build after uio.h change	2019-01-13 09:51:03 +01:00
vm	tools/vm/page-types.c: fix "defined but not used" warning	2018-09-04 16:45:02 -07:00
wmi
Makefile