mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 08:19:28 +00:00
![Bjorn Helgaas](/assets/img/avatar_default.png)
Remove the assumption that driver_register() returns the number of devices bound to the driver. In fact, it returns zero for success or a negative error value. zorro_module_init() used the device count to automatically unregister and unload drivers that found no devices. That might have worked at one time, but has been broken for some time because zorro_register_driver() returned either a negative error or a positive count (never zero). So it could only unregister on failure, when it's not needed anyway. This functionality could be resurrected in individual drivers by counting devices in their .probe() methods. Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Roman Zippel <zippel@linux-m68k.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
145 lines
3.6 KiB
C
145 lines
3.6 KiB
C
/*
|
|
* Zorro Driver Services
|
|
*
|
|
* Copyright (C) 2003 Geert Uytterhoeven
|
|
*
|
|
* Loosely based on drivers/pci/pci-driver.c
|
|
*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License. See the file COPYING in the main directory of this archive
|
|
* for more details.
|
|
*/
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/module.h>
|
|
#include <linux/zorro.h>
|
|
|
|
|
|
/**
|
|
* zorro_match_device - Tell if a Zorro device structure has a matching
|
|
* Zorro device id structure
|
|
* @ids: array of Zorro device id structures to search in
|
|
* @dev: the Zorro device structure to match against
|
|
*
|
|
* Used by a driver to check whether a Zorro device present in the
|
|
* system is in its list of supported devices. Returns the matching
|
|
* zorro_device_id structure or %NULL if there is no match.
|
|
*/
|
|
|
|
const struct zorro_device_id *
|
|
zorro_match_device(const struct zorro_device_id *ids,
|
|
const struct zorro_dev *z)
|
|
{
|
|
while (ids->id) {
|
|
if (ids->id == ZORRO_WILDCARD || ids->id == z->id)
|
|
return ids;
|
|
ids++;
|
|
}
|
|
return NULL;
|
|
}
|
|
|
|
|
|
static int zorro_device_probe(struct device *dev)
|
|
{
|
|
int error = 0;
|
|
struct zorro_driver *drv = to_zorro_driver(dev->driver);
|
|
struct zorro_dev *z = to_zorro_dev(dev);
|
|
|
|
if (!z->driver && drv->probe) {
|
|
const struct zorro_device_id *id;
|
|
|
|
id = zorro_match_device(drv->id_table, z);
|
|
if (id)
|
|
error = drv->probe(z, id);
|
|
if (error >= 0) {
|
|
z->driver = drv;
|
|
error = 0;
|
|
}
|
|
}
|
|
return error;
|
|
}
|
|
|
|
|
|
/**
|
|
* zorro_register_driver - register a new Zorro driver
|
|
* @drv: the driver structure to register
|
|
*
|
|
* Adds the driver structure to the list of registered drivers
|
|
* Returns zero or a negative error value.
|
|
*/
|
|
|
|
int zorro_register_driver(struct zorro_driver *drv)
|
|
{
|
|
/* initialize common driver fields */
|
|
drv->driver.name = drv->name;
|
|
drv->driver.bus = &zorro_bus_type;
|
|
|
|
/* register with core */
|
|
return driver_register(&drv->driver);
|
|
}
|
|
|
|
|
|
/**
|
|
* zorro_unregister_driver - unregister a zorro driver
|
|
* @drv: the driver structure to unregister
|
|
*
|
|
* Deletes the driver structure from the list of registered Zorro drivers,
|
|
* gives it a chance to clean up by calling its remove() function for
|
|
* each device it was responsible for, and marks those devices as
|
|
* driverless.
|
|
*/
|
|
|
|
void zorro_unregister_driver(struct zorro_driver *drv)
|
|
{
|
|
driver_unregister(&drv->driver);
|
|
}
|
|
|
|
|
|
/**
|
|
* zorro_bus_match - Tell if a Zorro device structure has a matching Zorro
|
|
* device id structure
|
|
* @ids: array of Zorro device id structures to search in
|
|
* @dev: the Zorro device structure to match against
|
|
*
|
|
* Used by a driver to check whether a Zorro device present in the
|
|
* system is in its list of supported devices.Returns the matching
|
|
* zorro_device_id structure or %NULL if there is no match.
|
|
*/
|
|
|
|
static int zorro_bus_match(struct device *dev, struct device_driver *drv)
|
|
{
|
|
struct zorro_dev *z = to_zorro_dev(dev);
|
|
struct zorro_driver *zorro_drv = to_zorro_driver(drv);
|
|
const struct zorro_device_id *ids = zorro_drv->id_table;
|
|
|
|
if (!ids)
|
|
return 0;
|
|
|
|
while (ids->id) {
|
|
if (ids->id == ZORRO_WILDCARD || ids->id == z->id)
|
|
return 1;
|
|
ids++;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
|
|
struct bus_type zorro_bus_type = {
|
|
.name = "zorro",
|
|
.match = zorro_bus_match,
|
|
.probe = zorro_device_probe,
|
|
};
|
|
|
|
|
|
static int __init zorro_driver_init(void)
|
|
{
|
|
return bus_register(&zorro_bus_type);
|
|
}
|
|
|
|
postcore_initcall(zorro_driver_init);
|
|
|
|
EXPORT_SYMBOL(zorro_match_device);
|
|
EXPORT_SYMBOL(zorro_register_driver);
|
|
EXPORT_SYMBOL(zorro_unregister_driver);
|
|
EXPORT_SYMBOL(zorro_dev_driver);
|
|
EXPORT_SYMBOL(zorro_bus_type);
|