linux-stable/drivers/target/iscsi
Nicholas Bellinger 03e98c9eb9 target: Address legacy PYX_TRANSPORT_* return code breakage
This patch removes legacy usage of PYX_TRANSPORT_* return codes in a number
of locations and addresses cases where transport_generic_request_failure()
was returning the incorrect sense upon CHECK_CONDITION status after the
v3.1 converson to use errno return codes.

This includes the conversion of transport_generic_request_failure() to
process cmd->scsi_sense_reason and handle extra TCM_RESERVATION_CONFLICT
before calling transport_send_check_condition_and_sense() to queue up
response status.  It also drops PYX_TRANSPORT_OUT_OF_MEMORY_RESOURCES legacy
usgae, and returns TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE w/ a response
for these cases.

transport_generic_allocate_tasks(), transport_generic_new_cmd(), backend
SCF_SCSI_DATA_SG_IO_CDB ->do_task(), and emulated ->execute_task() have
all been updated to set se_cmd->scsi_sense_reason and return errno codes
universally upon failure.  This includes cmd->scsi_sense_reason assignment
in target_core_alua.c, target_core_pr.c and target_core_cdb.c emulation code.

Finally it updates fabric modules to remove the legacy usage, and for
TFO->new_cmd_map() callers forwards return values outside of fabric code.
iscsi-target has also been updated to remove a handful of special cases
related to the cleanup and signaling QUEUE_FULL handling w/ ft_write_pending()

(v2: Drop extra SCF_SCSI_CDB_EXCEPTION check during failure from
     transport_generic_new_cmd, and re-add missing task->task_error_status
     assignment in transport_complete_task)

Cc: Christoph Hellwig <hch@lst.de>
Cc: stable@kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
2011-12-06 06:00:49 +00:00
..
iscsi_target.c target: Address legacy PYX_TRANSPORT_* return code breakage 2011-12-06 06:00:49 +00:00
iscsi_target.h
iscsi_target_auth.c iscsi-target: use native hex2bin for chap_string_to_hex 2011-10-24 03:20:48 +00:00
iscsi_target_auth.h
iscsi_target_configfs.c drivers/target: Add export.h to files as required. 2011-10-31 19:31:58 -04:00
iscsi_target_configfs.h
iscsi_target_core.h target: Fix incorrect transport_sent usage 2011-10-24 03:22:06 +00:00
iscsi_target_datain_values.c
iscsi_target_datain_values.h
iscsi_target_device.c
iscsi_target_device.h
iscsi_target_erl0.c
iscsi_target_erl0.h
iscsi_target_erl1.c target: Address legacy PYX_TRANSPORT_* return code breakage 2011-12-06 06:00:49 +00:00
iscsi_target_erl1.h
iscsi_target_erl2.c iscsi-target: Remove SCF_SE_LUN_CMD flag abuses 2011-10-24 03:20:56 +00:00
iscsi_target_erl2.h
iscsi_target_login.c iscsi-target: Implement iSCSI target IPv6 address printing. 2011-08-22 19:26:29 +00:00
iscsi_target_login.h
iscsi_target_nego.c treewide: Correct spelling of successfully in comments 2011-09-27 18:08:04 +02:00
iscsi_target_nego.h
iscsi_target_nodeattrib.c
iscsi_target_nodeattrib.h
iscsi_target_parameters.c iscsi-target: Disable markers + remove dangerous local scope array usage 2011-09-16 19:37:18 +00:00
iscsi_target_parameters.h
iscsi_target_seq_pdu_list.c
iscsi_target_seq_pdu_list.h
iscsi_target_stat.c drivers/target: Add export.h to files as required. 2011-10-31 19:31:58 -04:00
iscsi_target_stat.h
iscsi_target_tmr.c target: Fix incorrect transport_sent usage 2011-10-24 03:22:06 +00:00
iscsi_target_tmr.h
iscsi_target_tpg.c
iscsi_target_tpg.h
iscsi_target_tq.c
iscsi_target_tq.h
iscsi_target_util.c iscsi-target: Remove SCF_SE_LUN_CMD flag abuses 2011-10-24 03:20:56 +00:00
iscsi_target_util.h iscsi-target: Remove SCF_SE_LUN_CMD flag abuses 2011-10-24 03:20:56 +00:00
Kconfig target: iscsi_target depends on NET 2011-07-28 20:16:18 +00:00
Makefile