mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 00:10:09 +00:00
fdcfd85433
rtc_register_device() is a managed interface but it doesn't use devres by itself - instead it marks an rtc_device as "registered" and the devres callback for devm_rtc_allocate_device() takes care of resource release. This doesn't correspond with the design behind devres where managed structures should not be aware of being managed. The correct solution here is to register a separate devres callback for unregistering the device. While at it: rename rtc_register_device() to devm_rtc_register_device() and add it to the list of managed interfaces in devres.rst. This way we can avoid any potential confusion of driver developers who may expect there to exist a corresponding unregister function. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl
73 lines
1.4 KiB
C
73 lines
1.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* PS3 RTC Driver
|
|
*
|
|
* Copyright 2009 Sony Corporation
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/rtc.h>
|
|
|
|
#include <asm/lv1call.h>
|
|
#include <asm/ps3.h>
|
|
|
|
|
|
static u64 read_rtc(void)
|
|
{
|
|
int result;
|
|
u64 rtc_val;
|
|
u64 tb_val;
|
|
|
|
result = lv1_get_rtc(&rtc_val, &tb_val);
|
|
BUG_ON(result);
|
|
|
|
return rtc_val;
|
|
}
|
|
|
|
static int ps3_get_time(struct device *dev, struct rtc_time *tm)
|
|
{
|
|
rtc_time64_to_tm(read_rtc() + ps3_os_area_get_rtc_diff(), tm);
|
|
return 0;
|
|
}
|
|
|
|
static int ps3_set_time(struct device *dev, struct rtc_time *tm)
|
|
{
|
|
ps3_os_area_set_rtc_diff(rtc_tm_to_time64(tm) - read_rtc());
|
|
return 0;
|
|
}
|
|
|
|
static const struct rtc_class_ops ps3_rtc_ops = {
|
|
.read_time = ps3_get_time,
|
|
.set_time = ps3_set_time,
|
|
};
|
|
|
|
static int __init ps3_rtc_probe(struct platform_device *dev)
|
|
{
|
|
struct rtc_device *rtc;
|
|
|
|
rtc = devm_rtc_allocate_device(&dev->dev);
|
|
if (IS_ERR(rtc))
|
|
return PTR_ERR(rtc);
|
|
|
|
rtc->ops = &ps3_rtc_ops;
|
|
rtc->range_max = U64_MAX;
|
|
|
|
platform_set_drvdata(dev, rtc);
|
|
|
|
return devm_rtc_register_device(rtc);
|
|
}
|
|
|
|
static struct platform_driver ps3_rtc_driver = {
|
|
.driver = {
|
|
.name = "rtc-ps3",
|
|
},
|
|
};
|
|
|
|
module_platform_driver_probe(ps3_rtc_driver, ps3_rtc_probe);
|
|
|
|
MODULE_AUTHOR("Sony Corporation");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("ps3 RTC driver");
|
|
MODULE_ALIAS("platform:rtc-ps3");
|