linux-stable/sound/isa
Xiaomeng Tong fc3aeb55b6 ALSA: cs4236: fix an incorrect NULL check on list iterator
commit 0112f822f8 upstream.

The bug is here:
	err = snd_card_cs423x_pnp(dev, card->private_data, pdev, cdev);

The list iterator value 'cdev' will *always* be set and non-NULL
by list_for_each_entry(), so it is incorrect to assume that the
iterator value will be NULL if the list is empty or no element
is found.

To fix the bug, use a new variable 'iter' as the list iterator,
while use the original variable 'cdev' as a dedicated pointer
to point to the found element. And snd_card_cs423x_pnp() itself
has NULL check for cdev.

Cc: stable@vger.kernel.org
Fixes: c2b73d1458 ("ALSA: cs4236: cs4232 and cs4236 driver merge to solve PnP BIOS detection")
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Link: https://lore.kernel.org/r/20220327060822.4735-1-xiam0nd.tong@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-04-08 13:57:21 +02:00
..
ad1816a ALSA: ad1816a: Allocate resources with device-managed APIs 2021-07-19 16:17:12 +02:00
ad1848 ALSA: ad1848: Allocate resources with device-managed APIs 2021-07-19 16:17:15 +02:00
cs423x ALSA: cs4236: fix an incorrect NULL check on list iterator 2022-04-08 13:57:21 +02:00
es1688 ALSA: es1688: Avoid devres management for es1688 object creation 2021-08-05 08:24:17 +02:00
galaxy ALSA: galaxy: Allocate resources with device-managed APIs 2021-07-19 16:17:21 +02:00
gus ALSA: gus: Fix memory leaks at memory allocator error paths 2021-12-13 16:41:12 +01:00
msnd ALSA: msnd: Use proper mmap method 2021-08-09 16:06:17 +02:00
opti9xx ALSA: opti9xx: fix missing { } around an if block 2021-07-20 17:40:12 +02:00
sb Merge branch 'for-linus' into for-next 2021-08-02 09:04:48 +02:00
wavefront ALSA: wavefront: Allocate resources with device-managed APIs 2021-07-19 16:17:27 +02:00
wss ALSA: wss: Allocate resources with device-managed APIs 2021-07-19 16:17:13 +02:00
adlib.c ALSA: adlib: Allocate resources with device-managed APIs 2021-07-19 16:17:16 +02:00
als100.c ALSA: als100: Allocate resources with device-managed APIs 2021-07-19 16:17:16 +02:00
azt2320.c ALSA: azt2320: Allocate resources with device-managed APIs 2021-07-19 16:17:17 +02:00
cmi8328.c ALSA: cmi8328: Allocate resources with device-managed APIs 2021-07-19 16:17:18 +02:00
cmi8330.c ALSA: cmi8330: Allocate resources with device-managed APIs 2021-07-19 16:17:18 +02:00
es18xx.c ALSA: es18xx: Allocate resources with device-managed APIs 2021-07-19 16:17:21 +02:00
Kconfig ALSA: ISA: not for M68K 2021-10-17 09:03:20 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
opl3sa2.c ALSA: opl3sa2: Allocate resources with device-managed APIs 2021-07-19 16:17:25 +02:00
sc6000.c ALSA: sc6000: Use explicit cast for __iomem pointer 2021-07-21 00:49:46 +02:00
sscape.c ALSA: sscape: Allocate resources with device-managed APIs 2021-07-19 16:17:26 +02:00