mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 03:10:12 +00:00
![Tejun Heo](/assets/img/avatar_default.png)
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
187 lines
4.7 KiB
C
187 lines
4.7 KiB
C
/* -*- mode: c; c-basic-offset: 8 -*- */
|
|
|
|
/* PARISC LASI driver for the 53c700 chip
|
|
*
|
|
* Copyright (C) 2001 by James.Bottomley@HansenPartnership.com
|
|
**-----------------------------------------------------------------------------
|
|
**
|
|
** This program is free software; you can redistribute it and/or modify
|
|
** it under the terms of the GNU General Public License as published by
|
|
** the Free Software Foundation; either version 2 of the License, or
|
|
** (at your option) any later version.
|
|
**
|
|
** This program is distributed in the hope that it will be useful,
|
|
** but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
** GNU General Public License for more details.
|
|
**
|
|
** You should have received a copy of the GNU General Public License
|
|
** along with this program; if not, write to the Free Software
|
|
** Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
**
|
|
**-----------------------------------------------------------------------------
|
|
*/
|
|
|
|
/*
|
|
* Many thanks to Richard Hirst <rhirst@linuxcare.com> for patiently
|
|
* debugging this driver on the parisc architecture and suggesting
|
|
* many improvements and bug fixes.
|
|
*
|
|
* Thanks also go to Linuxcare Inc. for providing several PARISC
|
|
* machines for me to debug the driver on.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/types.h>
|
|
#include <linux/stat.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/blkdev.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/dma-mapping.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include <asm/page.h>
|
|
#include <asm/pgtable.h>
|
|
#include <asm/irq.h>
|
|
#include <asm/hardware.h>
|
|
#include <asm/parisc-device.h>
|
|
#include <asm/delay.h>
|
|
|
|
#include <scsi/scsi_host.h>
|
|
#include <scsi/scsi_device.h>
|
|
#include <scsi/scsi_transport.h>
|
|
#include <scsi/scsi_transport_spi.h>
|
|
|
|
#include "53c700.h"
|
|
|
|
MODULE_AUTHOR("James Bottomley");
|
|
MODULE_DESCRIPTION("lasi700 SCSI Driver");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
#define LASI_700_SVERSION 0x00071
|
|
#define LASI_710_SVERSION 0x00082
|
|
|
|
#define LASI700_ID_TABLE { \
|
|
.hw_type = HPHW_FIO, \
|
|
.sversion = LASI_700_SVERSION, \
|
|
.hversion = HVERSION_ANY_ID, \
|
|
.hversion_rev = HVERSION_REV_ANY_ID, \
|
|
}
|
|
|
|
#define LASI710_ID_TABLE { \
|
|
.hw_type = HPHW_FIO, \
|
|
.sversion = LASI_710_SVERSION, \
|
|
.hversion = HVERSION_ANY_ID, \
|
|
.hversion_rev = HVERSION_REV_ANY_ID, \
|
|
}
|
|
|
|
#define LASI700_CLOCK 25
|
|
#define LASI710_CLOCK 40
|
|
#define LASI_SCSI_CORE_OFFSET 0x100
|
|
|
|
static struct parisc_device_id lasi700_ids[] = {
|
|
LASI700_ID_TABLE,
|
|
LASI710_ID_TABLE,
|
|
{ 0 }
|
|
};
|
|
|
|
static struct scsi_host_template lasi700_template = {
|
|
.name = "LASI SCSI 53c700",
|
|
.proc_name = "lasi700",
|
|
.this_id = 7,
|
|
.module = THIS_MODULE,
|
|
};
|
|
MODULE_DEVICE_TABLE(parisc, lasi700_ids);
|
|
|
|
static int __init
|
|
lasi700_probe(struct parisc_device *dev)
|
|
{
|
|
unsigned long base = dev->hpa.start + LASI_SCSI_CORE_OFFSET;
|
|
struct NCR_700_Host_Parameters *hostdata;
|
|
struct Scsi_Host *host;
|
|
|
|
hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL);
|
|
if (!hostdata) {
|
|
dev_printk(KERN_ERR, &dev->dev, "Failed to allocate host data\n");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
hostdata->dev = &dev->dev;
|
|
dma_set_mask(&dev->dev, DMA_BIT_MASK(32));
|
|
hostdata->base = ioremap_nocache(base, 0x100);
|
|
hostdata->differential = 0;
|
|
|
|
if (dev->id.sversion == LASI_700_SVERSION) {
|
|
hostdata->clock = LASI700_CLOCK;
|
|
hostdata->force_le_on_be = 1;
|
|
} else {
|
|
hostdata->clock = LASI710_CLOCK;
|
|
hostdata->force_le_on_be = 0;
|
|
hostdata->chip710 = 1;
|
|
hostdata->dmode_extra = DMODE_FC2;
|
|
hostdata->burst_length = 8;
|
|
}
|
|
|
|
host = NCR_700_detect(&lasi700_template, hostdata, &dev->dev);
|
|
if (!host)
|
|
goto out_kfree;
|
|
host->this_id = 7;
|
|
host->base = base;
|
|
host->irq = dev->irq;
|
|
if(request_irq(dev->irq, NCR_700_intr, IRQF_SHARED, "lasi700", host)) {
|
|
printk(KERN_ERR "lasi700: request_irq failed!\n");
|
|
goto out_put_host;
|
|
}
|
|
|
|
dev_set_drvdata(&dev->dev, host);
|
|
scsi_scan_host(host);
|
|
|
|
return 0;
|
|
|
|
out_put_host:
|
|
scsi_host_put(host);
|
|
out_kfree:
|
|
iounmap(hostdata->base);
|
|
kfree(hostdata);
|
|
return -ENODEV;
|
|
}
|
|
|
|
static int __exit
|
|
lasi700_driver_remove(struct parisc_device *dev)
|
|
{
|
|
struct Scsi_Host *host = dev_get_drvdata(&dev->dev);
|
|
struct NCR_700_Host_Parameters *hostdata =
|
|
(struct NCR_700_Host_Parameters *)host->hostdata[0];
|
|
|
|
scsi_remove_host(host);
|
|
NCR_700_release(host);
|
|
free_irq(host->irq, host);
|
|
iounmap(hostdata->base);
|
|
kfree(hostdata);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct parisc_driver lasi700_driver = {
|
|
.name = "lasi_scsi",
|
|
.id_table = lasi700_ids,
|
|
.probe = lasi700_probe,
|
|
.remove = __devexit_p(lasi700_driver_remove),
|
|
};
|
|
|
|
static int __init
|
|
lasi700_init(void)
|
|
{
|
|
return register_parisc_driver(&lasi700_driver);
|
|
}
|
|
|
|
static void __exit
|
|
lasi700_exit(void)
|
|
{
|
|
unregister_parisc_driver(&lasi700_driver);
|
|
}
|
|
|
|
module_init(lasi700_init);
|
|
module_exit(lasi700_exit);
|