Florian Westphal e1bf168774 netfilter: nat: Revert "netfilter: nat: convert nat bysrc hash to rhashtable" ... This reverts commit 870190a9ec. It was not a good idea. The custom hash table was a much better fit for this purpose. A fast lookup is not essential, in fact for most cases there is no lookup at all because original tuple is not taken and can be used as-is. What needs to be fast is insertion and deletion. rhlist removal however requires a rhlist walk. We can have thousands of entries in such a list if source port/addresses are reused for multiple flows, if this happens removal requests are so expensive that deletions of a few thousand flows can take several seconds(!). The advantages that we got from rhashtable are: 1) table auto-sizing 2) multiple locks 1) would be nice to have, but it is not essential as we have at most one lookup per new flow, so even a million flows in the bysource table are not a problem compared to current deletion cost. 2) is easy to add to custom hash table. I tried to add hlist_node to rhlist to speed up rhltable_remove but this isn't doable without changing semantics. rhltable_remove_fast will check that the to-be-deleted object is part of the table and that requires a list walk that we want to avoid. Furthermore, using hlist_node increases size of struct rhlist_head, which in turn increases nf_conn size. Link: https://bugzilla.kernel.org/show_bug.cgi?id=196821 Reported-by: Ivan Babrou <ibobrik@gmail.com> Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>		2017-09-08 18:55:50 +02:00
..
acpi	Device properties framework updates for v4.14-rc1	2017-09-05 12:50:00 -07:00
asm-generic	Merge branch 'x86-mm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-09-04 12:21:28 -07:00
clocksource
crypto
drm
dt-bindings
keys
kvm
linux	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2017-09-06 15:17:17 -07:00
math-emu
media
memory
misc
net	netfilter: nat: Revert "netfilter: nat: convert nat bysrc hash to rhashtable"	2017-09-08 18:55:50 +02:00
pcmcia
ras
rdma	IB/core: Assign root to all drivers	2017-08-31 08:35:14 -04:00
scsi
soc
sound
target
trace	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-09-06 14:45:08 -07:00
uapi	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-09-06 14:45:08 -07:00
video
xen