Theodore Ts'o 9154420173 jbd2: fix race when writing superblock ... [ Upstream commit 538bcaa626 ] The jbd2 superblock is lockless now, so there is probably a race condition between writing it so disk and modifing contents of it, which may lead to checksum error. The following race is the one case that we have captured. jbd2 fsstress jbd2_journal_commit_transaction jbd2_journal_update_sb_log_tail jbd2_write_superblock jbd2_superblock_csum_set jbd2_journal_revoke jbd2_journal_set_features(revork) modify superblock submit_bh(checksum incorrect) Fix this by locking the buffer head before modifing it. We always write the jbd2 superblock after we modify it, so this just means calling the lock_buffer() a little earlier. This checksum corruption problem can be reproduced by xfstests generic/475. Reported-by: zhangyi (F) <yi.zhang@huawei.com> Suggested-by: Jan Kara <jack@suse.cz> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-04-05 22:33:07 +02:00
..
9p	9p: use inode->i_lock to protect i_size_write() under 32-bit	2019-03-23 20:09:38 +01:00
adfs	adfs: use timespec64 for time conversion	2018-08-22 10:52:51 -07:00
affs
afs	afs: Fix key refcounting in file locking code	2019-02-27 10:08:56 +01:00
autofs	autofs: fix error return in autofs_fill_super()	2019-03-13 14:02:32 -07:00
befs
bfs	bfs: add sanity check at bfs_fill_super()	2018-12-01 09:37:27 +01:00
btrfs	btrfs: qgroup: Make qgroup async transaction commit more aggressive	2019-04-05 22:33:02 +02:00
cachefiles	fscache, cachefiles: remove redundant variable 'cache'	2018-12-17 09:24:40 +01:00
ceph	ceph: avoid repeatedly adding inode to mdsc->snap_flush_list	2019-02-27 10:08:50 +01:00
cifs	cifs: Fix NULL pointer dereference of devname	2019-04-05 22:33:00 +02:00
coda
configfs
cramfs	Cramfs: fix abad comparison when wrap-arounds occur	2018-11-13 11:08:55 -08:00
crypto	crypto: speck - remove Speck	2018-11-13 11:08:46 -08:00
debugfs	debugfs: fix debugfs_rename parameter checking	2019-02-15 08:10:11 +01:00
devpts	fs/devpts: always delete dcache dentry-s in dput()	2019-03-23 20:09:59 +01:00
dlm	dlm: Don't swamp the CPU with callbacks queued during recovery	2019-02-12 19:46:58 +01:00
ecryptfs
efivarfs
efs
exofs	fs/exofs: fix potential memory leak in mount option parsing	2018-11-27 16:13:00 +01:00
exportfs	exportfs: do not read dentry after free	2018-12-17 09:24:35 +01:00
ext2	ext2: Fix underflow in ext2_max_size()	2019-03-23 20:10:03 +01:00
ext4	ext4: cleanup bh release code in ext4_ind_remove_space()	2019-04-05 22:32:55 +02:00
f2fs	f2fs: fix to check inline_xattr_size boundary correctly	2019-04-05 22:32:59 +02:00
fat	fs/fat/fatent.c: add cond_resched() to fat_count_free_clusters()	2018-10-13 09:31:03 +02:00
freevxfs
fscache	fscache: fix race between enablement and dropping of object	2018-12-17 09:24:40 +01:00
fuse	fuse: handle zero sized retrieve correctly	2019-02-12 19:47:24 +01:00
gfs2	gfs2: Fix missed wakeups in find_insert_glock	2019-03-13 14:02:40 -07:00
hfs	hfs: do not free node before using	2018-12-17 09:24:41 +01:00
hfsplus	hfsplus: do not free node before using	2018-12-17 09:24:41 +01:00
hostfs	vfs: discard ATTR_ATTR_FLAG	2018-08-17 16:20:28 -07:00
hpfs	hpfs: remove unnecessary checks on the value of r when assigning error code	2018-08-25 12:42:33 -07:00
hugetlbfs	hugetlbfs: fix races and page leaks during migration	2019-03-05 17:58:53 +01:00
isofs	isofs: reject hardware sector size > 2048 bytes	2018-08-21 11:37:41 +02:00
jbd2	jbd2: fix race when writing superblock	2019-04-05 22:33:07 +02:00
jffs2	jffs2: Fix use of uninitialized delayed_work, lockdep breakage	2019-01-26 09:32:37 +01:00
jfs	Just one jfs patch for 4.19	2018-08-15 22:47:23 -07:00
kernfs	fix cgroup_do_mount() handling of failure exits	2019-03-23 20:09:53 +01:00
lockd	NFS: fix mount/umount race in nlmclnt.	2019-04-03 06:26:21 +02:00
minix
nfs	NFSv4.1 don't free interrupted slot on open	2019-04-03 06:26:22 +02:00
nfs_common
nfsd	nfsd: fix wrong check in write_v4_end_grace()	2019-03-23 20:10:09 +01:00
nilfs2	nilfs2: convert to SPDX license tags	2018-09-04 16:45:02 -07:00
nls
notify	inotify: Fix fd refcount leak in inotify_add_watch().	2019-01-31 08:14:34 +01:00
ntfs	ntfs: mft: remove VLA usage	2018-08-17 16:20:27 -07:00
ocfs2	ocfs2: fix a panic problem caused by o2cb_ctl	2019-04-05 22:32:59 +02:00
omfs
openpromfs
orangefs	orangefs: remove redundant pointer orangefs_inode	2018-08-14 12:07:14 -04:00
overlayfs	ovl: Do not lose security.capability xattr over metadata file copy-up	2019-03-23 20:09:59 +01:00
proc	fs/proc/proc_sysctl.c: fix NULL pointer dereference in put_links	2019-04-03 06:26:26 +02:00
pstore	pstore/ram: Do not treat empty buffers as valid	2019-01-26 09:32:37 +01:00
qnx4
qnx6
quota	quota: Lock s_umount in exclusive mode for Q_XQUOTA{ON,OFF} quotactls.	2019-01-26 09:32:42 +01:00
ramfs
reiserfs	reiserfs: propagate errors from fill_with_dentries() properly	2018-11-27 16:12:59 +01:00
romfs
squashfs	Squashfs: Compute expected length from inode size rather than block length	2018-08-02 09:34:02 -07:00
sysfs	Driver core patches for 4.19-rc1	2018-08-18 11:44:53 -07:00
sysv	sysv: return 'err' instead of 0 in __sysv_write_inode	2018-12-17 09:24:30 +01:00
tracefs	tracefs: Annotate tracefs_ops with __ro_after_init	2018-07-31 11:32:44 -04:00
ubifs	ubifs: Handle re-linking of inodes correctly while recovery	2018-12-29 13:37:55 +01:00
udf	udf: Fix crash on IO error during truncate	2019-03-27 14:14:39 +09:00
ufs	fs/ufs: use ktime_get_real_seconds for sb and cg timestamps	2018-08-17 16:20:27 -07:00
xfs	xfs: eof trim writeback mapping as soon as it is cached	2019-02-12 19:47:23 +01:00
aio.c	aio: Fix locking in aio_poll()	2019-03-10 07:17:21 +01:00
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c
binfmt_elf.c	Here are the main MIPS changes for 4.19.	2018-08-13 19:24:32 -07:00
binfmt_elf_fdpic.c
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c
binfmt_script.c	Revert "exec: load_script: don't blindly truncate shebang string"	2019-02-15 09:09:54 +01:00
block_dev.c	blockdev: Fix livelocks on loop device	2019-01-22 21:40:36 +01:00
buffer.c	fs: fix guard_bio_eod to check for real EOD errors	2019-04-05 22:33:00 +02:00
char_dev.c
compat.c
compat_binfmt_elf.c
compat_ioctl.c	media: dvb/audio.h: get rid of unused APIs	2018-07-30 16:21:49 -04:00
coredump.c
d_path.c
dax.c	dax: Use non-exclusive wait in wait_entry_unlocked()	2019-01-09 17:38:46 +01:00
dcache.c	fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()	2019-02-06 17:30:11 +01:00
dcookies.c
direct-io.c	direct-io: allow direct writes to empty inodes	2019-03-05 17:58:50 +01:00
drop_caches.c	fs/drop_caches.c: avoid softlockups in drop_pagecache_sb()	2019-03-13 14:02:32 -07:00
eventfd.c
eventpoll.c	fs/epoll: drop ovflist branch prediction	2019-02-12 19:47:19 +01:00
exec.c	exec: Fix mem leak in kernel_read_file	2019-03-10 07:17:21 +01:00
fcntl.c	signal: Don't send signals to tasks that don't exist	2018-08-15 23:03:20 -05:00
fhandle.c
file.c	fs/file.c: initialize init_files.resize_wait	2019-04-05 22:32:59 +02:00
file_table.c	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
filesystems.c
fs-writeback.c	writeback: synchronize sync(2) against cgroup writeback membership switches	2019-03-05 17:58:50 +01:00
fs_pin.c
fs_struct.c
inode.c	Revert "mm: don't reclaim inodes with many attached pages"	2019-02-20 10:25:47 +01:00
internal.h	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
ioctl.c	vfs: fix FIGETBSZ ioctl on an overlayfs file	2018-11-21 09:19:14 +01:00
iomap.c	iomap: fix a use after free in iomap_dio_rw	2019-03-13 14:02:29 -07:00
Kconfig
Kconfig.binfmt	kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt	2018-08-02 08:06:55 +09:00
libfs.c
locks.c	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
Makefile
mbcache.c
mount.h
mpage.c	mpage: mpage_readpages() should submit IO as read-ahead	2018-08-17 16:20:29 -07:00
namei.c	Revert "vfs: Allow userns root to call mknod on owned filesystems."	2018-12-29 13:37:54 +01:00
namespace.c	mnt: fix __detach_mounts infinite loop	2018-11-21 09:19:22 +01:00
no-block.c
nsfs.c
open.c	fs/open.c: allow opening only regular files during execve()	2019-04-03 06:26:23 +02:00
pipe.c	splice: don't merge into linked buffers	2019-03-23 20:09:59 +01:00
pnode.c
pnode.h
posix_acl.c
proc_namespace.c
read_write.c	vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1	2019-04-05 22:33:06 +02:00
readdir.c
select.c
seq_file.c	fs/seq_file.c: simplify seq_file iteration code and interface	2018-08-17 16:20:28 -07:00
signalfd.c
splice.c	splice: don't merge into linked buffers	2019-03-23 20:09:59 +01:00
stack.c
stat.c
statfs.c
super.c	Merge branch 'ida-4.19' of git://git.infradead.org/users/willy/linux-dax	2018-08-26 11:48:42 -07:00
sync.c
timerfd.c	Merge branch 'work.aio' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-08-13 20:56:23 -07:00
userfaultfd.c	userfaultfd: clear flag if remap event not enabled	2019-01-26 09:32:43 +01:00
utimes.c
xattr.c	sysfs: Do not return POSIX ACL xattrs via listxattr	2018-09-18 07:30:48 -04:00