Peter Pan(潘卫平) 0696c3a8ac net:set valid name before calling ndo_init() ... In commit 1c5cae815d (net: call dev_alloc_name from register_netdevice), a bug of bonding was involved, see example 1 and 2. In register_netdevice(), the name of net_device is not valid until dev_get_valid_name() is called. But dev->netdev_ops->ndo_init(that is bond_init) is called before dev_get_valid_name(), and it uses the invalid name of net_device. I think register_netdevice() should make sure that the name of net_device is valid before calling ndo_init(). example 1: modprobe bonding ls /proc/net/bonding/bond%d ps -eLf root 3398 2 3398 0 1 21:34 ? 00:00:00 [bond%d] example 2: modprobe bonding max_bonds=3 [ 170.100292] bonding: Ethernet Channel Bonding Driver: v3.7.1 (April 27, 2011) [ 170.101090] bonding: Warning: either miimon or arp_interval and arp_ip_target module parameters must be specified, otherwise bonding will not detect link failures! see bonding.txt for details. [ 170.102469] ------------[ cut here ]------------ [ 170.103150] WARNING: at /home/pwp/net-next-2.6/fs/proc/generic.c:586 proc_register+0x126/0x157() [ 170.104075] Hardware name: VirtualBox [ 170.105065] proc_dir_entry 'bonding/bond%d' already registered [ 170.105613] Modules linked in: bonding(+) sunrpc ipv6 uinput microcode ppdev parport_pc parport joydev e1000 pcspkr i2c_piix4 i2c_core [last unloaded: bonding] [ 170.108397] Pid: 3457, comm: modprobe Not tainted 2.6.39-rc2+ #14 [ 170.108935] Call Trace: [ 170.109382] [<c0438f3b>] warn_slowpath_common+0x6a/0x7f [ 170.109911] [<c051a42a>] ? proc_register+0x126/0x157 [ 170.110329] [<c0438fc3>] warn_slowpath_fmt+0x2b/0x2f [ 170.110846] [<c051a42a>] proc_register+0x126/0x157 [ 170.111870] [<c051a4dd>] proc_create_data+0x82/0x98 [ 170.112335] [<f94e6af6>] bond_create_proc_entry+0x3f/0x73 [bonding] [ 170.112905] [<f94dd806>] bond_init+0x77/0xa5 [bonding] [ 170.113319] [<c0721ac6>] register_netdevice+0x8c/0x1d3 [ 170.113848] [<f94e0e30>] bond_create+0x6c/0x90 [bonding] [ 170.114322] [<f94f4763>] bonding_init+0x763/0x7b1 [bonding] [ 170.114879] [<c0401240>] do_one_initcall+0x76/0x122 [ 170.115317] [<f94f4000>] ? 0xf94f3fff [ 170.115799] [<c0463f1e>] sys_init_module+0x1286/0x140d [ 170.116879] [<c07c6d9f>] sysenter_do_call+0x12/0x28 [ 170.117404] ---[ end trace 64e4fac3ae5fff1a ]--- [ 170.117924] bond%d: Warning: failed to register to debugfs [ 170.128728] ------------[ cut here ]------------ [ 170.129360] WARNING: at /home/pwp/net-next-2.6/fs/proc/generic.c:586 proc_register+0x126/0x157() [ 170.130323] Hardware name: VirtualBox [ 170.130797] proc_dir_entry 'bonding/bond%d' already registered [ 170.131315] Modules linked in: bonding(+) sunrpc ipv6 uinput microcode ppdev parport_pc parport joydev e1000 pcspkr i2c_piix4 i2c_core [last unloaded: bonding] [ 170.133731] Pid: 3457, comm: modprobe Tainted: G W 2.6.39-rc2+ #14 [ 170.134308] Call Trace: [ 170.134743] [<c0438f3b>] warn_slowpath_common+0x6a/0x7f [ 170.135305] [<c051a42a>] ? proc_register+0x126/0x157 [ 170.135820] [<c0438fc3>] warn_slowpath_fmt+0x2b/0x2f [ 170.137168] [<c051a42a>] proc_register+0x126/0x157 [ 170.137700] [<c051a4dd>] proc_create_data+0x82/0x98 [ 170.138174] [<f94e6af6>] bond_create_proc_entry+0x3f/0x73 [bonding] [ 170.138745] [<f94dd806>] bond_init+0x77/0xa5 [bonding] [ 170.139278] [<c0721ac6>] register_netdevice+0x8c/0x1d3 [ 170.139828] [<f94e0e30>] bond_create+0x6c/0x90 [bonding] [ 170.140361] [<f94f4763>] bonding_init+0x763/0x7b1 [bonding] [ 170.140927] [<c0401240>] do_one_initcall+0x76/0x122 [ 170.141494] [<f94f4000>] ? 0xf94f3fff [ 170.141975] [<c0463f1e>] sys_init_module+0x1286/0x140d [ 170.142463] [<c07c6d9f>] sysenter_do_call+0x12/0x28 [ 170.142974] ---[ end trace 64e4fac3ae5fff1b ]--- [ 170.144949] bond%d: Warning: failed to register to debugfs Signed-off-by: Weiping Pan <panweiping3@gmail.com> Reviewed-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2011-05-13 16:49:49 -04:00
..
9p	9p: Kill set but unused variable in 9p_client_{read,write}() and p9_client_readdir()	2011-04-12 15:58:41 -07:00
802	garp: remove last synchronize_rcu() call	2011-05-12 17:46:56 -04:00
8021q	net: Fix vlan_features propagation	2011-05-12 17:54:13 -04:00
appletalk	appletalk: Fix OOPS in atalk_release().	2011-03-31 18:59:10 -07:00
atm	atm: lec: Fix set-but-unused variables.	2011-04-17 00:48:36 -07:00
ax25	ax25: Fix set-but-unused variable.	2011-04-17 00:48:31 -07:00
batman-adv	Merge branch 'batman-adv/next' of git://git.open-mesh.org/ecsv/linux-merge	2011-05-08 15:39:11 -07:00
bluetooth	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6 into for-davem	2011-05-05 13:32:35 -04:00
bridge	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-3.6	2011-05-11 14:26:58 -04:00
caif	caif: Fix set-but-unused variables.	2011-04-17 16:57:55 -07:00
can	can: rename can_try_module_get to can_get_proto	2011-05-04 14:08:37 -07:00
ceph	Merge branch 'for-linus2' of git://git.profusion.mobi/users/lucas/linux-2.6	2011-04-07 11:14:49 -07:00
core	net:set valid name before calling ndo_init()	2011-05-13 16:49:49 -04:00
dcb	net: dcbnl: Update copyright dates	2011-03-14 17:02:42 -07:00
dccp	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-3.6	2011-05-11 14:26:58 -04:00
decnet	net: dont hold rtnl mutex during netlink dump callbacks	2011-05-02 15:26:28 -07:00
dns_resolver	DNS: Fix a NULL pointer deref when trying to read an error key [CVE-2011-1076]	2011-03-04 09:56:19 +11:00
dsa	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2011-05-05 14:59:02 -07:00
econet	econet: Fix set-but-unused variable.	2011-04-17 00:15:22 -07:00
ethernet
ieee802154	ieee802154: Remove hacked CFLAGS in net/ieee802154/Makefile	2011-04-12 15:33:23 -07:00
ipv4	net: ipv4: add IPPROTO_ICMP socket kind	2011-05-13 16:08:13 -04:00
ipv6	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-3.6	2011-05-11 14:26:58 -04:00
ipx	ipx: fix ipx_release()	2011-03-21 18:16:39 -07:00
irda	net/irda/ircomm_tty.c: Use flip buffers to deliver data	2011-05-12 18:02:51 -04:00
iucv	convert old cpumask API into new one	2011-05-13 14:55:21 -04:00
key	inet: constify ip headers and in6_addr	2011-04-22 11:04:14 -07:00
l2tp	l2tp: fix potential rcu race	2011-05-12 17:27:10 -04:00
lapb
llc	llc: Fix length check in llc_fixup_skb().	2011-04-11 18:59:05 -07:00
mac80211	Merge branch 'for-davem' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6	2011-05-05 14:09:28 -07:00
netfilter	ipvs: Remove all remaining references to rt->rt_{src,dst}	2011-05-12 18:24:46 -04:00
netlabel	netlabel: Fix set-but-unused variables.	2011-04-17 17:01:49 -07:00
netlink	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2011-03-03 21:27:42 -08:00
netrom	NET: AX.25, NETROM, ROSE: Remove SOCK_DEBUG calls	2011-04-14 00:20:07 -07:00
packet	net: filter: Just In Time compiler for x86-64	2011-04-27 23:05:08 -07:00
phonet	net: dont hold rtnl mutex during netlink dump callbacks	2011-05-02 15:26:28 -07:00
rds	Fix common misspellings	2011-03-31 11:26:23 -03:00
rfkill	rfkill: Regulator consumer driver for rfkill	2011-04-19 15:38:02 -04:00
rose	NET: AX.25, NETROM, ROSE: Remove SOCK_DEBUG calls	2011-04-14 00:20:07 -07:00
rxrpc	ipv4: Make caller provide on-stack flow key to ip_route_output_ports().	2011-05-03 20:25:42 -07:00
sched	inet: constify ip headers and in6_addr	2011-04-22 11:04:14 -07:00
sctp	sctp: sctp_sendmsg: Don't test known non-null sinfo	2011-05-12 17:30:50 -04:00
sunrpc	Merge branch 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/nfs-2.6	2011-04-08 11:47:35 -07:00
tipc	tipc: Revise timings used when sending link request messages	2011-05-10 16:04:02 -04:00
unix	af_unix: Only allow recv on connected seqpacket sockets.	2011-05-01 23:16:28 -07:00
wanrouter	Fix common misspellings	2011-03-31 11:26:23 -03:00
wimax
wireless	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6 into for-davem	2011-05-05 13:32:35 -04:00
x25	Fix common misspellings	2011-03-31 11:26:23 -03:00
xfrm	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-3.6	2011-05-11 14:26:58 -04:00
compat.c	net: Add sendmmsg socket system call	2011-05-05 11:10:14 -07:00
Kconfig	bpf: depends on MODULES	2011-04-29 10:20:53 -07:00
Makefile	net: Enter net/ipv6/ even if CONFIG_IPV6=n	2011-03-07 12:50:52 -08:00
nonet.c
socket.c	net: Add sendmmsg socket system call	2011-05-05 11:10:14 -07:00
sysctl_net.c
TUNABLE