Davide Caratti 4fbefeab88 net/sched: sch_fq: fix integer overflow of "credit" ... [ Upstream commit 7041101ff6 ] if sch_fq is configured with "initial quantum" having values greater than INT_MAX, the first assignment of "credit" does signed integer overflow to a very negative value. In this situation, the syzkaller script provided by Cristoph triggers the CPU soft-lockup warning even with few sockets. It's not an infinite loop, but "credit" wasn't probably meant to be minus 2Gb for each new flow. Capping "initial quantum" to INT_MAX proved to fix the issue. v2: validation of "initial quantum" is done in fq_policy, instead of open coding in fq_change() _ suggested by Jakub Kicinski Reported-by: Christoph Paasch <cpaasch@apple.com> Link: https://github.com/multipath-tcp/mptcp_net-next/issues/377 Fixes: afe4fd0624 ("pkt_sched: fq: Fair Queue packet scheduler") Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Davide Caratti <dcaratti@redhat.com> Link: https://lore.kernel.org/r/7b3a3c7e36d03068707a021760a194a8eb5ad41a.1682002300.git.dcaratti@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-05-11 23:03:26 +09:00
..
act_api.c	net: sched: act_api: implement generic walker and search for tc action	2022-09-09 08:24:41 +01:00
act_bpf.c	net: sched: act_bpf: simplify code logic in tcf_bpf_init()	2022-09-28 09:38:56 +01:00
act_connmark.c	netfilter: conntrack: Fix data-races around ct mark	2022-11-18 15:21:00 +01:00
act_csum.c	net: sched: act_csum: get rid of tcf_csum_walker and tcf_csum_search	2022-09-09 08:24:41 +01:00
act_ct.c	netfilter: conntrack: Fix data-races around ct mark	2022-11-18 15:21:00 +01:00
act_ctinfo.c	net/sched: act_ctinfo: use percpu stats	2023-02-22 12:59:52 +01:00
act_gact.c	treewide: use prandom_u32_max() when possible, part 1	2022-10-11 17:42:55 -06:00
act_gate.c	net: sched: act_gate: get rid of tcf_gate_walker and tcf_gate_search	2022-09-09 08:24:42 +01:00
act_ife.c	net: sched: act_ife: get rid of tcf_ife_walker and tcf_ife_search	2022-09-09 08:24:42 +01:00
act_ipt.c	net: sched: act_ipt: get rid of tcf_ipt_walker/tcf_xt_walker and tcf_ipt_search/tcf_xt_search	2022-09-09 08:24:42 +01:00
act_meta_mark.c
act_meta_skbprio.c
act_meta_skbtcindex.c
act_mirred.c	act_mirred: use the backlog for nested calls to mirred ingress	2023-03-30 12:49:20 +02:00
act_mpls.c	net/sched: act_mpls: fix action bind logic	2023-03-11 13:55:28 +01:00
act_nat.c	net: sched: act_nat: get rid of tcf_nat_walker and tcf_nat_search	2022-09-09 08:24:42 +01:00
act_pedit.c	net/sched: act_pedit: fix action bind logic	2023-03-11 13:55:28 +01:00
act_police.c	net: sched: act_police: get rid of tcf_police_walker and tcf_police_search	2022-09-09 08:24:42 +01:00
act_sample.c	net/sched: act_sample: fix action bind logic	2023-03-11 13:55:28 +01:00
act_simple.c	net: sched: act_simple: get rid of tcf_simp_walker and tcf_simp_search	2022-09-09 08:24:42 +01:00
act_skbedit.c	net: sched: act_skbedit: get rid of tcf_skbedit_walker and tcf_skbedit_search	2022-09-09 08:24:42 +01:00
act_skbmod.c	net: sched: act_skbmod: get rid of tcf_skbmod_walker and tcf_skbmod_search	2022-09-09 08:24:42 +01:00
act_tunnel_key.c	net: sched: act_tunnel_key: get rid of tunnel_key_walker and tunnel_key_search	2022-09-09 08:24:42 +01:00
act_vlan.c	net: sched: act_vlan: get rid of tcf_vlan_walker and tcf_vlan_search	2022-09-09 08:24:43 +01:00
cls_api.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-09-22 13:02:10 -07:00
cls_basic.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_bpf.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_cgroup.c
cls_flow.c	net/sched: use tc_cls_stats_dump() in filter	2022-09-20 15:54:13 -07:00
cls_flower.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_fw.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_matchall.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_route.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_rsvp.c
cls_rsvp.h	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_rsvp6.c
cls_u32.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
em_canid.c
em_cmp.c
em_ipset.c
em_ipt.c
em_meta.c	net_sched: em_meta: add READ_ONCE() in var_sk_bound_if()	2022-05-16 10:31:06 +01:00
em_nbyte.c
em_text.c
em_u32.c
ematch.c	net_sched: reject TCF_EM_SIMPLE case for complex ematch module	2022-12-31 13:32:55 +01:00
Kconfig	net/sched: Retire tcindex classifier	2023-03-11 13:55:16 +01:00
Makefile	net/sched: Retire tcindex classifier	2023-03-11 13:55:16 +01:00
sch_api.c	net: sched: disallow noqueue for qdisc classes	2023-01-14 10:33:43 +01:00
sch_atm.c	net: sched: atm: dont intepret cls results when asked to drop	2023-01-12 12:02:24 +01:00
sch_blackhole.c
sch_cake.c	Networking fixes for 6.1-rc2, including fixes from netfilter	2022-10-20 17:24:59 -07:00
sch_cbq.c	net: sched: cbq: dont intepret cls results when asked to drop	2023-01-12 12:02:24 +01:00
sch_cbs.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_choke.c	net: sched: choke: remove unused variables in struct choke_sched_data	2022-08-31 19:39:53 -07:00
sch_codel.c	net: sched: remove redundant NULL check in change hook function	2022-09-01 08:06:45 +02:00
sch_drr.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_dsmark.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_etf.c	net: sched: etf: remove true check in etf_enable_offload()	2022-09-01 20:08:32 -07:00
sch_ets.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_fifo.c
sch_fq.c	net/sched: sch_fq: fix integer overflow of "credit"	2023-05-11 23:03:26 +09:00
sch_fq_codel.c	Revert "net: sched: fq_codel: remove redundant resource cleanup in fq_codel_init()"	2022-10-19 13:47:09 +01:00
sch_fq_pie.c	net: sched: remove redundant NULL check in change hook function	2022-09-01 08:06:45 +02:00
sch_frag.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-12-31 14:35:40 +00:00
sch_generic.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-09-01 12:58:02 -07:00
sch_gred.c	net: sched: gred: prevent races when adding offloads to stats	2023-02-01 08:34:25 +01:00
sch_hfsc.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_hhf.c	net: sched: remove redundant NULL check in change hook function	2022-09-01 08:06:45 +02:00
sch_htb.c	net: sched: sch: Fix off by one in htb_activate_prios()	2023-02-22 12:59:56 +01:00
sch_ingress.c
sch_mq.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_mqprio.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_multiq.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_netem.c	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
sch_pie.c	treewide: use get_random_bytes() when possible	2022-10-11 17:42:58 -06:00
sch_plug.c	net: sched: remove redundant NULL check in change hook function	2022-09-01 08:06:45 +02:00
sch_prio.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_qfq.c	net: sched: sch_qfq: prevent slab-out-of-bounds in qfq_activate_agg	2023-04-26 14:28:32 +02:00
sch_red.c	net: sched: Fix use after free in red_enqueue()	2022-10-31 11:55:39 +00:00
sch_sfb.c	Networking fixes for 6.1-rc2, including fixes from netfilter	2022-10-20 17:24:59 -07:00
sch_sfq.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_skbprio.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_taprio.c	net/sched: sch_taprio: do not schedule in taprio_reset()	2023-02-01 08:34:46 +01:00
sch_tbf.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_teql.c	net: sched: delete duplicate cleanup of backlog and qlen	2022-08-25 15:10:17 +02:00