Chao Yu 5b25035fb8 f2fs: fix to do sanity check on i_extra_isize in is_alive() ... commit d3b7b4afd6 upstream. syzbot found a f2fs bug: BUG: KASAN: slab-out-of-bounds in data_blkaddr fs/f2fs/f2fs.h:2891 [inline] BUG: KASAN: slab-out-of-bounds in is_alive fs/f2fs/gc.c:1117 [inline] BUG: KASAN: slab-out-of-bounds in gc_data_segment fs/f2fs/gc.c:1520 [inline] BUG: KASAN: slab-out-of-bounds in do_garbage_collect+0x386a/0x3df0 fs/f2fs/gc.c:1734 Read of size 4 at addr ffff888076557568 by task kworker/u4:3/52 CPU: 1 PID: 52 Comm: kworker/u4:3 Not tainted 6.1.0-rc4-syzkaller-00362-gfef7fd48922d #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Workqueue: writeback wb_workfn (flush-7:0) Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 print_address_description mm/kasan/report.c:284 [inline] print_report+0x15e/0x45d mm/kasan/report.c:395 kasan_report+0xbb/0x1f0 mm/kasan/report.c:495 data_blkaddr fs/f2fs/f2fs.h:2891 [inline] is_alive fs/f2fs/gc.c:1117 [inline] gc_data_segment fs/f2fs/gc.c:1520 [inline] do_garbage_collect+0x386a/0x3df0 fs/f2fs/gc.c:1734 f2fs_gc+0x88c/0x20a0 fs/f2fs/gc.c:1831 f2fs_balance_fs+0x544/0x6b0 fs/f2fs/segment.c:410 f2fs_write_inode+0x57e/0xe20 fs/f2fs/inode.c:753 write_inode fs/fs-writeback.c:1440 [inline] __writeback_single_inode+0xcfc/0x1440 fs/fs-writeback.c:1652 writeback_sb_inodes+0x54d/0xf90 fs/fs-writeback.c:1870 wb_writeback+0x2c5/0xd70 fs/fs-writeback.c:2044 wb_do_writeback fs/fs-writeback.c:2187 [inline] wb_workfn+0x2dc/0x12f0 fs/fs-writeback.c:2227 process_one_work+0x9bf/0x1710 kernel/workqueue.c:2289 worker_thread+0x665/0x1080 kernel/workqueue.c:2436 kthread+0x2e4/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 The root cause is that we forgot to do sanity check on .i_extra_isize in below path, result in accessing invalid address later, fix it. - gc_data_segment - is_alive - data_blkaddr - offset_in_addr Reported-by: syzbot+f8f3dfa4abc489e768a1@syzkaller.appspotmail.com Link: https://lore.kernel.org/linux-f2fs-devel/0000000000003cb3c405ed5c17f9@google.com/T/#u Signed-off-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-02-09 11:28:27 +01:00
..
acl.c	f2fs: port to vfs{g,u}id_t and associated helpers	2022-10-04 13:31:43 -07:00
acl.h	vfs: add rcu argument to ->get_acl() callback	2021-08-18 22:08:24 +02:00
checkpoint.c	f2fs: support recording stop_checkpoint reason into super_block	2022-10-04 13:31:44 -07:00
compress.c	f2fs: set zstd compress level correctly	2022-12-31 13:32:36 +01:00
data.c	f2fs-for-6.1-rc1	2022-10-10 20:28:41 -07:00
debug.c	f2fs: change to use atomic_t type form sbi.atomic_files	2022-10-07 12:57:26 -07:00
dir.c	f2fs: support recording errors into superblock	2022-10-04 13:31:45 -07:00
extent_cache.c	f2fs: let's avoid panic if extent_tree is not created	2023-01-24 07:24:32 +01:00
f2fs.h	f2fs: fix to enable compress for newly created file if extension matches	2022-12-31 13:32:36 +01:00
file.c	f2fs: allow to set compression for inlined file	2022-12-31 13:32:31 +01:00
gc.c	f2fs: fix to do sanity check on i_extra_isize in is_alive()	2023-02-09 11:28:27 +01:00
gc.h	f2fs: remove redundant code for gc condition	2022-07-30 20:16:20 -07:00
hash.c	f2fs: don't use casefolded comparison for "." and ".."	2022-05-17 11:19:23 -07:00
inline.c	f2fs: support recording errors into superblock	2022-10-04 13:31:45 -07:00
inode.c	f2fs: support recording errors into superblock	2022-10-04 13:31:45 -07:00
iostat.c	f2fs: iostat: support accounting compressed IO	2022-08-29 21:15:51 -07:00
iostat.h	f2fs: iostat: support accounting compressed IO	2022-08-29 21:15:51 -07:00
Kconfig	f2fs: introduce F2FS_UNFAIR_RWSEM to support unfair rwsem	2022-03-04 09:15:53 -08:00
Makefile	f2fs: separate out iostat feature	2021-08-23 10:25:51 -07:00
namei.c	f2fs: fix to enable compress for newly created file if extension matches	2022-12-31 13:32:36 +01:00
node.c	f2fs: allow to read node block after shutdown	2023-01-04 11:29:01 +01:00
node.h	f2fs: change the current atomic write way	2022-05-12 10:14:03 -07:00
recovery.c	f2fs: support recording errors into superblock	2022-10-04 13:31:45 -07:00
segment.c	f2fs: fix iostat parameter for discard	2022-12-31 13:32:38 +01:00
segment.h	f2fs: support recording errors into superblock	2022-10-04 13:31:45 -07:00
shrinker.c	f2fs: avoid race condition for shrinker count	2020-12-03 00:59:26 -08:00
super.c	f2fs: initialize locks earlier in f2fs_fill_super()	2023-02-09 11:28:27 +01:00
sysfs.c	f2fs: introduce cp_status sysfs entry	2022-10-04 13:31:44 -07:00
verity.c	- Alistair Popple has a series which addresses a race which causes page	2022-10-14 12:28:43 -07:00
xattr.c	f2fs: support recording errors into superblock	2022-10-04 13:31:45 -07:00
xattr.h	f2fs: code cleanup by removing ifdef macro surrounding	2020-05-26 18:56:10 -07:00