mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 18:09:57 +00:00
f135046e51
When closing the DRM device while a vblank is pending, we access file_priv after it has been free'd, which gives: Unable to handle kernel NULL pointer dereference at virtual address 00000000 ... PC is at __list_add+0x5c/0xe8 LR is at send_vblank_event+0x54/0x1f0 ... [<c02952e8>] (__list_add) from [<c031a7b4>] (send_vblank_event+0x54/0x1f0) [<c031a760>] (send_vblank_event) from [<c031a9c0>] (drm_send_vblank_event+0x70/0x78) [<c031a950>] (drm_send_vblank_event) from [<c031a9f8>] (drm_crtc_send_vblank_event+0x30/0x34) [<c031a9c8>] (drm_crtc_send_vblank_event) from [<c0339ad8>] (vop_isr+0x224/0x28c) [<c03398b4>] (vop_isr) from [<c0081780>] (handle_irq_event_percpu+0x12c/0x3e4) This can be triggered somewhat reliably with: modetest -M rockchip -v -s ... Add a preclose hook to the driver so that we can discard any pending vblank events when the device is closed. Signed-off-by: John Keeping <john@metanate.com>
77 lines
2.3 KiB
C
77 lines
2.3 KiB
C
/*
|
|
* Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
|
|
* Author:Mark Yao <mark.yao@rock-chips.com>
|
|
*
|
|
* based on exynos_drm_drv.h
|
|
*
|
|
* This software is licensed under the terms of the GNU General Public
|
|
* License version 2, as published by the Free Software Foundation, and
|
|
* may be copied, distributed, and modified under those terms.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#ifndef _ROCKCHIP_DRM_DRV_H
|
|
#define _ROCKCHIP_DRM_DRV_H
|
|
|
|
#include <drm/drm_fb_helper.h>
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_gem.h>
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/component.h>
|
|
|
|
#define ROCKCHIP_MAX_FB_BUFFER 3
|
|
#define ROCKCHIP_MAX_CONNECTOR 2
|
|
#define ROCKCHIP_MAX_CRTC 2
|
|
|
|
struct drm_device;
|
|
struct drm_connector;
|
|
|
|
/*
|
|
* Rockchip drm private crtc funcs.
|
|
* @enable_vblank: enable crtc vblank irq.
|
|
* @disable_vblank: disable crtc vblank irq.
|
|
*/
|
|
struct rockchip_crtc_funcs {
|
|
int (*enable_vblank)(struct drm_crtc *crtc);
|
|
void (*disable_vblank)(struct drm_crtc *crtc);
|
|
void (*wait_for_update)(struct drm_crtc *crtc);
|
|
void (*cancel_pending_vblank)(struct drm_crtc *crtc, struct drm_file *file_priv);
|
|
};
|
|
|
|
struct rockchip_atomic_commit {
|
|
struct work_struct work;
|
|
struct drm_atomic_state *state;
|
|
struct drm_device *dev;
|
|
struct mutex lock;
|
|
};
|
|
|
|
/*
|
|
* Rockchip drm private structure.
|
|
*
|
|
* @crtc: array of enabled CRTCs, used to map from "pipe" to drm_crtc.
|
|
* @num_pipe: number of pipes for this device.
|
|
*/
|
|
struct rockchip_drm_private {
|
|
struct drm_fb_helper fbdev_helper;
|
|
struct drm_gem_object *fbdev_bo;
|
|
const struct rockchip_crtc_funcs *crtc_funcs[ROCKCHIP_MAX_CRTC];
|
|
|
|
struct rockchip_atomic_commit commit;
|
|
};
|
|
|
|
void rockchip_drm_atomic_work(struct work_struct *work);
|
|
int rockchip_register_crtc_funcs(struct drm_crtc *crtc,
|
|
const struct rockchip_crtc_funcs *crtc_funcs);
|
|
void rockchip_unregister_crtc_funcs(struct drm_crtc *crtc);
|
|
int rockchip_drm_crtc_mode_config(struct drm_crtc *crtc, int connector_type,
|
|
int out_mode);
|
|
int rockchip_drm_dma_attach_device(struct drm_device *drm_dev,
|
|
struct device *dev);
|
|
void rockchip_drm_dma_detach_device(struct drm_device *drm_dev,
|
|
struct device *dev);
|
|
#endif /* _ROCKCHIP_DRM_DRV_H_ */
|