linux-stable/drivers/firmware/arm_scmi
Gustavo A. R. Silva 8694548ae1 firmware: arm_scmi/perf: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Replace the zero-length member "opp" in scmi_msg_resp_perf_describe_levels
structure with flexible-array.

Link: https://lore.kernel.org/r/20200211231252.GA14830@embeddedor
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
2020-02-20 17:12:24 +00:00
..
base.c firmware: arm_scmi: Use {get,put}_unaligned_le{32,64} accessors 2019-08-12 12:23:01 +01:00
bus.c firmware: arm_scmi: Skip protocol initialisation for additional devices 2019-12-24 11:36:26 +00:00
clock.c firmware: arm_scmi: Stash version in protocol init functions 2019-12-24 11:35:49 +00:00
common.h firmware: arm_scmi: Make scmi core independent of the transport type 2020-02-10 11:50:51 +00:00
driver.c firmware: arm_scmi: Make scmi core independent of the transport type 2020-02-10 11:50:51 +00:00
mailbox.c firmware: arm_scmi: Make scmi core independent of the transport type 2020-02-10 11:50:51 +00:00
Makefile firmware: arm_scmi: Make scmi core independent of the transport type 2020-02-10 11:50:51 +00:00
perf.c firmware: arm_scmi/perf: Replace zero-length array with flexible-array member 2020-02-20 17:12:24 +00:00
power.c firmware: arm_scmi: Stash version in protocol init functions 2019-12-24 11:35:49 +00:00
reset.c firmware: arm_scmi: Stash version in protocol init functions 2019-12-24 11:35:49 +00:00
scmi_pm_domain.c firmware: arm_scmi: Match scmi device by both name and protocol id 2019-12-24 11:35:49 +00:00
sensors.c firmware: arm_scmi: Stash version in protocol init functions 2019-12-24 11:35:49 +00:00
shmem.c firmware: arm_scmi: Replace zero-length array with flexible-array member 2020-02-20 17:11:28 +00:00