mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-13 14:14:37 +00:00
5979afa2c4
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20200220132908.GA30501@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
82 lines
1.5 KiB
C
82 lines
1.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Copyright (c) 2012 GCT Semiconductor, Inc. All rights reserved. */
|
|
|
|
#ifndef _HCI_PACKET_H_
|
|
#define _HCI_PACKET_H_
|
|
|
|
#define HCI_HEADER_SIZE 4
|
|
|
|
/*
|
|
* The NIC type definition:
|
|
* For backward compatibility, lower 16 bits used as they were.
|
|
* Lower 16 bit: NIC_TYPE values
|
|
* Uppoer 16 bit: NIC_TYPE Flags
|
|
*/
|
|
#define NIC_TYPE_NIC0 0x00000010
|
|
#define NIC_TYPE_NIC1 0x00000011
|
|
#define NIC_TYPE_NIC2 0x00000012
|
|
#define NIC_TYPE_NIC3 0x00000013
|
|
#define NIC_TYPE_ARP 0x00000100
|
|
#define NIC_TYPE_ICMPV6 0x00000200
|
|
#define NIC_TYPE_MASK 0x0000FFFF
|
|
#define NIC_TYPE_F_IPV4 0x00010000
|
|
#define NIC_TYPE_F_IPV6 0x00020000
|
|
#define NIC_TYPE_F_DHCP 0x00040000
|
|
#define NIC_TYPE_F_NDP 0x00080000
|
|
#define NIC_TYPE_F_VLAN 0x00100000
|
|
|
|
struct hci_packet {
|
|
__dev16 cmd_evt;
|
|
__dev16 len;
|
|
u8 data[];
|
|
} __packed;
|
|
|
|
struct tlv {
|
|
u8 type;
|
|
u8 len;
|
|
u8 *data[1];
|
|
} __packed;
|
|
|
|
struct sdu_header {
|
|
__dev16 cmd_evt;
|
|
__dev16 len;
|
|
__dev32 dft_eps_id;
|
|
__dev32 bearer_ID;
|
|
__dev32 nic_type;
|
|
} __packed;
|
|
|
|
struct sdu {
|
|
__dev16 cmd_evt;
|
|
__dev16 len;
|
|
__dev32 dft_eps_ID;
|
|
__dev32 bearer_ID;
|
|
__dev32 nic_type;
|
|
u8 data[];
|
|
} __packed;
|
|
|
|
struct multi_sdu {
|
|
__dev16 cmd_evt;
|
|
__dev16 len;
|
|
__dev16 num_packet;
|
|
__dev16 reserved;
|
|
u8 data[];
|
|
} __packed;
|
|
|
|
struct hci_pdn_table_ind {
|
|
__dev16 cmd_evt;
|
|
__dev16 len;
|
|
u8 activate;
|
|
__dev32 dft_eps_id;
|
|
__dev32 nic_type;
|
|
u8 pdn_type;
|
|
u8 ipv4_addr[4];
|
|
u8 ipv6_intf_id[8];
|
|
} __packed;
|
|
|
|
struct hci_connect_ind {
|
|
__dev16 cmd_evt;
|
|
__dev16 len;
|
|
__dev32 connect;
|
|
} __packed;
|
|
|
|
#endif /* _HCI_PACKET_H_ */
|