Peter Zijlstra a714491fa9 perf: Disallow mis-matched inherited group reads ... commit 32671e3799 upstream. Because group consistency is non-atomic between parent (filedesc) and children (inherited) events, it is possible for PERF_FORMAT_GROUP read() to try and sum non-matching counter groups -- with non-sensical results. Add group_generation to distinguish the case where a parent group removes and adds an event and thus has the same number, but a different configuration of events as inherited groups. This became a problem when commit fa8c269353 ("perf/core: Invert perf_read_group() loops") flipped the order of child_list and sibling_list. Previously it would iterate the group (sibling_list) first, and for each sibling traverse the child_list. In this order, only the group composition of the parent is relevant. By flipping the order the group composition of the child (inherited) events becomes an issue and the mis-match in group composition becomes evident. That said; even prior to this commit, while reading of a group that is not equally inherited was not broken, it still made no sense. (Ab)use ECHILD as error return to indicate issues with child process group composition. Fixes: fa8c269353 ("perf/core: Invert perf_read_group() loops") Reported-by: Budimir Markovic <markovicbudimir@gmail.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20231018115654.GK33217@noisy.programming.kicks-ass.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-10-25 11:17:02 +02:00
..
bpf	bpf: Address KCSAN report on bpf_lru_list	2023-08-11 11:45:25 +02:00
cgroup	cgroup: Remove duplicates in cgroup v1 tasks file	2023-10-25 11:16:34 +02:00
configs
debug	kdb: Make memory allocations more robust	2021-03-04 09:39:31 +01:00
dma	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
events	perf: Disallow mis-matched inherited group reads	2023-10-25 11:17:02 +02:00
gcov	gcov: add support for checksum field	2023-01-18 11:30:39 +01:00
irq	irqdomain: Drop bogus fwspec-mapping error handling	2023-03-11 16:31:52 +01:00
livepatch	livepatch: fix race between fork and KLP transition	2022-10-26 13:19:23 +02:00
locking	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
power	PM: hibernate: Allow hybrid sleep to work with s2idle	2022-11-03 23:52:31 +09:00
printk	printk: fix return value of printk.devkmsg __setup handler	2022-04-15 14:14:45 +02:00
rcu	rcu: Suppress smp_processor_id() complaint in synchronize_rcu_expedited_wait()	2023-03-11 16:31:45 +01:00
sched	sched,idle,rcu: Push rcu_idle deeper into the idle path	2023-10-25 11:16:26 +02:00
time	posix-timers: Ensure timer ID search-loop limit is valid	2023-08-11 11:45:25 +02:00
trace	tracing: relax trace_event_eval_update() execution with cond_resched()	2023-10-25 11:16:55 +02:00
.gitignore
acct.c	acct: fix potential integer overflow in encode_comp_t()	2023-01-18 11:30:34 +01:00
async.c	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
audit.c	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
audit.h	audit: fix a net reference leak in audit_list_rules_send()	2020-06-22 09:05:13 +02:00
audit_fsnotify.c	audit: fix potential double free on error path from fsnotify_add_inode_mark	2022-09-05 10:26:28 +02:00
audit_tree.c	audit: Embed key into chunk	2019-12-13 08:51:11 +01:00
audit_watch.c	audit: CONFIG_CHANGE don't log internal bookkeeping as an event	2020-10-01 13:14:33 +02:00
auditfilter.c	audit: fix a net reference leak in audit_list_rules_send()	2020-06-22 09:05:13 +02:00
auditsc.c	audit: fix possible soft lockup in __audit_inode_child()	2023-09-23 10:48:04 +02:00
backtracetest.c
bounds.c
capability.c	LSM: generalize flag passing to security_capable	2020-01-23 08:21:29 +01:00
compat.c	sched_getaffinity: don't assume 'cpumask_size()' is fully initialized	2023-04-05 11:15:39 +02:00
configs.c
context_tracking.c
cpu.c	random: clear fast pool, crng, and batches in cpuhp bring up	2022-06-25 11:49:07 +02:00
cpu_pm.c	kernel/cpu_pm: Fix uninitted local in cpu_pm	2020-06-22 09:05:28 +02:00
crash_core.c
crash_dump.c
cred.c	memcg: account security cred as well to kmemcg	2020-01-09 10:19:00 +01:00
delayacct.c
dma.c
exec_domain.c
exit.c	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
extable.c	kernel/extable.c: use address-of operator on section symbols	2023-06-09 10:24:02 +02:00
fail_function.c	fail_function: Remove a redundant mutex unlock	2020-11-24 13:27:23 +01:00
fork.c	mm/hugetlb: initialize hugetlb_usage in mm_init	2021-09-22 11:48:09 +02:00
freezer.c
futex.c	treewide: Remove uninitialized_var() usage	2023-08-11 11:45:01 +02:00
groups.c
hung_task.c	kernel: hung_task.c: disable on suspend	2019-04-20 09:16:02 +02:00
iomem.c
irq_work.c	irq_work: Do not raise an IPI when queueing work on the local CPU	2019-05-31 06:46:19 -07:00
jump_label.c	locking/static_key: Fix false positive warnings on concurrent dec/inc	2021-03-04 09:39:30 +01:00
kallsyms.c	kallsyms: Refactor kallsyms_show_value() to take cred	2020-07-16 08:17:26 +02:00
kcmp.c
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kcov.c
kexec.c
kexec_core.c	kexec: fix a memory leak in crash_shrink_memory()	2023-08-11 11:45:06 +02:00
kexec_file.c	kexec: support purgatories with .text.hot sections	2023-06-21 15:39:57 +02:00
kexec_internal.h
kmod.c	kmod: make request_module() return an error when autoloading is disabled	2020-04-17 10:48:52 +02:00
kprobes.c	x86/kprobes: Fix arch_check_optimized_kprobe check within optimized_kprobe range	2023-03-11 16:31:51 +01:00
ksysfs.c
kthread.c	kthread: prevent deadlock when kthread_mod_delayed_work() races with kthread_cancel_delayed_work_sync()	2021-07-11 12:49:31 +02:00
latencytop.c
Makefile	elfcore: fix building with clang	2021-02-10 09:21:06 +01:00
memremap.c	mm/memory_hotplug: shrink zones when offlining memory	2020-01-29 16:43:27 +01:00
module-internal.h
module.c	modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules	2023-09-23 10:47:56 +02:00
module_signing.c
notifier.c	x86/mm: split vmalloc_sync_all()	2020-03-25 08:06:13 +01:00
nsproxy.c
padata.c	padata: add separate cpuhp node for CPUHP_PADATA_DEAD	2021-08-08 08:54:30 +02:00
panic.c	exit: Use READ_ONCE() for all oops/warn limit reads	2023-02-06 07:49:46 +01:00
params.c
pid.c
pid_namespace.c	memcg: enable accounting for pids in nested pid namespaces	2021-09-22 11:48:09 +02:00
profile.c	profiling: fix shift too large makes kernel panic	2022-08-25 11:15:20 +02:00
ptrace.c	ptrace: Reimplement PTRACE_KILL by always sending SIGKILL	2022-06-14 16:59:14 +02:00
range.c
reboot.c	reboot: fix overflow parsing reboot cpu number	2020-11-18 19:18:52 +01:00
relay.c	relayfs: fix out-of-bounds access in relay_file_read	2023-05-17 11:13:23 +02:00
resource.c	resource: fix locking in find_next_iomem_res()	2019-09-16 08:22:20 +02:00
rseq.c
seccomp.c	seccomp: Invalidate seccomp mode to catch death failures	2022-02-16 12:51:47 +01:00
signal.c	signal handling: don't use BUG_ON() for debugging	2022-07-21 21:09:32 +02:00
smp.c	smp: Fix offline cpu check in flush_smp_call_function_queue()	2022-04-20 09:12:50 +02:00
smpboot.c	kthread: Extract KTHREAD_IS_PER_CPU	2021-02-07 14:48:38 +01:00
smpboot.h
softirq.c
stacktrace.c
stop_machine.c
sys.c	prlimit: do_prlimit needs to have a speculation check	2023-01-24 07:11:49 +01:00
sys_ni.c	kernel/sys_ni: add compat entry for fadvise64_64	2022-09-05 10:26:28 +02:00
sysctl.c	proc: proc_skip_spaces() shouldn't think it is working on C strings	2022-12-08 11:18:32 +01:00
sysctl_binary.c
task_work.c
taskstats.c	taskstats: fix data-race	2020-01-09 10:18:59 +01:00
test_kprobes.c
torture.c
tracepoint.c	tracepoint: Add tracepoint_probe_register_may_exist() for BPF tracing	2021-07-20 16:15:42 +02:00
tsacct.c	taskstats: Cleanup the use of task->exit_code	2022-02-23 11:58:39 +01:00
ucount.c
uid16.c
uid16.h
umh.c	usermodehelper: reset umask to default before executing user process	2020-10-14 10:31:21 +02:00
up.c	smp: Fix smp_call_function_single_async prototype	2021-05-22 10:59:39 +02:00
user-return-notifier.c
user.c
user_namespace.c
utsname.c
utsname_sysctl.c
watchdog.c	watchdog: export lockup_detector_reconfigure	2022-08-25 11:15:46 +02:00
watchdog_hld.c	watchdog/perf: more properly prevent false positives with turbo modes	2023-08-11 11:45:06 +02:00
workqueue.c	workqueue: Override implicit ordered attribute in workqueue_apply_unbound_cpumask()	2023-10-25 11:16:26 +02:00
workqueue_internal.h