mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 18:39:59 +00:00
![Tejun Heo](/assets/img/avatar_default.png)
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
187 lines
4.8 KiB
C
187 lines
4.8 KiB
C
/*
|
|
* drivers/input/touchscreen/jornada720_ts.c
|
|
*
|
|
* Copyright (C) 2007 Kristoffer Ericson <Kristoffer.Ericson@gmail.com>
|
|
*
|
|
* Copyright (C) 2006 Filip Zyzniewski <filip.zyzniewski@tefnet.pl>
|
|
* based on HP Jornada 56x touchscreen driver by Alex Lange <chicken@handhelds.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* HP Jornada 710/720/729 Touchscreen Driver
|
|
*/
|
|
|
|
#include <linux/platform_device.h>
|
|
#include <linux/init.h>
|
|
#include <linux/input.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include <mach/hardware.h>
|
|
#include <mach/jornada720.h>
|
|
|
|
MODULE_AUTHOR("Kristoffer Ericson <kristoffer.ericson@gmail.com>");
|
|
MODULE_DESCRIPTION("HP Jornada 710/720/728 touchscreen driver");
|
|
MODULE_LICENSE("GPL v2");
|
|
|
|
struct jornada_ts {
|
|
struct input_dev *dev;
|
|
int x_data[4]; /* X sample values */
|
|
int y_data[4]; /* Y sample values */
|
|
};
|
|
|
|
static void jornada720_ts_collect_data(struct jornada_ts *jornada_ts)
|
|
{
|
|
|
|
/* 3 low word X samples */
|
|
jornada_ts->x_data[0] = jornada_ssp_byte(TXDUMMY);
|
|
jornada_ts->x_data[1] = jornada_ssp_byte(TXDUMMY);
|
|
jornada_ts->x_data[2] = jornada_ssp_byte(TXDUMMY);
|
|
|
|
/* 3 low word Y samples */
|
|
jornada_ts->y_data[0] = jornada_ssp_byte(TXDUMMY);
|
|
jornada_ts->y_data[1] = jornada_ssp_byte(TXDUMMY);
|
|
jornada_ts->y_data[2] = jornada_ssp_byte(TXDUMMY);
|
|
|
|
/* combined x samples bits */
|
|
jornada_ts->x_data[3] = jornada_ssp_byte(TXDUMMY);
|
|
|
|
/* combined y samples bits */
|
|
jornada_ts->y_data[3] = jornada_ssp_byte(TXDUMMY);
|
|
}
|
|
|
|
static int jornada720_ts_average(int coords[4])
|
|
{
|
|
int coord, high_bits = coords[3];
|
|
|
|
coord = coords[0] | ((high_bits & 0x03) << 8);
|
|
coord += coords[1] | ((high_bits & 0x0c) << 6);
|
|
coord += coords[2] | ((high_bits & 0x30) << 4);
|
|
|
|
return coord / 3;
|
|
}
|
|
|
|
static irqreturn_t jornada720_ts_interrupt(int irq, void *dev_id)
|
|
{
|
|
struct platform_device *pdev = dev_id;
|
|
struct jornada_ts *jornada_ts = platform_get_drvdata(pdev);
|
|
struct input_dev *input = jornada_ts->dev;
|
|
int x, y;
|
|
|
|
/* If GPIO_GPIO9 is set to high then report pen up */
|
|
if (GPLR & GPIO_GPIO(9)) {
|
|
input_report_key(input, BTN_TOUCH, 0);
|
|
input_sync(input);
|
|
} else {
|
|
jornada_ssp_start();
|
|
|
|
/* proper reply to request is always TXDUMMY */
|
|
if (jornada_ssp_inout(GETTOUCHSAMPLES) == TXDUMMY) {
|
|
jornada720_ts_collect_data(jornada_ts);
|
|
|
|
x = jornada720_ts_average(jornada_ts->x_data);
|
|
y = jornada720_ts_average(jornada_ts->y_data);
|
|
|
|
input_report_key(input, BTN_TOUCH, 1);
|
|
input_report_abs(input, ABS_X, x);
|
|
input_report_abs(input, ABS_Y, y);
|
|
input_sync(input);
|
|
}
|
|
|
|
jornada_ssp_end();
|
|
}
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int __devinit jornada720_ts_probe(struct platform_device *pdev)
|
|
{
|
|
struct jornada_ts *jornada_ts;
|
|
struct input_dev *input_dev;
|
|
int error;
|
|
|
|
jornada_ts = kzalloc(sizeof(struct jornada_ts), GFP_KERNEL);
|
|
input_dev = input_allocate_device();
|
|
|
|
if (!jornada_ts || !input_dev) {
|
|
error = -ENOMEM;
|
|
goto fail1;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, jornada_ts);
|
|
|
|
jornada_ts->dev = input_dev;
|
|
|
|
input_dev->name = "HP Jornada 7xx Touchscreen";
|
|
input_dev->phys = "jornadats/input0";
|
|
input_dev->id.bustype = BUS_HOST;
|
|
input_dev->dev.parent = &pdev->dev;
|
|
|
|
input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
|
|
input_dev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
|
|
input_set_abs_params(input_dev, ABS_X, 270, 3900, 0, 0);
|
|
input_set_abs_params(input_dev, ABS_Y, 180, 3700, 0, 0);
|
|
|
|
error = request_irq(IRQ_GPIO9,
|
|
jornada720_ts_interrupt,
|
|
IRQF_DISABLED | IRQF_TRIGGER_RISING,
|
|
"HP7XX Touchscreen driver", pdev);
|
|
if (error) {
|
|
printk(KERN_INFO "HP7XX TS : Unable to acquire irq!\n");
|
|
goto fail1;
|
|
}
|
|
|
|
error = input_register_device(jornada_ts->dev);
|
|
if (error)
|
|
goto fail2;
|
|
|
|
return 0;
|
|
|
|
fail2:
|
|
free_irq(IRQ_GPIO9, pdev);
|
|
fail1:
|
|
platform_set_drvdata(pdev, NULL);
|
|
input_free_device(input_dev);
|
|
kfree(jornada_ts);
|
|
return error;
|
|
}
|
|
|
|
static int __devexit jornada720_ts_remove(struct platform_device *pdev)
|
|
{
|
|
struct jornada_ts *jornada_ts = platform_get_drvdata(pdev);
|
|
|
|
free_irq(IRQ_GPIO9, pdev);
|
|
platform_set_drvdata(pdev, NULL);
|
|
input_unregister_device(jornada_ts->dev);
|
|
kfree(jornada_ts);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* work with hotplug and coldplug */
|
|
MODULE_ALIAS("platform:jornada_ts");
|
|
|
|
static struct platform_driver jornada720_ts_driver = {
|
|
.probe = jornada720_ts_probe,
|
|
.remove = __devexit_p(jornada720_ts_remove),
|
|
.driver = {
|
|
.name = "jornada_ts",
|
|
.owner = THIS_MODULE,
|
|
},
|
|
};
|
|
|
|
static int __init jornada720_ts_init(void)
|
|
{
|
|
return platform_driver_register(&jornada720_ts_driver);
|
|
}
|
|
|
|
static void __exit jornada720_ts_exit(void)
|
|
{
|
|
platform_driver_unregister(&jornada720_ts_driver);
|
|
}
|
|
|
|
module_init(jornada720_ts_init);
|
|
module_exit(jornada720_ts_exit);
|