Davide Caratti c137ee44c5 mptcp: don't account accept() of non-MPC client as fallback to TCP ... commit 7a1b3490f4 upstream. Current MPTCP servers increment MPTcpExtMPCapableFallbackACK when they accept non-MPC connections. As reported by Christoph, this is "surprising" because the counter might become greater than MPTcpExtMPCapableSYNRX. MPTcpExtMPCapableFallbackACK counter's name suggests it should only be incremented when a connection was seen using MPTCP options, then a fallback to TCP has been done. Let's do that by incrementing it when the subflow context of an inbound MPC connection attempt is dropped. Also, update mptcp_connect.sh kselftest, to ensure that the above MIB does not increment in case a pure TCP client connects to a MPTCP server. Fixes: fc518953bc ("mptcp: add and use MIB counter infrastructure") Cc: stable@vger.kernel.org Reported-by: Christoph Paasch <cpaasch@apple.com> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/449 Signed-off-by: Davide Caratti <dcaratti@redhat.com> Reviewed-by: Mat Martineau <martineau@kernel.org> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Link: https://lore.kernel.org/r/20240329-upstream-net-20240329-fallback-mib-v1-1-324a8981da48@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-04-13 12:59:38 +02:00
..
crypto.c
crypto_test.c
ctrl.c
diag.c	mptcp: fix possible deadlock in subflow diag	2024-03-06 14:37:50 +00:00
Kconfig
Makefile
mib.c
mib.h
mptcp_diag.c	mptcp: don't return sockets in foreign netns	2021-10-06 15:55:52 +02:00
options.c	mptcp: fix uninit-value in mptcp_incoming_options	2024-01-25 14:37:35 -08:00
pm.c
pm_netlink.c
protocol.c	mptcp: don't account accept() of non-MPC client as fallback to TCP	2024-04-13 12:59:38 +02:00
protocol.h	mptcp: don't return sockets in foreign netns	2021-10-06 15:55:52 +02:00
subflow.c	mptcp: don't account accept() of non-MPC client as fallback to TCP	2024-04-13 12:59:38 +02:00
syncookies.c	mptcp: don't return sockets in foreign netns	2021-10-06 15:55:52 +02:00
token.c	mptcp: don't return sockets in foreign netns	2021-10-06 15:55:52 +02:00
token_test.c	mptcp: don't return sockets in foreign netns	2021-10-06 15:55:52 +02:00