mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 18:09:57 +00:00
![Willem de Bruijn](/assets/img/avatar_default.png)
Tuntap and similar devices can inject GSO packets. Accept type VIRTIO_NET_HDR_GSO_UDP, even though not generating UFO natively. Processes are expected to use feature negotiation such as TUNSETOFFLOAD to detect supported offload types and refrain from injecting other packets. This process breaks down with live migration: guest kernels do not renegotiate flags, so destination hosts need to expose all features that the source host does. Partially revert the UFO removal from 182e0b6b5846~1..d9d30adf5677. This patch introduces nearly(*) no new code to simplify verification. It brings back verbatim tuntap UFO negotiation, VIRTIO_NET_HDR_GSO_UDP insertion and software UFO segmentation. It does not reinstate protocol stack support, hardware offload (NETIF_F_UFO), SKB_GSO_UDP tunneling in SKB_GSO_SOFTWARE or reception of VIRTIO_NET_HDR_GSO_UDP packets in tuntap. To support SKB_GSO_UDP reappearing in the stack, also reinstate logic in act_csum and openvswitch. Achieve equivalence with v4.13 HEAD by squashing in commit939912216f
("net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx.") and reverting commit8d63bee643
("net: avoid skb_warn_bad_offload false positives on UFO"). (*) To avoid having to bring back skb_shinfo(skb)->ip6_frag_id, ipv6_proxy_select_ident is changed to return a __be32 and this is assigned directly to the frag_hdr. Also, SKB_GSO_UDP is inserted at the end of the enum to minimize code churn. Tested Booted a v4.13 guest kernel with QEMU. On a host kernel before this patch `ethtool -k eth0` shows UFO disabled. After the patch, it is enabled, same as on a v4.13 host kernel. A UFO packet sent from the guest appears on the tap device: host: nc -l -p -u 8000 & tcpdump -n -i tap0 guest: dd if=/dev/zero of=payload.txt bs=1 count=2000 nc -u 192.16.1.1 8000 < payload.txt Direct tap to tap transmission of VIRTIO_NET_HDR_GSO_UDP succeeds, packets arriving fragmented: ./with_tap_pair.sh ./tap_send_ufo tap0 tap1 (from https://github.com/wdebruij/kerneltools/tree/master/tests) Changes v1 -> v2 - simplified set_offload change (review comment) - documented test procedure Link: http://lkml.kernel.org/r/<CAF=yD-LuUeDuL9YWPJD9ykOZ0QCjNeznPDr6whqZ9NGMNF12Mw@mail.gmail.com> Fixes:fb652fdfe8
("macvlan/macvtap: Remove NETIF_F_UFO advertisement.") Reported-by: Michal Kubecek <mkubecek@suse.cz> Signed-off-by: Willem de Bruijn <willemb@google.com> Acked-by: Jason Wang <jasowang@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
217 lines
8.8 KiB
C
217 lines
8.8 KiB
C
/*
|
|
* Network device features.
|
|
*
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*/
|
|
#ifndef _LINUX_NETDEV_FEATURES_H
|
|
#define _LINUX_NETDEV_FEATURES_H
|
|
|
|
#include <linux/types.h>
|
|
|
|
typedef u64 netdev_features_t;
|
|
|
|
enum {
|
|
NETIF_F_SG_BIT, /* Scatter/gather IO. */
|
|
NETIF_F_IP_CSUM_BIT, /* Can checksum TCP/UDP over IPv4. */
|
|
__UNUSED_NETIF_F_1,
|
|
NETIF_F_HW_CSUM_BIT, /* Can checksum all the packets. */
|
|
NETIF_F_IPV6_CSUM_BIT, /* Can checksum TCP/UDP over IPV6 */
|
|
NETIF_F_HIGHDMA_BIT, /* Can DMA to high memory. */
|
|
NETIF_F_FRAGLIST_BIT, /* Scatter/gather IO. */
|
|
NETIF_F_HW_VLAN_CTAG_TX_BIT, /* Transmit VLAN CTAG HW acceleration */
|
|
NETIF_F_HW_VLAN_CTAG_RX_BIT, /* Receive VLAN CTAG HW acceleration */
|
|
NETIF_F_HW_VLAN_CTAG_FILTER_BIT,/* Receive filtering on VLAN CTAGs */
|
|
NETIF_F_VLAN_CHALLENGED_BIT, /* Device cannot handle VLAN packets */
|
|
NETIF_F_GSO_BIT, /* Enable software GSO. */
|
|
NETIF_F_LLTX_BIT, /* LockLess TX - deprecated. Please */
|
|
/* do not use LLTX in new drivers */
|
|
NETIF_F_NETNS_LOCAL_BIT, /* Does not change network namespaces */
|
|
NETIF_F_GRO_BIT, /* Generic receive offload */
|
|
NETIF_F_LRO_BIT, /* large receive offload */
|
|
|
|
/**/NETIF_F_GSO_SHIFT, /* keep the order of SKB_GSO_* bits */
|
|
NETIF_F_TSO_BIT /* ... TCPv4 segmentation */
|
|
= NETIF_F_GSO_SHIFT,
|
|
NETIF_F_GSO_ROBUST_BIT, /* ... ->SKB_GSO_DODGY */
|
|
NETIF_F_TSO_ECN_BIT, /* ... TCP ECN support */
|
|
NETIF_F_TSO_MANGLEID_BIT, /* ... IPV4 ID mangling allowed */
|
|
NETIF_F_TSO6_BIT, /* ... TCPv6 segmentation */
|
|
NETIF_F_FSO_BIT, /* ... FCoE segmentation */
|
|
NETIF_F_GSO_GRE_BIT, /* ... GRE with TSO */
|
|
NETIF_F_GSO_GRE_CSUM_BIT, /* ... GRE with csum with TSO */
|
|
NETIF_F_GSO_IPXIP4_BIT, /* ... IP4 or IP6 over IP4 with TSO */
|
|
NETIF_F_GSO_IPXIP6_BIT, /* ... IP4 or IP6 over IP6 with TSO */
|
|
NETIF_F_GSO_UDP_TUNNEL_BIT, /* ... UDP TUNNEL with TSO */
|
|
NETIF_F_GSO_UDP_TUNNEL_CSUM_BIT,/* ... UDP TUNNEL with TSO & CSUM */
|
|
NETIF_F_GSO_PARTIAL_BIT, /* ... Only segment inner-most L4
|
|
* in hardware and all other
|
|
* headers in software.
|
|
*/
|
|
NETIF_F_GSO_TUNNEL_REMCSUM_BIT, /* ... TUNNEL with TSO & REMCSUM */
|
|
NETIF_F_GSO_SCTP_BIT, /* ... SCTP fragmentation */
|
|
NETIF_F_GSO_ESP_BIT, /* ... ESP with TSO */
|
|
NETIF_F_GSO_UDP_BIT, /* ... UFO, deprecated except tuntap */
|
|
/**/NETIF_F_GSO_LAST = /* last bit, see GSO_MASK */
|
|
NETIF_F_GSO_UDP_BIT,
|
|
|
|
NETIF_F_FCOE_CRC_BIT, /* FCoE CRC32 */
|
|
NETIF_F_SCTP_CRC_BIT, /* SCTP checksum offload */
|
|
NETIF_F_FCOE_MTU_BIT, /* Supports max FCoE MTU, 2158 bytes*/
|
|
NETIF_F_NTUPLE_BIT, /* N-tuple filters supported */
|
|
NETIF_F_RXHASH_BIT, /* Receive hashing offload */
|
|
NETIF_F_RXCSUM_BIT, /* Receive checksumming offload */
|
|
NETIF_F_NOCACHE_COPY_BIT, /* Use no-cache copyfromuser */
|
|
NETIF_F_LOOPBACK_BIT, /* Enable loopback */
|
|
NETIF_F_RXFCS_BIT, /* Append FCS to skb pkt data */
|
|
NETIF_F_RXALL_BIT, /* Receive errored frames too */
|
|
NETIF_F_HW_VLAN_STAG_TX_BIT, /* Transmit VLAN STAG HW acceleration */
|
|
NETIF_F_HW_VLAN_STAG_RX_BIT, /* Receive VLAN STAG HW acceleration */
|
|
NETIF_F_HW_VLAN_STAG_FILTER_BIT,/* Receive filtering on VLAN STAGs */
|
|
NETIF_F_HW_L2FW_DOFFLOAD_BIT, /* Allow L2 Forwarding in Hardware */
|
|
|
|
NETIF_F_HW_TC_BIT, /* Offload TC infrastructure */
|
|
NETIF_F_HW_ESP_BIT, /* Hardware ESP transformation offload */
|
|
NETIF_F_HW_ESP_TX_CSUM_BIT, /* ESP with TX checksum offload */
|
|
NETIF_F_RX_UDP_TUNNEL_PORT_BIT, /* Offload of RX port for UDP tunnels */
|
|
|
|
/*
|
|
* Add your fresh new feature above and remember to update
|
|
* netdev_features_strings[] in net/core/ethtool.c and maybe
|
|
* some feature mask #defines below. Please also describe it
|
|
* in Documentation/networking/netdev-features.txt.
|
|
*/
|
|
|
|
/**/NETDEV_FEATURE_COUNT
|
|
};
|
|
|
|
/* copy'n'paste compression ;) */
|
|
#define __NETIF_F_BIT(bit) ((netdev_features_t)1 << (bit))
|
|
#define __NETIF_F(name) __NETIF_F_BIT(NETIF_F_##name##_BIT)
|
|
|
|
#define NETIF_F_FCOE_CRC __NETIF_F(FCOE_CRC)
|
|
#define NETIF_F_FCOE_MTU __NETIF_F(FCOE_MTU)
|
|
#define NETIF_F_FRAGLIST __NETIF_F(FRAGLIST)
|
|
#define NETIF_F_FSO __NETIF_F(FSO)
|
|
#define NETIF_F_GRO __NETIF_F(GRO)
|
|
#define NETIF_F_GSO __NETIF_F(GSO)
|
|
#define NETIF_F_GSO_ROBUST __NETIF_F(GSO_ROBUST)
|
|
#define NETIF_F_HIGHDMA __NETIF_F(HIGHDMA)
|
|
#define NETIF_F_HW_CSUM __NETIF_F(HW_CSUM)
|
|
#define NETIF_F_HW_VLAN_CTAG_FILTER __NETIF_F(HW_VLAN_CTAG_FILTER)
|
|
#define NETIF_F_HW_VLAN_CTAG_RX __NETIF_F(HW_VLAN_CTAG_RX)
|
|
#define NETIF_F_HW_VLAN_CTAG_TX __NETIF_F(HW_VLAN_CTAG_TX)
|
|
#define NETIF_F_IP_CSUM __NETIF_F(IP_CSUM)
|
|
#define NETIF_F_IPV6_CSUM __NETIF_F(IPV6_CSUM)
|
|
#define NETIF_F_LLTX __NETIF_F(LLTX)
|
|
#define NETIF_F_LOOPBACK __NETIF_F(LOOPBACK)
|
|
#define NETIF_F_LRO __NETIF_F(LRO)
|
|
#define NETIF_F_NETNS_LOCAL __NETIF_F(NETNS_LOCAL)
|
|
#define NETIF_F_NOCACHE_COPY __NETIF_F(NOCACHE_COPY)
|
|
#define NETIF_F_NTUPLE __NETIF_F(NTUPLE)
|
|
#define NETIF_F_RXCSUM __NETIF_F(RXCSUM)
|
|
#define NETIF_F_RXHASH __NETIF_F(RXHASH)
|
|
#define NETIF_F_SCTP_CRC __NETIF_F(SCTP_CRC)
|
|
#define NETIF_F_SG __NETIF_F(SG)
|
|
#define NETIF_F_TSO6 __NETIF_F(TSO6)
|
|
#define NETIF_F_TSO_ECN __NETIF_F(TSO_ECN)
|
|
#define NETIF_F_TSO __NETIF_F(TSO)
|
|
#define NETIF_F_VLAN_CHALLENGED __NETIF_F(VLAN_CHALLENGED)
|
|
#define NETIF_F_RXFCS __NETIF_F(RXFCS)
|
|
#define NETIF_F_RXALL __NETIF_F(RXALL)
|
|
#define NETIF_F_GSO_GRE __NETIF_F(GSO_GRE)
|
|
#define NETIF_F_GSO_GRE_CSUM __NETIF_F(GSO_GRE_CSUM)
|
|
#define NETIF_F_GSO_IPXIP4 __NETIF_F(GSO_IPXIP4)
|
|
#define NETIF_F_GSO_IPXIP6 __NETIF_F(GSO_IPXIP6)
|
|
#define NETIF_F_GSO_UDP_TUNNEL __NETIF_F(GSO_UDP_TUNNEL)
|
|
#define NETIF_F_GSO_UDP_TUNNEL_CSUM __NETIF_F(GSO_UDP_TUNNEL_CSUM)
|
|
#define NETIF_F_TSO_MANGLEID __NETIF_F(TSO_MANGLEID)
|
|
#define NETIF_F_GSO_PARTIAL __NETIF_F(GSO_PARTIAL)
|
|
#define NETIF_F_GSO_TUNNEL_REMCSUM __NETIF_F(GSO_TUNNEL_REMCSUM)
|
|
#define NETIF_F_GSO_SCTP __NETIF_F(GSO_SCTP)
|
|
#define NETIF_F_GSO_ESP __NETIF_F(GSO_ESP)
|
|
#define NETIF_F_GSO_UDP __NETIF_F(GSO_UDP)
|
|
#define NETIF_F_HW_VLAN_STAG_FILTER __NETIF_F(HW_VLAN_STAG_FILTER)
|
|
#define NETIF_F_HW_VLAN_STAG_RX __NETIF_F(HW_VLAN_STAG_RX)
|
|
#define NETIF_F_HW_VLAN_STAG_TX __NETIF_F(HW_VLAN_STAG_TX)
|
|
#define NETIF_F_HW_L2FW_DOFFLOAD __NETIF_F(HW_L2FW_DOFFLOAD)
|
|
#define NETIF_F_HW_TC __NETIF_F(HW_TC)
|
|
#define NETIF_F_HW_ESP __NETIF_F(HW_ESP)
|
|
#define NETIF_F_HW_ESP_TX_CSUM __NETIF_F(HW_ESP_TX_CSUM)
|
|
#define NETIF_F_RX_UDP_TUNNEL_PORT __NETIF_F(RX_UDP_TUNNEL_PORT)
|
|
|
|
#define for_each_netdev_feature(mask_addr, bit) \
|
|
for_each_set_bit(bit, (unsigned long *)mask_addr, NETDEV_FEATURE_COUNT)
|
|
|
|
/* Features valid for ethtool to change */
|
|
/* = all defined minus driver/device-class-related */
|
|
#define NETIF_F_NEVER_CHANGE (NETIF_F_VLAN_CHALLENGED | \
|
|
NETIF_F_LLTX | NETIF_F_NETNS_LOCAL)
|
|
|
|
/* remember that ((t)1 << t_BITS) is undefined in C99 */
|
|
#define NETIF_F_ETHTOOL_BITS ((__NETIF_F_BIT(NETDEV_FEATURE_COUNT - 1) | \
|
|
(__NETIF_F_BIT(NETDEV_FEATURE_COUNT - 1) - 1)) & \
|
|
~NETIF_F_NEVER_CHANGE)
|
|
|
|
/* Segmentation offload feature mask */
|
|
#define NETIF_F_GSO_MASK (__NETIF_F_BIT(NETIF_F_GSO_LAST + 1) - \
|
|
__NETIF_F_BIT(NETIF_F_GSO_SHIFT))
|
|
|
|
/* List of IP checksum features. Note that NETIF_F_ HW_CSUM should not be
|
|
* set in features when NETIF_F_IP_CSUM or NETIF_F_IPV6_CSUM are set--
|
|
* this would be contradictory
|
|
*/
|
|
#define NETIF_F_CSUM_MASK (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | \
|
|
NETIF_F_HW_CSUM)
|
|
|
|
#define NETIF_F_ALL_TSO (NETIF_F_TSO | NETIF_F_TSO6 | \
|
|
NETIF_F_TSO_ECN | NETIF_F_TSO_MANGLEID)
|
|
|
|
#define NETIF_F_ALL_FCOE (NETIF_F_FCOE_CRC | NETIF_F_FCOE_MTU | \
|
|
NETIF_F_FSO)
|
|
|
|
/* List of features with software fallbacks. */
|
|
#define NETIF_F_GSO_SOFTWARE (NETIF_F_ALL_TSO | \
|
|
NETIF_F_GSO_SCTP)
|
|
|
|
/*
|
|
* If one device supports one of these features, then enable them
|
|
* for all in netdev_increment_features.
|
|
*/
|
|
#define NETIF_F_ONE_FOR_ALL (NETIF_F_GSO_SOFTWARE | NETIF_F_GSO_ROBUST | \
|
|
NETIF_F_SG | NETIF_F_HIGHDMA | \
|
|
NETIF_F_FRAGLIST | NETIF_F_VLAN_CHALLENGED)
|
|
|
|
/*
|
|
* If one device doesn't support one of these features, then disable it
|
|
* for all in netdev_increment_features.
|
|
*/
|
|
#define NETIF_F_ALL_FOR_ALL (NETIF_F_NOCACHE_COPY | NETIF_F_FSO)
|
|
|
|
/*
|
|
* If upper/master device has these features disabled, they must be disabled
|
|
* on all lower/slave devices as well.
|
|
*/
|
|
#define NETIF_F_UPPER_DISABLES NETIF_F_LRO
|
|
|
|
/* changeable features with no special hardware requirements */
|
|
#define NETIF_F_SOFT_FEATURES (NETIF_F_GSO | NETIF_F_GRO)
|
|
|
|
#define NETIF_F_VLAN_FEATURES (NETIF_F_HW_VLAN_CTAG_FILTER | \
|
|
NETIF_F_HW_VLAN_CTAG_RX | \
|
|
NETIF_F_HW_VLAN_CTAG_TX | \
|
|
NETIF_F_HW_VLAN_STAG_FILTER | \
|
|
NETIF_F_HW_VLAN_STAG_RX | \
|
|
NETIF_F_HW_VLAN_STAG_TX)
|
|
|
|
#define NETIF_F_GSO_ENCAP_ALL (NETIF_F_GSO_GRE | \
|
|
NETIF_F_GSO_GRE_CSUM | \
|
|
NETIF_F_GSO_IPXIP4 | \
|
|
NETIF_F_GSO_IPXIP6 | \
|
|
NETIF_F_GSO_UDP_TUNNEL | \
|
|
NETIF_F_GSO_UDP_TUNNEL_CSUM)
|
|
|
|
#endif /* _LINUX_NETDEV_FEATURES_H */
|