mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
e5f3155267
The 'imply' keyword does not do what most people think it does, it only
politely asks Kconfig to turn on another symbol, but does not prevent
it from being disabled manually or built as a loadable module when the
user is built-in. In the ICE driver, the latter now causes a link failure:
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_eth_ioctl':
ice_main.c:(.text+0x13b0): undefined reference to `ice_ptp_get_ts_config'
ice_main.c:(.text+0x13b0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_get_ts_config'
aarch64-linux-ld: ice_main.c:(.text+0x13bc): undefined reference to `ice_ptp_set_ts_config'
ice_main.c:(.text+0x13bc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_set_ts_config'
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_prepare_for_reset':
ice_main.c:(.text+0x31fc): undefined reference to `ice_ptp_release'
ice_main.c:(.text+0x31fc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_release'
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_rebuild':
This is a recurring problem in many drivers, and we have discussed
it several times befores, without reaching a consensus. I'm providing
a link to the previous email thread for reference, which discusses
some related problems.
To solve the dependency issue better than the 'imply' keyword, introduce a
separate Kconfig symbol "CONFIG_PTP_1588_CLOCK_OPTIONAL" that any driver
can depend on if it is able to use PTP support when available, but works
fine without it. Whenever CONFIG_PTP_1588_CLOCK=m, those drivers are
then prevented from being built-in, the same way as with a 'depends on
PTP_1588_CLOCK || !PTP_1588_CLOCK' dependency that does the same trick,
but that can be rather confusing when you first see it.
Since this should cover the dependencies correctly, the IS_REACHABLE()
hack in the header is no longer needed now, and can be turned back
into a normal IS_ENABLED() check. Any driver that gets the dependency
wrong will now cause a link time failure rather than being unable to use
PTP support when that is in a loadable module.
However, the two recently added ptp_get_vclocks_index() and
ptp_convert_timestamp() interfaces are only called from builtin code with
ethtool and socket timestamps, so keep the current behavior by stubbing
those out completely when PTP is in a loadable module. This should be
addressed properly in a follow-up.
As Richard suggested, we may want to actually turn PTP support into a
'bool' option later on, preventing it from being a loadable module
altogether, which would be one way to solve the problem with the ethtool
interface.
Fixes: 06c16d89d2 ("ice: register 1588 PTP clock device object for E810 devices")
Link: https://lore.kernel.org/netdev/20210804121318.337276-1-arnd@kernel.org/
Link: https://lore.kernel.org/netdev/CAK8P3a06enZOf=XyZ+zcAwBczv41UuCTz+=0FMf2gBz1_cOnZQ@mail.gmail.com/
Link: https://lore.kernel.org/netdev/CAK8P3a3=eOxE-K25754+fB_-i_0BZzf9a9RfPTX3ppSwu9WZXw@mail.gmail.com/
Link: https://lore.kernel.org/netdev/20210726084540.3282344-1-arnd@kernel.org/
Acked-by: Shannon Nelson <snelson@pensando.io>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210812183509.1362782-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
103 lines
3 KiB
Text
103 lines
3 KiB
Text
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
# Cavium ethernet device configuration
|
|
#
|
|
|
|
config NET_VENDOR_CAVIUM
|
|
bool "Cavium ethernet drivers"
|
|
default y
|
|
help
|
|
Select this option if you want enable Cavium network support.
|
|
|
|
If you have a Cavium SoC or network adapter, say Y.
|
|
|
|
if NET_VENDOR_CAVIUM
|
|
|
|
config THUNDER_NIC_PF
|
|
tristate "Thunder Physical function driver"
|
|
depends on 64BIT && PCI
|
|
select THUNDER_NIC_BGX
|
|
help
|
|
This driver supports Thunder's NIC physical function.
|
|
The NIC provides the controller and DMA engines to
|
|
move network traffic to/from the memory. The NIC
|
|
works closely with TNS, BGX and SerDes to implement the
|
|
functions replacing and virtualizing those of a typical
|
|
standalone PCIe NIC chip.
|
|
|
|
config THUNDER_NIC_VF
|
|
tristate "Thunder Virtual function driver"
|
|
imply CAVIUM_PTP
|
|
depends on 64BIT && PCI
|
|
help
|
|
This driver supports Thunder's NIC virtual function
|
|
|
|
config THUNDER_NIC_BGX
|
|
tristate "Thunder MAC interface driver (BGX)"
|
|
depends on 64BIT && PCI
|
|
select PHYLIB
|
|
select MDIO_THUNDER if PCI
|
|
select THUNDER_NIC_RGX
|
|
help
|
|
This driver supports programming and controlling of MAC
|
|
interface from NIC physical function driver.
|
|
|
|
config THUNDER_NIC_RGX
|
|
tristate "Thunder MAC interface driver (RGX)"
|
|
depends on 64BIT && PCI
|
|
select PHYLIB
|
|
select MDIO_THUNDER if PCI
|
|
help
|
|
This driver supports configuring XCV block of RGX interface
|
|
present on CN81XX chip.
|
|
|
|
config CAVIUM_PTP
|
|
tristate "Cavium PTP coprocessor as PTP clock"
|
|
depends on 64BIT && PCI
|
|
depends on PTP_1588_CLOCK
|
|
help
|
|
This driver adds support for the Precision Time Protocol Clocks and
|
|
Timestamping coprocessor (PTP) found on Cavium processors.
|
|
PTP provides timestamping mechanism that is suitable for use in IEEE 1588
|
|
Precision Time Protocol or other purposes. Timestamps can be used in
|
|
BGX, TNS, GTI, and NIC blocks.
|
|
|
|
config LIQUIDIO
|
|
tristate "Cavium LiquidIO support"
|
|
depends on 64BIT && PCI
|
|
depends on PCI
|
|
depends on PTP_1588_CLOCK_OPTIONAL
|
|
select FW_LOADER
|
|
select LIBCRC32C
|
|
select NET_DEVLINK
|
|
help
|
|
This driver supports Cavium LiquidIO Intelligent Server Adapters
|
|
based on CN66XX, CN68XX and CN23XX chips.
|
|
|
|
To compile this driver as a module, choose M here: the module
|
|
will be called liquidio. This is recommended.
|
|
|
|
config OCTEON_MGMT_ETHERNET
|
|
tristate "Octeon Management port ethernet driver (CN5XXX, CN6XXX)"
|
|
depends on CAVIUM_OCTEON_SOC
|
|
select PHYLIB
|
|
select MDIO_OCTEON
|
|
default y
|
|
help
|
|
Enable the ethernet driver for the management
|
|
port on Cavium Networks' Octeon CN57XX, CN56XX, CN55XX,
|
|
CN54XX, CN52XX, and CN6XXX chips.
|
|
|
|
config LIQUIDIO_VF
|
|
tristate "Cavium LiquidIO VF support"
|
|
depends on 64BIT && PCI_MSI
|
|
depends on PTP_1588_CLOCK_OPTIONAL
|
|
help
|
|
This driver supports Cavium LiquidIO Intelligent Server Adapter
|
|
based on CN23XX chips.
|
|
|
|
To compile this driver as a module, choose M here: The module
|
|
will be called liquidio_vf. MSI-X interrupt support is required
|
|
for this driver to work correctly
|
|
|
|
endif # NET_VENDOR_CAVIUM
|