mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
45b102dd81
The MANA driver causes a build failure in some configurations when
it selects an unavailable symbol:
WARNING: unmet direct dependencies detected for PCI_HYPERV
Depends on [n]: PCI [=y] && X86_64 [=y] && HYPERV [=n] && PCI_MSI [=y] && PCI_MSI_IRQ_DOMAIN [=y] && SYSFS [=y]
Selected by [y]:
- MICROSOFT_MANA [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROSOFT [=y] && PCI_MSI [=y] && X86_64 [=y]
drivers/pci/controller/pci-hyperv.c: In function 'hv_irq_unmask':
drivers/pci/controller/pci-hyperv.c:1217:9: error: implicit declaration of function 'hv_set_msi_entry_from_desc' [-Werror=implicit-function-declaration]
1217 | hv_set_msi_entry_from_desc(¶ms->int_entry.msi_entry, msi_desc);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
A PCI driver should never depend on a particular host bridge
implementation in the first place, but if we have this dependency
it's better to express it as a 'depends on' rather than 'select'.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
29 lines
873 B
Text
29 lines
873 B
Text
#
|
|
# Microsoft Azure network device configuration
|
|
#
|
|
|
|
config NET_VENDOR_MICROSOFT
|
|
bool "Microsoft Network Devices"
|
|
default y
|
|
help
|
|
If you have a network (Ethernet) device belonging to this class, say Y.
|
|
|
|
Note that the answer to this question doesn't directly affect the
|
|
kernel: saying N will just cause the configurator to skip the
|
|
question about Microsoft network devices. If you say Y, you will be
|
|
asked for your specific device in the following question.
|
|
|
|
if NET_VENDOR_MICROSOFT
|
|
|
|
config MICROSOFT_MANA
|
|
tristate "Microsoft Azure Network Adapter (MANA) support"
|
|
depends on PCI_MSI && X86_64
|
|
depends on PCI_HYPERV
|
|
help
|
|
This driver supports Microsoft Azure Network Adapter (MANA).
|
|
So far, the driver is only supported on X86_64.
|
|
|
|
To compile this driver as a module, choose M here.
|
|
The module will be called mana.
|
|
|
|
endif #NET_VENDOR_MICROSOFT
|