Jiong Wang 0bae2d4d62 bpf: correct slot_type marking logic to allow more stack slot sharing ... Verifier is supposed to support sharing stack slot allocated to ptr with SCALAR_VALUE for privileged program. However this doesn't happen for some cases. The reason is verifier is not clearing slot_type STACK_SPILL for all bytes, it only clears part of them, while verifier is using: slot_type[0] == STACK_SPILL as a convention to check one slot is ptr type. So, the consequence of partial clearing slot_type is verifier could treat a partially overridden ptr slot, which should now be a SCALAR_VALUE slot, still as ptr slot, and rejects some valid programs. Before this patch, test_xdp_noinline.o under bpf selftests, bpf_lxc.o and bpf_netdev.o under Cilium bpf repo, when built with -mattr=+alu32 are rejected due to this issue. After this patch, they all accepted. There is no processed insn number change before and after this patch on Cilium bpf programs. Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: Jiong Wang <jiong.wang@netronome.com> Reviewed-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Alexei Starovoitov <ast@kernel.org>		2018-12-18 14:45:01 -08:00
..
arraymap.c	bpf: pass struct btf pointer to the map_check_btf() callback	2018-12-12 15:33:33 -08:00
bpf_lru_list.c	bpf: lru: Lower the PERCPU_NR_SCANS from 16 to 4	2017-04-17 13:55:52 -04:00
bpf_lru_list.h	bpf: Only set node->ref = 1 if it has not been set	2017-09-01 09:57:39 -07:00
btf.c	bpf: enable cgroup local storage map pretty print with kind_flag	2018-12-18 01:11:59 +01:00
cgroup.c	bpf: add cg_skb_is_valid_access for BPF_PROG_TYPE_CGROUP_SKB	2018-10-19 13:49:34 -07:00
core.c	bpf: Add bpf_line_info support	2018-12-09 13:54:38 -08:00
cpumap.c	bpf: fix redirect to map under tail calls	2018-08-17 15:56:23 -07:00
devmap.c	bpf: devmap: fix wrong interface selection in notifier_call	2018-10-26 00:32:21 +02:00
disasm.c	bpf: Remove struct bpf_verifier_env argument from print_bpf_insn	2018-03-23 17:38:57 +01:00
disasm.h	bpf: Remove struct bpf_verifier_env argument from print_bpf_insn	2018-03-23 17:38:57 +01:00
hashtab.c	bpf: allow zero-initializing hash map seed	2018-11-20 00:53:39 +01:00
helpers.c	bpf: fix direct packet write into pop/peek helpers	2018-10-25 17:02:06 -07:00
inode.c	bpf: decouple btf from seq bpf fs dump and enable more maps	2018-08-13 00:52:45 +02:00
local_storage.c	bpf: enable cgroup local storage map pretty print with kind_flag	2018-12-18 01:11:59 +01:00
lpm_trie.c	bpf: pass struct btf pointer to the map_check_btf() callback	2018-12-12 15:33:33 -08:00
Makefile	bpf: add queue and stack maps	2018-10-19 13:24:31 -07:00
map_in_map.c	bpf: don't allow create maps of per-cpu cgroup local storages	2018-10-01 16:18:33 +02:00
map_in_map.h	bpf: Add syscall lookup support for fd array and htab	2017-06-29 13:13:25 -04:00
offload.c	bpf: fix null pointer dereference on pointer offload	2018-11-16 20:48:27 -08:00
percpu_freelist.c	bpf: fix lockdep splat	2017-11-15 19:46:32 +09:00
percpu_freelist.h	bpf: introduce percpu_freelist	2016-03-08 15:28:31 -05:00
queue_stack_maps.c	bpf: fix integer overflow in queue_stack_map	2018-11-22 21:29:40 +01:00
reuseport_array.c	bpf: Introduce BPF_MAP_TYPE_REUSEPORT_SOCKARRAY	2018-08-11 01:58:46 +02:00
stackmap.c	bpf: rename stack trace map operations	2018-10-19 13:24:30 -07:00
syscall.c	bpf: support raw tracepoints in modules	2018-12-18 14:08:12 -08:00
tnum.c	bpf/verifier: improve register value range tracking with ARSH	2018-04-29 08:45:53 -07:00
verifier.c	bpf: correct slot_type marking logic to allow more stack slot sharing	2018-12-18 14:45:01 -08:00
xskmap.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-19 11:03:06 -07:00