Filipe Manana 0bb7883009 btrfs: fix sleep while in non-sleep context during qgroup removal ... While removing a qgroup's sysfs entry we end up taking the kernfs_mutex, through kobject_del(), while holding the fs_info->qgroup_lock spinlock, producing the following trace: [821.843637] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:281 [821.843641] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 28214, name: podman [821.843644] CPU: 3 PID: 28214 Comm: podman Tainted: G W 5.11.6 #15 [821.843646] Hardware name: Dell Inc. PowerEdge R330/084XW4, BIOS 2.11.0 12/08/2020 [821.843647] Call Trace: [821.843650] dump_stack+0xa1/0xfb [821.843656] ___might_sleep+0x144/0x160 [821.843659] mutex_lock+0x17/0x40 [821.843662] kernfs_remove_by_name_ns+0x1f/0x80 [821.843666] sysfs_remove_group+0x7d/0xe0 [821.843668] sysfs_remove_groups+0x28/0x40 [821.843670] kobject_del+0x2a/0x80 [821.843672] btrfs_sysfs_del_one_qgroup+0x2b/0x40 [btrfs] [821.843685] __del_qgroup_rb+0x12/0x150 [btrfs] [821.843696] btrfs_remove_qgroup+0x288/0x2a0 [btrfs] [821.843707] btrfs_ioctl+0x3129/0x36a0 [btrfs] [821.843717] ? __mod_lruvec_page_state+0x5e/0xb0 [821.843719] ? page_add_new_anon_rmap+0xbc/0x150 [821.843723] ? kfree+0x1b4/0x300 [821.843725] ? mntput_no_expire+0x55/0x330 [821.843728] __x64_sys_ioctl+0x5a/0xa0 [821.843731] do_syscall_64+0x33/0x70 [821.843733] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [821.843736] RIP: 0033:0x4cd3fb [821.843741] RSP: 002b:000000c000906b20 EFLAGS: 00000206 ORIG_RAX: 0000000000000010 [821.843744] RAX: ffffffffffffffda RBX: 000000c000050000 RCX: 00000000004cd3fb [821.843745] RDX: 000000c000906b98 RSI: 000000004010942a RDI: 000000000000000f [821.843747] RBP: 000000c000907cd0 R08: 000000c000622901 R09: 0000000000000000 [821.843748] R10: 000000c000d992c0 R11: 0000000000000206 R12: 000000000000012d [821.843749] R13: 000000000000012c R14: 0000000000000200 R15: 0000000000000049 Fix this by removing the qgroup sysfs entry while not holding the spinlock, since the spinlock is only meant for protection of the qgroup rbtree. Reported-by: Stuart Shelton <srcshelton@gmail.com> Link: https://lore.kernel.org/linux-btrfs/7A5485BB-0628-419D-A4D3-27B1AF47E25A@gmail.com/ Fixes: 49e5fb4621 ("btrfs: qgroup: export qgroups in sysfs") CC: stable@vger.kernel.org # 5.10+ Reviewed-by: Qu Wenruo <wqu@suse.com> Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>		2021-03-18 16:53:24 +01:00
..
tests	btrfs: extend btrfs_rmap_block for specifying a device	2021-02-09 02:46:05 +01:00
acl.c
async-thread.c	Btrfs: fix crash during unmount due to race with delayed inode workers	2020-03-23 17:01:51 +01:00
async-thread.h	Btrfs: fix crash during unmount due to race with delayed inode workers	2020-03-23 17:01:51 +01:00
backref.c	btrfs: do not warn if we can't find the reloc root when looking up backref	2021-02-08 22:58:56 +01:00
backref.h	btrfs: add asserts for deleting backref cache nodes	2021-02-08 22:58:56 +01:00
block-group.c	btrfs: fix race between writes to swap files and scrub	2021-02-22 18:07:15 +01:00
block-group.h	btrfs: fix race between writes to swap files and scrub	2021-02-22 18:07:15 +01:00
block-rsv.c	btrfs: introduce mount option rescue=ignorebadroots	2020-12-08 15:53:41 +01:00
block-rsv.h	btrfs: Remove __ prefix from btrfs_block_rsv_release	2020-03-23 17:01:55 +01:00
btrfs_inode.h	btrfs: make btrfs_dio_private::bytes u32	2021-02-08 22:58:51 +01:00
check-integrity.c	btrfs: drop casts of bio bi_sector	2020-12-09 19:16:05 +01:00
check-integrity.h	btrfs: remove btrfsic_submit_bh()	2020-03-23 17:01:39 +01:00
compression.c	btrfs: make check_compressed_csum() to be subpage compatible	2021-02-22 17:15:27 +01:00
compression.h	btrfs: compression: move declarations to header	2020-10-07 12:06:55 +02:00
ctree.c	btrfs: fix race when cloning extent buffer during rewind of an old root	2021-03-16 20:32:17 +01:00
ctree.h	btrfs: fix race between writes to swap files and scrub	2021-02-22 18:07:15 +01:00
delalloc-space.c	btrfs: fix parameter description of btrfs_inode_rsv_release/btrfs_delalloc_release_space	2021-02-08 22:58:54 +01:00
delalloc-space.h	btrfs: make btrfs_delalloc_reserve_space take btrfs_inode	2020-07-27 12:55:36 +02:00
delayed-inode.c	btrfs: don't flush from btrfs_delayed_inode_reserve_metadata	2021-03-02 17:17:09 +01:00
delayed-inode.h	btrfs: make btrfs_delayed_update_inode take btrfs_inode	2020-12-08 15:54:10 +01:00
delayed-ref.c	btrfs: account for new extents being deleted in total_bytes_pinned	2021-02-08 22:58:55 +01:00
delayed-ref.h	btrfs: only let one thread pre-flush delayed refs in commit	2021-02-08 22:58:56 +01:00
dev-replace.c	btrfs: do not initialize dev replace for bad dev root	2021-03-17 19:42:14 +01:00
dev-replace.h	btrfs: zoned: mark block groups to copy for device-replace	2021-02-09 02:46:07 +01:00
dir-item.c	btrfs: locking: rip out path->leave_spinning	2020-12-08 15:54:02 +01:00
discard.c	btrfs: document now parameter of peek_discard_list	2021-02-08 22:58:53 +01:00
discard.h	btrfs: cleanup btrfs_discard_update_discardable usage	2020-12-08 15:54:02 +01:00
disk-io.c	btrfs: fix subvolume/snapshot deletion not triggered on mount	2021-03-17 19:42:22 +01:00
disk-io.h	btrfs: split alloc_log_tree()	2021-02-09 02:46:07 +01:00
export.c	btrfs: locking: rip out path->leave_spinning	2020-12-08 15:54:02 +01:00
export.h	btrfs: export helpers for subvolume name/id resolution	2020-03-23 17:01:42 +01:00
extent-io-tree.h	btrfs: use fixed width int type for extent_state::state	2020-12-08 15:54:13 +01:00
extent-tree.c	btrfs: always pin deleted leaves when there are active tree mod log users	2021-03-16 20:32:22 +01:00
extent_io.c	btrfs: subpage: fix wild pointer access during metadata read failure	2021-03-16 11:06:18 +01:00
extent_io.h	btrfs: zoned: redirty released extent buffers	2021-02-09 02:46:04 +01:00
extent_map.c	btrfs: fix parameter description of btrfs_add_extent_mapping	2021-02-08 22:58:53 +01:00
extent_map.h
file-item.c	btrfs: fix function description formats in file-item.c	2021-02-08 22:58:53 +01:00
file.c	btrfs: unlock extents in btrfs_zero_range in case of quota reservation errors	2021-03-02 16:55:44 +01:00
free-space-cache.c	btrfs: zoned: do not account freed region of read-only block group as zone_unusable	2021-03-04 16:16:58 +01:00
free-space-cache.h	btrfs: zoned: track unusable bytes for zones	2021-02-09 02:46:03 +01:00
free-space-tree.c	btrfs: fix possible free space tree corruption with online conversion	2021-01-25 18:44:37 +01:00
free-space-tree.h
inode-item.c	btrfs: locking: rip out path->leave_spinning	2020-12-08 15:54:02 +01:00
inode.c	btrfs: zoned: remove outdated WARN_ON in direct IO	2021-03-17 19:41:51 +01:00
ioctl.c	btrfs: validate qgroup inherit for SNAP_CREATE_V2 ioctl	2021-03-02 16:55:47 +01:00
Kconfig	btrfs: switch to iomap for direct IO	2020-10-07 12:06:57 +02:00
locking.c	btrfs: remove the recurse parameter from __btrfs_tree_read_lock	2020-12-08 15:54:09 +01:00
locking.h	btrfs: remove the recurse parameter from __btrfs_tree_read_lock	2020-12-08 15:54:09 +01:00
lzo.c
Makefile	btrfs: fix build when using M=fs/btrfs	2021-03-17 19:42:18 +01:00
misc.h	btrfs: rename tree_entry to rb_simple_node and export it	2020-05-25 11:25:19 +02:00
ordered-data.c	btrfs: zoned: use ZONE_APPEND write for zoned mode	2021-02-09 02:46:06 +01:00
ordered-data.h	btrfs: zoned: use ZONE_APPEND write for zoned mode	2021-02-09 02:46:06 +01:00
orphan.c
print-tree.c	btrfs: print the actual offset in btrfs_root_name	2021-01-07 17:25:05 +01:00
print-tree.h	btrfs: print the actual offset in btrfs_root_name	2021-01-07 17:25:05 +01:00
props.c	btrfs: simplify iget helpers	2020-05-25 11:25:37 +02:00
props.h
qgroup.c	btrfs: fix sleep while in non-sleep context during qgroup removal	2021-03-18 16:53:24 +01:00
qgroup.h	btrfs: export and rename qgroup_reserve_meta	2021-03-02 16:58:30 +01:00
raid56.c	btrfs: fix raid6 qstripe kmap	2021-02-22 17:15:21 +01:00
raid56.h
rcu-string.h	btrfs: rcu-string: Replace zero-length array with flexible-array member	2020-03-23 17:01:53 +01:00
reada.c	btrfs: subpage: make readahead work properly	2021-03-16 11:06:21 +01:00
ref-verify.c	btrfs: ref-verify: use 'inline void' keyword ordering	2021-03-02 16:55:40 +01:00
ref-verify.h
reflink.c	btrfs: fix stale data exposure after cloning a hole with NO_HOLES enabled	2021-02-22 18:07:45 +01:00
reflink.h	Btrfs: move all reflink implementation code into its own file	2020-03-23 17:01:54 +01:00
relocation.c	btrfs: zoned: enable relocation on a zoned filesystem	2021-02-09 02:46:07 +01:00
root-tree.c	btrfs: qgroup: fix qgroup meta rsv leak for subvolume operations	2020-10-07 12:12:13 +02:00
scrub.c	btrfs: fix race between writes to swap files and scrub	2021-02-22 18:07:15 +01:00
send.c	btrfs: send: use struct send_ctx *sctx for btrfs_compare_trees and changed_cb	2021-02-08 22:58:57 +01:00
send.h	btrfs: send: avoid copying file data	2020-10-07 12:13:17 +02:00
space-info.c	btrfs: zoned: track unusable bytes for zones	2021-02-09 02:46:03 +01:00
space-info.h	btrfs: zoned: track unusable bytes for zones	2021-02-09 02:46:03 +01:00
struct-funcs.c	btrfs: handle sectorsize < PAGE_SIZE case for extent buffer accessors	2020-12-09 19:16:10 +01:00
subpage.c	btrfs: integrate page status update for data read path into begin/end_page_read	2021-02-08 22:59:03 +01:00
subpage.h	btrfs: integrate page status update for data read path into begin/end_page_read	2021-02-08 22:59:03 +01:00
super.c	btrfs: fix spurious free_space_tree remount warning	2021-03-02 16:55:55 +01:00
sysfs.c	btrfs: zoned: track unusable bytes for zones	2021-02-09 02:46:03 +01:00
sysfs.h	btrfs: split and refactor btrfs_sysfs_remove_devices_dir	2020-10-07 12:12:21 +02:00
transaction.c	btrfs: zoned: redirty released extent buffers	2021-02-09 02:46:04 +01:00
transaction.h	btrfs: zoned: redirty released extent buffers	2021-02-09 02:46:04 +01:00
tree-checker.c	btrfs: tree-checker: do not error out if extent ref hash doesn't match	2021-02-22 18:07:44 +01:00
tree-checker.h
tree-defrag.c	btrfs: locking: remove all the blocking helpers	2020-12-08 15:54:01 +01:00
tree-log.c	btrfs: zoned: fix linked list corruption after log root tree allocation failure	2021-03-15 16:57:19 +01:00
tree-log.h	btrfs: make fast fsyncs wait only for writeback	2020-10-07 12:06:56 +02:00
ulist.c
ulist.h
uuid-tree.c	btrfs: remove unnecessary casts in printk	2020-12-08 15:53:52 +01:00
volumes.c	btrfs: do not initialize dev stats if we have no dev_root	2021-03-17 19:42:09 +01:00
volumes.h	btrfs: zoned: relocate block group to repair IO failure in zoned filesystems	2021-02-09 02:46:07 +01:00
xattr.c	btrfs: fix warning when creating a directory with smack enabled	2021-03-02 17:47:56 +01:00
xattr.h
zlib.c
zoned.c	btrfs: zoned: use sector_t for zone sectors	2021-03-04 16:16:55 +01:00
zoned.h	btrfs: zoned: extend zoned allocator to use dedicated tree-log block group	2021-02-09 02:46:08 +01:00
zstd.c