Filipe Manana ca5bec7ecf btrfs: error out when reallocating block for defrag using a stale transaction ... [ Upstream commit e36f949140 ] At btrfs_realloc_node() we have these checks to verify we are not using a stale transaction (a past transaction with an unblocked state or higher), and the only thing we do is to trigger two WARN_ON(). This however is a critical problem, highly unexpected and if it happens it's most likely due to a bug, so we should error out and turn the fs into error state so that such issue is much more easily noticed if it's triggered. The problem is critical because in btrfs_realloc_node() we COW tree blocks, and using such stale transaction will lead to not persisting the extent buffers used for the COW operations, as allocating tree block adds the range of the respective extent buffers to the ->dirty_pages iotree of the transaction, and a stale transaction, in the unlocked state or higher, will not flush dirty extent buffers anymore, therefore resulting in not persisting the tree block and resource leaks (not cleaning the dirty_pages iotree for example). So do the following changes: 1) Return -EUCLEAN if we find a stale transaction; 2) Turn the fs into error state, with error -EUCLEAN, so that no transaction can be committed, and generate a stack trace; 3) Combine both conditions into a single if statement, as both are related and have the same error message; 4) Mark the check as unlikely, since this is not expected to ever happen. Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-10-25 11:59:01 +02:00
..
tests	btrfs: remove pointless and double ulist frees in error paths of qgroup tests	2022-11-26 09:24:32 +01:00
acl.c	overlayfs update for 5.15	2021-09-02 09:21:27 -07:00
async-thread.c	btrfs: fix memory ordering between normal and ordered work functions	2021-11-25 09:48:46 +01:00
async-thread.h
backref.c	btrfs: fix resolving backrefs for inline extent followed by prealloc	2023-01-12 11:58:50 +01:00
backref.h	btrfs: sink iterator parameter to btrfs_ioctl_logical_to_ino	2022-12-08 11:28:38 +01:00
block-group.c	btrfs: move out now unused BG from the reclaim list	2023-08-26 14:23:30 +02:00
block-group.h	btrfs: fix space cache corruption and potential double allocations	2022-09-05 10:30:12 +02:00
block-rsv.c	btrfs: don't free qgroup space unless specified	2023-05-17 11:50:21 +02:00
block-rsv.h
btrfs_inode.h	btrfs: put initial index value of a directory in a constant	2022-08-31 17:16:35 +02:00
check-integrity.c	btrfs: rename btrfs_bio to btrfs_io_context	2022-07-21 21:24:32 +02:00
check-integrity.h
compression.c	btrfs: remove unused parameter nr_pages in add_ra_bio_pages()	2022-04-20 09:34:04 +02:00
compression.h	btrfs: rework btrfs_decompress_buf2page()	2021-08-23 13:19:04 +02:00
ctree.c	btrfs: error out when reallocating block for defrag using a stale transaction	2023-10-25 11:59:01 +02:00
ctree.h	btrfs: move btrfs_pinned_by_swapfile prototype into volumes.h	2023-09-23 11:10:00 +02:00
delalloc-space.c	btrfs: convert count_max_extents() to use fs_info->max_extent_size	2022-08-31 17:16:34 +02:00
delalloc-space.h
delayed-inode.c	btrfs: improve error message after failure to add delayed dir index item	2023-10-06 13:18:16 +02:00
delayed-inode.h
delayed-ref.c	btrfs: fix lock inversion problem when doing qgroup extent tracing	2021-07-22 15:50:07 +02:00
delayed-ref.h	btrfs: add additional parameters to btrfs_init_tree_ref/btrfs_init_data_ref	2022-07-12 16:34:50 +02:00
dev-replace.c	btrfs: add info when mount fails due to stale replace target	2022-08-31 17:16:46 +02:00
dev-replace.h
dir-item.c	btrfs: unify lookup return value when dir entry is missing	2021-10-07 22:06:32 +02:00
discard.c	btrfs: hold block group refcount during async discard	2023-03-10 09:39:56 +01:00
discard.h
disk-io.c	btrfs: compare the correct fsid/metadata_uuid in btrfs_validate_super	2023-09-23 11:10:01 +02:00
disk-io.h	btrfs: make thaw time super block check to also verify checksum	2023-01-12 11:59:20 +01:00
export.c	btrfs: fix type of parameter generation in btrfs_get_dentry	2022-11-10 18:15:38 +01:00
export.h	btrfs: fix type of parameter generation in btrfs_get_dentry	2022-11-10 18:15:38 +01:00
extent-io-tree.h
extent-tree.c	btrfs: return -EUCLEAN for delayed tree ref with a ref count not equals to 1	2023-10-25 11:58:59 +02:00
extent_io.c	btrfs: reset destination buffer when read_extent_buffer() gets invalid range	2023-10-06 13:18:11 +02:00
extent_io.h	btrfs: fix qgroup reserve overflow the qgroup limit	2022-04-13 20:59:23 +02:00
extent_map.c	btrfs: rename btrfs_bio to btrfs_io_context	2022-07-21 21:24:32 +02:00
extent_map.h
file-item.c	btrfs: handle memory allocation failure in btrfs_csum_one_bio	2023-06-21 15:59:13 +02:00
file.c	btrfs: do not BUG_ON() on ENOMEM when dropping extent items for a range	2022-12-31 13:14:47 +01:00
free-space-cache.c	btrfs: fix space cache inconsistency after error loading it from disk	2023-05-17 11:50:22 +02:00
free-space-cache.h
free-space-tree.c	btrfs: fix invalid delayed ref after subvolume creation failure	2022-07-12 16:34:50 +02:00
free-space-tree.h
inode-item.c
inode.c	btrfs: free qgroup rsv on io failure	2023-09-19 12:23:01 +02:00
ioctl.c	btrfs: fix some -Wmaybe-uninitialized warnings in ioctl.c	2023-10-25 11:59:01 +02:00
Kconfig	btrfs: disable build on platforms having page size 256K	2021-06-22 14:11:57 +02:00
locking.c	btrfs: fix lockdep splat with reloc root extent buffers	2022-09-05 10:30:12 +02:00
locking.h	btrfs: fix lockdep splat with reloc root extent buffers	2022-09-05 10:30:12 +02:00
lzo.c	btrfs: prevent copying too big compressed lzo segment	2022-03-02 11:48:07 +01:00
Makefile	btrfs: initial fsverity support	2021-08-23 13:19:09 +02:00
misc.h	btrfs: use correct header for div_u64 in misc.h	2021-09-07 14:29:50 +02:00
ordered-data.c	btrfs: zoned: fix double counting of split ordered extent	2021-09-07 14:30:41 +02:00
ordered-data.h	btrfs: remove uptodate parameter from btrfs_dec_test_first_ordered_pending	2021-08-23 13:19:02 +02:00
orphan.c
print-tree.c	btrfs: print-tree: parent bytenr must be aligned to sector size	2023-05-17 11:50:22 +02:00
print-tree.h
props.c	btrfs: props: change how empty value is interpreted	2021-06-22 14:11:58 +02:00
props.h
qgroup.c	btrfs: fix race between quota disable and relocation	2023-08-03 10:22:26 +02:00
qgroup.h	btrfs: fix lock inversion problem when doing qgroup extent tracing	2021-07-22 15:50:07 +02:00
raid56.c	btrfs: raid56: properly handle the error when unable to find the missing stripe	2022-11-26 09:24:31 +01:00
raid56.h	btrfs: rename btrfs_bio to btrfs_io_context	2022-07-21 21:24:32 +02:00
rcu-string.h	btrfs: replace strncpy() with strscpy()	2023-01-12 11:59:05 +01:00
reada.c	btrfs: rename btrfs_bio to btrfs_io_context	2022-07-21 21:24:32 +02:00
ref-verify.c	btrfs: stop doing GFP_KERNEL memory allocations in the ref verify tool	2021-08-23 13:19:00 +02:00
ref-verify.h
reflink.c	btrfs: fix unexpected error path when reflinking an inline extent	2022-04-08 14:23:11 +02:00
reflink.h
relocation.c	btrfs: exit gracefully if reloc roots don't match	2023-08-16 18:22:02 +02:00
root-tree.c	btrfs: fix silent failure when deleting root reference	2022-08-31 17:16:46 +02:00
scrub.c	btrfs: scrub: try harder to mark RAID56 block groups read-only	2023-06-21 15:59:13 +02:00
send.c	btrfs: send: limit number of clones and allocated memory size	2023-03-03 11:45:52 +01:00
send.h
space-info.c	btrfs: extend locking to all space_info members accesses	2022-04-08 14:23:02 +02:00
space-info.h	btrfs: rip out btrfs_space_info::total_bytes_pinned	2021-06-22 14:55:25 +02:00
struct-funcs.c	btrfs: add special case to setget helpers for 64k pages	2021-08-23 13:18:58 +02:00
subpage.c	btrfs: subpage: fix a potential use-after-free in writeback helper	2021-08-23 13:19:05 +02:00
subpage.h	btrfs: subpage: fix writeback which does not have ordered extent	2021-08-23 13:19:04 +02:00
super.c	btrfs: properly report 0 avail for very full file systems	2023-10-06 13:18:23 +02:00
sysfs.c	btrfs: sysfs: normalize the error handling branch in btrfs_init_sysfs()	2022-12-02 17:41:12 +01:00
sysfs.h
transaction.c	btrfs: don't start transaction when joining with TRANS_JOIN_NOSTART	2023-09-19 12:23:01 +02:00
transaction.h	btrfs: do not start relocation until in progress drops are done	2022-03-08 19:12:54 +01:00
tree-checker.c	btrfs: reject invalid reloc tree root keys with stack dump	2023-08-16 18:22:02 +02:00
tree-checker.h
tree-defrag.c	btrfs: fix an error handling path in btrfs_defrag_leaves()	2023-01-12 11:59:08 +01:00
tree-log.c	btrfs: initialize start_slot in btrfs_log_prealloc_extents	2023-10-25 11:58:59 +02:00
tree-log.h	btrfs: pass the dentry to btrfs_log_new_name() instead of the inode	2022-08-31 17:16:36 +02:00
tree-mod-log.c
tree-mod-log.h
ulist.c
ulist.h
uuid-tree.c
verity.c	btrfs: fix transaction handle leak after verity rollback failure	2021-09-17 19:29:41 +02:00
volumes.c	btrfs: add a helper to read the superblock metadata_uuid	2023-09-23 11:10:00 +02:00
volumes.h	btrfs: add a helper to read the superblock metadata_uuid	2023-09-23 11:10:00 +02:00
xattr.c	btrfs: check if root is readonly while setting security xattr	2022-08-31 17:16:46 +02:00
xattr.h
zlib.c	btrfs: zlib: zero-initialize zlib workspace	2023-02-14 19:17:56 +01:00
zoned.c	btrfs: zero the buffer before marking it dirty in btrfs_redirty_list_add	2023-05-17 11:50:22 +02:00
zoned.h	btrfs: zoned: revive max_zone_append_bytes	2022-08-31 17:16:34 +02:00
zstd.c	Revert "btrfs: compression: drop kmap/kunmap from zstd"	2021-10-29 13:02:50 +02:00