mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 01:49:36 +00:00
5979afa2c4
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20200220132908.GA30501@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
85 lines
1.7 KiB
C
85 lines
1.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Copyright (c) 2012 GCT Semiconductor, Inc. All rights reserved. */
|
|
|
|
#ifndef _GDM_MUX_H_
|
|
#define _GDM_MUX_H_
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/usb.h>
|
|
#include <linux/list.h>
|
|
|
|
#include "gdm_tty.h"
|
|
|
|
#define PM_NORMAL 0
|
|
#define PM_SUSPEND 1
|
|
|
|
#define USB_RT_ACM (USB_TYPE_CLASS | USB_RECIP_INTERFACE)
|
|
|
|
#define START_FLAG 0xA512485A
|
|
#define MUX_HEADER_SIZE 14
|
|
#define MUX_TX_MAX_SIZE (1024 * 10)
|
|
#define MUX_RX_MAX_SIZE (1024 * 30)
|
|
#define AT_PKT_TYPE 0xF011
|
|
#define DM_PKT_TYPE 0xF010
|
|
|
|
#define RETRY_TIMER 30 /* msec */
|
|
|
|
struct mux_pkt_header {
|
|
__le32 start_flag;
|
|
__le32 seq_num;
|
|
__le32 payload_size;
|
|
__le16 packet_type;
|
|
unsigned char data[];
|
|
};
|
|
|
|
struct mux_tx {
|
|
struct urb *urb;
|
|
u8 *buf;
|
|
int len;
|
|
void (*callback)(void *cb_data);
|
|
void *cb_data;
|
|
};
|
|
|
|
struct mux_rx {
|
|
struct list_head free_list;
|
|
struct list_head rx_submit_list;
|
|
struct list_head to_host_list;
|
|
struct urb *urb;
|
|
u8 *buf;
|
|
void *mux_dev;
|
|
u32 offset;
|
|
u32 len;
|
|
int (*callback)(void *data,
|
|
int len,
|
|
int tty_index,
|
|
struct tty_dev *tty_dev,
|
|
int complete);
|
|
};
|
|
|
|
struct rx_cxt {
|
|
struct list_head to_host_list;
|
|
struct list_head rx_submit_list;
|
|
struct list_head rx_free_list;
|
|
spinlock_t to_host_lock;
|
|
spinlock_t submit_list_lock;
|
|
spinlock_t free_list_lock;
|
|
};
|
|
|
|
struct mux_dev {
|
|
struct usb_device *usbdev;
|
|
struct usb_interface *control_intf;
|
|
struct usb_interface *data_intf;
|
|
struct rx_cxt rx;
|
|
struct delayed_work work_rx;
|
|
struct usb_interface *intf;
|
|
int usb_state;
|
|
int (*rx_cb)(void *data,
|
|
int len,
|
|
int tty_index,
|
|
struct tty_dev *tty_dev,
|
|
int complete);
|
|
spinlock_t write_lock;
|
|
struct tty_dev *tty_dev;
|
|
};
|
|
|
|
#endif /* _GDM_MUX_H_ */
|