linux-stable/sound
Stephan Gerhold 0c824ec094
ASoC: q6dsp6: q6afe-dai: add missing channels to MI2S DAIs
For some reason, the MI2S DAIs do not have channels_min/max defined.
This means that snd_soc_dai_stream_valid() returns false,
i.e. the DAIs have neither valid playback nor capture stream.

It's quite surprising that this ever worked correctly,
but in 5.7-rc1 this is now failing badly: :)

Commit 0e9cf4c452 ("ASoC: pcm: check if cpu-dai supports a given stream")
introduced a check for snd_soc_dai_stream_valid() before calling
hw_params(), which means that the q6i2s_hw_params() function
was never called, eventually resulting in:

    qcom-q6afe aprsvc:q6afe:4:4: no line is assigned

... even though "qcom,sd-lines" is set in the device tree.

Commit 9b5db05936 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
now even avoids creating PCM devices if the stream is not supported,
which means that it is failing even earlier with e.g.:

    Primary MI2S: ASoC: no backend playback stream

Avoid all that trouble by adding channels_min/max for the MI2S DAIs.

Fixes: 24c4cbcfac ("ASoC: qdsp6: q6afe: Add q6afe dai driver")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200415150050.616392-1-stephan@gerhold.net
Signed-off-by: Mark Brown <broonie@kernel.org>
2020-04-15 17:58:59 +01:00
..
ac97
aoa
arm ASoC: arm: use asoc_rtd_to_cpu() / asoc_rtd_to_codec() macro for DAI pointer 2020-03-27 14:44:56 +00:00
atmel
core Linux 5.6-rc5 2020-03-11 18:45:26 +00:00
drivers sound fixes for 5.6-rc1 2020-02-06 14:15:01 +00:00
firewire Merge branch 'for-linus' into for-next 2020-01-20 11:44:51 +01:00
hda ASoC: Fixes for v5.6 2020-02-18 13:33:39 +01:00
i2c
isa sound updates for 5.6-rc1 2020-01-28 16:26:57 -08:00
mips ALSA: sgio2audio: Remove usage of dropped hw_params/hw_free functions 2020-03-06 12:06:41 +01:00
oss
parisc sound updates for 5.6-rc1 2020-01-28 16:26:57 -08:00
pci ALSA: hda/realtek - Enable the headset of ASUS B9450FA with ALC294 2020-03-05 15:46:54 +01:00
pcmcia
ppc
sh
soc ASoC: q6dsp6: q6afe-dai: add missing channels to MI2S DAIs 2020-04-15 17:58:59 +01:00
sparc
spi
synth
usb Linux 5.6-rc5 2020-03-11 18:45:26 +00:00
x86 sound updates for 5.6-rc1 2020-01-28 16:26:57 -08:00
xen
ac97_bus.c
Kconfig
last.c
Makefile
sound_core.c