Tatsuhiko Yasumatsu 064faa8e8a bpf: Fix integer overflow in prealloc_elems_and_freelist() ... [ Upstream commit 30e29a9a2b ] In prealloc_elems_and_freelist(), the multiplication to calculate the size passed to bpf_map_area_alloc() could lead to an integer overflow. As a result, out-of-bounds write could occur in pcpu_freelist_populate() as reported by KASAN: [...] [ 16.968613] BUG: KASAN: slab-out-of-bounds in pcpu_freelist_populate+0xd9/0x100 [ 16.969408] Write of size 8 at addr ffff888104fc6ea0 by task crash/78 [ 16.970038] [ 16.970195] CPU: 0 PID: 78 Comm: crash Not tainted 5.15.0-rc2+ #1 [ 16.970878] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 [ 16.972026] Call Trace: [ 16.972306] dump_stack_lvl+0x34/0x44 [ 16.972687] print_address_description.constprop.0+0x21/0x140 [ 16.973297] ? pcpu_freelist_populate+0xd9/0x100 [ 16.973777] ? pcpu_freelist_populate+0xd9/0x100 [ 16.974257] kasan_report.cold+0x7f/0x11b [ 16.974681] ? pcpu_freelist_populate+0xd9/0x100 [ 16.975190] pcpu_freelist_populate+0xd9/0x100 [ 16.975669] stack_map_alloc+0x209/0x2a0 [ 16.976106] __sys_bpf+0xd83/0x2ce0 [...] The possibility of this overflow was originally discussed in [0], but was overlooked. Fix the integer overflow by changing elem_size to u64 from u32. [0] https://lore.kernel.org/bpf/728b238e-a481-eb50-98e9-b0f430ab01e7@gmail.com/ Fixes: 557c0c6e7d ("bpf: convert stackmap to pre-allocation") Signed-off-by: Tatsuhiko Yasumatsu <th.yasumatsu@gmail.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/bpf/20210930135545.173698-1-th.yasumatsu@gmail.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-10-13 10:04:26 +02:00
..
preload	bpf: Fix umd memory leak in copy_process()	2021-03-30 14:32:03 +02:00
arraymap.c	bpf: Allow for map-in-map with dynamic inner array map entries	2020-10-11 10:21:04 -07:00
bpf_inode_storage.c	bpf: Change inode_storage's lookup_elem return value from NULL to -EBADF	2021-03-30 14:31:56 +02:00
bpf_iter.c	bpf: Fix an unitialized value in bpf_iter	2021-03-04 11:37:33 +01:00
bpf_local_storage.c	bpf: Use hlist_add_head_rcu when linking to local_storage	2020-09-19 01:12:35 +02:00
bpf_lru_list.c	bpf_lru_list: Read double-checked variable once without lock	2021-03-04 11:37:29 +01:00
bpf_lru_list.h	bpf: Fix a typo "inacitve" -> "inactive"	2020-04-06 21:54:10 +02:00
bpf_lsm.c	bpf: Update verification logic for LSM programs	2020-11-06 13:15:21 -08:00
bpf_struct_ops.c	bpf: Handle return value of BPF_PROG_TYPE_STRUCT_OPS prog	2021-10-06 15:55:50 +02:00
bpf_struct_ops_types.h	bpf: tcp: Support tcp_congestion_ops in bpf	2020-01-09 08:46:18 -08:00
btf.c	bpf: Forbid trampoline attach for functions with variable arguments	2021-06-16 12:01:35 +02:00
cgroup.c	bpf, cgroup: Fix problematic bounds check	2021-02-10 09:29:12 +01:00
core.c	bpf: Exempt CAP_BPF from checks against bpf_jit_limit	2021-10-06 15:55:55 +02:00
cpumap.c	bpf, cpumap: Remove rcpu pointer from cpu_map_build_skb signature	2020-09-28 23:30:42 +02:00
devmap.c	bpf, devmap: Use GFP_KERNEL for xdp bulk queue allocation	2021-03-04 11:37:33 +01:00
disasm.c	bpf: Introduce BPF nospec instruction for mitigating Spectre v4	2021-08-04 12:46:44 +02:00
disasm.h
dispatcher.c	bpf: Remove bpf_image tree	2020-03-13 12:49:52 -07:00
hashtab.c	bpf: Fix integer overflow involving bucket_size	2021-08-18 08:59:10 +02:00
helpers.c	bpf: Fix potentially incorrect results with bpf_get_local_storage()	2021-09-03 10:09:31 +02:00
inode.c	bpf: link: Refuse non-O_RDWR flags in BPF_OBJ_GET	2021-04-14 08:42:00 +02:00
local_storage.c	bpf: Fix NULL pointer dereference in bpf_get_local_storage() helper	2021-09-03 10:09:21 +02:00
lpm_trie.c	bpf: Add map_meta_equal map ops	2020-08-28 15:41:30 +02:00
Makefile	bpf: Don't rely on GCC __attribute__((optimize)) to disable GCSE	2020-10-29 20:01:46 -07:00
map_in_map.c	bpf: Relax max_entries check for most of the inner map types	2020-08-28 15:41:30 +02:00
map_in_map.h	bpf: Add map_meta_equal map ops	2020-08-28 15:41:30 +02:00
map_iter.c	bpf: Implement link_query callbacks in map element iterators	2020-08-21 14:01:39 -07:00
net_namespace.c	bpf: Add support for forced LINK_DETACH command	2020-08-01 20:38:28 -07:00
offload.c	bpf, offload: Replace bitwise AND by logical AND in bpf_prog_offload_info_fill	2020-02-17 16:53:49 +01:00
percpu_freelist.c	bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI	2020-10-06 00:04:11 +02:00
percpu_freelist.h	bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI	2020-10-06 00:04:11 +02:00
prog_iter.c	bpf: Refactor bpf_iter_reg to have separate seq_info member	2020-07-25 20:16:32 -07:00
queue_stack_maps.c	bpf: Add map_meta_equal map ops	2020-08-28 15:41:30 +02:00
reuseport_array.c	bpf, net: Rework cookie generator as per-cpu one	2020-09-30 11:50:35 -07:00
ringbuf.c	bpf: Fix false positive kmemleak report in bpf_ringbuf_area_alloc()	2021-07-19 09:44:54 +02:00
stackmap.c	bpf: Fix integer overflow in prealloc_elems_and_freelist()	2021-10-13 10:04:26 +02:00
syscall.c	bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach	2021-01-27 11:55:07 +01:00
sysfs_btf.c	bpf: Fix sysfs export of empty BTF section	2020-09-21 21:50:24 +02:00
task_iter.c	bpf: Save correct stopping point in file seq iteration	2021-01-19 18:27:28 +01:00
tnum.c	bpf: Verifier, do explicit ALU32 bounds tracking	2020-03-30 14:59:53 -07:00
trampoline.c	bpf: Fix fexit trampoline.	2021-04-07 15:00:03 +02:00
verifier.c	bpf: Add oversize check before call kvcalloc()	2021-09-30 10:11:06 +02:00