mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 15:18:19 +00:00
6a12b8e20d
I am getting the following compilation error for prog_tests/uprobe_autoattach.c:
tools/testing/selftests/bpf/prog_tests/uprobe_autoattach.c: In function ‘test_uprobe_autoattach’:
./test_progs.h:209:26: error: pointer ‘mem’ may be used after ‘free’ [-Werror=use-after-free]
The value of mem is now used in one of the asserts, which is why it may be
confusing compilers. However, it is not dereferenced. Silence this by moving
free(mem) after the assert block.
Fixes: 1717e24801 ("selftests/bpf: Uprobe tests should verify param/return values")
Signed-off-by: Artem Savkov <asavkov@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20220421132317.1583867-1-asavkov@redhat.com
50 lines
1.5 KiB
C
50 lines
1.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/* Copyright (c) 2022, Oracle and/or its affiliates. */
|
|
|
|
#include <test_progs.h>
|
|
#include "test_uprobe_autoattach.skel.h"
|
|
|
|
/* uprobe attach point */
|
|
static noinline int autoattach_trigger_func(int arg)
|
|
{
|
|
asm volatile ("");
|
|
return arg + 1;
|
|
}
|
|
|
|
void test_uprobe_autoattach(void)
|
|
{
|
|
struct test_uprobe_autoattach *skel;
|
|
int trigger_val = 100, trigger_ret;
|
|
size_t malloc_sz = 1;
|
|
char *mem;
|
|
|
|
skel = test_uprobe_autoattach__open_and_load();
|
|
if (!ASSERT_OK_PTR(skel, "skel_open"))
|
|
return;
|
|
|
|
if (!ASSERT_OK(test_uprobe_autoattach__attach(skel), "skel_attach"))
|
|
goto cleanup;
|
|
|
|
skel->bss->test_pid = getpid();
|
|
|
|
/* trigger & validate uprobe & uretprobe */
|
|
trigger_ret = autoattach_trigger_func(trigger_val);
|
|
|
|
skel->bss->test_pid = getpid();
|
|
|
|
/* trigger & validate shared library u[ret]probes attached by name */
|
|
mem = malloc(malloc_sz);
|
|
|
|
ASSERT_EQ(skel->bss->uprobe_byname_parm1, trigger_val, "check_uprobe_byname_parm1");
|
|
ASSERT_EQ(skel->bss->uprobe_byname_ran, 1, "check_uprobe_byname_ran");
|
|
ASSERT_EQ(skel->bss->uretprobe_byname_rc, trigger_ret, "check_uretprobe_byname_rc");
|
|
ASSERT_EQ(skel->bss->uretprobe_byname_ran, 2, "check_uretprobe_byname_ran");
|
|
ASSERT_EQ(skel->bss->uprobe_byname2_parm1, malloc_sz, "check_uprobe_byname2_parm1");
|
|
ASSERT_EQ(skel->bss->uprobe_byname2_ran, 3, "check_uprobe_byname2_ran");
|
|
ASSERT_EQ(skel->bss->uretprobe_byname2_rc, mem, "check_uretprobe_byname2_rc");
|
|
ASSERT_EQ(skel->bss->uretprobe_byname2_ran, 4, "check_uretprobe_byname2_ran");
|
|
|
|
free(mem);
|
|
cleanup:
|
|
test_uprobe_autoattach__destroy(skel);
|
|
}
|