Brian Foster 0e84e17c16 xfs: punch out data fork delalloc blocks on COW writeback failure ... [ Upstream commit 5ca5916b6b ] If writeback I/O to a COW extent fails, the COW fork blocks are punched out and the data fork blocks left alone. It is possible for COW fork blocks to overlap non-shared data fork blocks (due to cowextsz hint prealloc), however, and writeback unconditionally maps to the COW fork whenever blocks exist at the corresponding offset of the page undergoing writeback. This means it's quite possible for a COW fork extent to overlap delalloc data fork blocks, writeback to convert and map to the COW fork blocks, writeback to fail, and finally for ioend completion to cancel the COW fork blocks and leave stale data fork delalloc blocks around in the inode. The blocks are effectively stale because writeback failure also discards dirty page state. If this occurs, it is likely to trigger assert failures, free space accounting corruption and failures in unrelated file operations. For example, a subsequent reflink attempt of the affected file to a new target file will trip over the stale delalloc in the source file and fail. Several of these issues are occasionally reproduced by generic/648, but are reproducible on demand with the right sequence of operations and timely I/O error injection. To fix this problem, update the ioend failure path to also punch out underlying data fork delalloc blocks on I/O error. This is analogous to the writeback submission failure path in xfs_discard_page() where we might fail to map data fork delalloc blocks and consistent with the successful COW writeback completion path, which is responsible for unmapping from the data fork and remapping in COW fork blocks. Fixes: 787eb48550 ("xfs: fix and streamline error handling in xfs_end_io") Signed-off-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com> Acked-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-07-02 16:41:13 +02:00
..
9p	9p: fix fid refcount leak in v9fs_vfs_get_link	2022-06-29 09:03:19 +02:00
adfs
affs
afs	afs: Fix dynamic root getattr	2022-06-29 09:03:25 +02:00
autofs	autofs: fix wait name hash calculation in autofs_wait()	2021-10-20 21:09:02 -04:00
befs	isystem: ship and use stdarg.h	2021-08-19 09:02:55 +09:00
bfs
btrfs	btrfs: fix deadlock with fsync+fiemap+transaction commit	2022-06-29 09:03:27 +02:00
cachefiles	cachefiles: Change %p in format strings to something else	2021-08-27 13:34:02 +01:00
ceph	ceph: flush the mdlog for filesystem sync	2022-06-14 18:36:23 +02:00
cifs	cifs: fix reconnect on smb3 mount types	2022-06-14 18:36:25 +02:00
coda
configfs	configfs: fix a race in configfs_{,un}register_subsystem()	2022-03-02 11:48:02 +01:00
cramfs
crypto	fscrypt: allow 256-bit master keys with AES-256-XTS	2021-11-18 19:16:11 +01:00
debugfs	debugfs: lockdown: Allow reading debugfs files that are not world readable	2022-01-27 11:03:55 +01:00
devpts	fsnotify: fix fsnotify hooks in pseudo filesystems	2022-02-01 17:27:01 +01:00
dlm	dlm: fix missing lkb refcount handling	2022-06-09 10:23:22 +02:00
ecryptfs
efivarfs
efs
erofs	iomap: Add done_before argument to iomap_dio_rw	2022-05-01 17:22:32 +02:00
exfat	exfat: check if cluster num is valid	2022-06-06 08:43:37 +02:00
exportfs	exportfs: support idmapped mounts	2022-06-09 10:23:32 +02:00
ext2	ext2: correct max file size computing	2022-04-08 14:23:35 +02:00
ext4	ext4: add reserved GDT blocks check	2022-06-22 14:22:05 +02:00
f2fs	f2fs: attach inline_data after setting compression	2022-06-29 09:03:27 +02:00
fat	fat: add ratelimit to fat*_ent_bread()	2022-06-09 10:22:42 +02:00
freevxfs
fscache	fscache: Remove an unused static variable	2021-10-04 22:13:12 +01:00
fuse	iov_iter: Turn iov_iter_fault_in_readable into fault_in_iov_iter_readable	2022-05-01 17:22:28 +02:00
gfs2	gfs2: use i_lock spin_lock for inode qadata	2022-06-09 10:22:40 +02:00
hfs
hfsplus
hostfs	hostfs: support splice_write	2021-08-26 22:28:02 +02:00
hpfs	hpfs: use iomap_fiemap to implement ->fiemap	2021-07-27 11:00:36 +02:00
hugetlbfs	hugetlbfs: fix hugetlbfs_statfs() locking	2022-06-09 10:23:11 +02:00
iomap	iomap: iomap_write_failed fix	2022-06-09 10:22:55 +02:00
isofs	isofs: Fix out of bound access for corrupted isofs image	2021-11-12 15:05:50 +01:00
jbd2	jbd2: fix a potential race while discarding reserved buffers after an abort	2022-04-27 14:39:02 +02:00
jffs2	jffs2: fix memory leak in jffs2_do_fill_super	2022-06-14 18:36:10 +02:00
jfs	fs: jfs: fix possible NULL pointer dereference in dbFree()	2022-06-09 10:22:41 +02:00
kernfs	kernfs: Separate kernfs_pr_cont_buf and rename_lock.	2022-06-14 18:36:22 +02:00
ksmbd	ksmbd: fix reference count leak in smb_check_perm_dacl()	2022-06-14 18:36:06 +02:00
lockd	lockd: fix failure to cleanup client locks	2022-02-05 12:38:57 +01:00
minix	minix: fix bug when opening a file with O_DIRECT	2022-04-13 20:59:10 +02:00
netfs	netfs: fix parameter of cleanup()	2021-12-29 12:28:59 +01:00
nfs	pNFS: Avoid a live lock condition in pnfs_update_layout()	2022-06-22 14:21:59 +02:00
nfs_common	nfs: Fix kerneldoc warning shown up by W=1	2021-10-04 22:02:17 +01:00
nfsd	nfsd: Replace use of rwsem with errseq_t	2022-06-22 14:21:54 +02:00
nilfs2	nilfs2: fix lockdep warnings during disk space reclamation	2022-05-25 09:57:26 +02:00
nls
notify	fsnotify: fix wrong lockdep annotations	2022-06-09 10:22:50 +02:00
ntfs	iov_iter: Turn iov_iter_fault_in_readable into fault_in_iov_iter_readable	2022-05-01 17:22:28 +02:00
ntfs3	fs/ntfs3: Fix invalid free in log_replay	2022-06-09 10:23:32 +02:00
ocfs2	ocfs2: dlmfs: fix error handling of user_dlm_destroy_lock	2022-06-09 10:23:22 +02:00
omfs
openpromfs
orangefs	orangefs: Fix the size of a memory allocation in orangefs_bufmap_alloc()	2022-01-20 09:13:13 +01:00
overlayfs	ovl: fix NULL pointer dereference in copy up warning	2022-02-05 12:38:59 +01:00
proc	proc: fix dentry/inode overinstantiating under /proc/${pid}/net	2022-06-09 10:23:10 +02:00
pstore	pstore: Don't use semaphores in always-atomic-context code	2022-04-08 14:23:01 +02:00
qnx4	qnx4: work around gcc false positive warning bug	2021-09-21 08:36:48 -07:00
qnx6
quota	quota: Prevent memory allocation recursion while holding dq_lock	2022-06-22 14:21:56 +02:00
ramfs
reiserfs	Kbuild updates for v5.15	2021-09-03 15:33:47 -07:00
romfs
smbfs_common	cifs: Fix crash on unload of cifs_arc4.ko	2021-12-14 10:57:12 +01:00
squashfs	squashfs: use bvec_virt	2021-08-16 10:50:32 -06:00
sysfs	sysfs: Allow deferred execution of iomem_get_mapping()	2021-08-06 13:05:28 +02:00
sysv
tracefs	tracefs: Set the group ownership in apply_options() not parse_options()	2022-03-02 11:48:05 +01:00
ubifs	ubifs: rename_whiteout: correct old_dir size computing	2022-04-08 14:24:08 +02:00
udf	udf: Avoid using stale lengthOfImpUse	2022-05-15 20:18:52 +02:00
ufs	isystem: ship and use stdarg.h	2021-08-19 09:02:55 +09:00
unicode
vboxsf	vboxfs: fix broken legacy mount signature checking	2021-09-27 11:26:21 -07:00
verity	fs-verity: fix signed integer overflow with i_size near S64_MAX	2021-09-22 10:56:34 -07:00
xfs	xfs: punch out data fork delalloc blocks on COW writeback failure	2022-07-02 16:41:13 +02:00
zonefs	zonefs: fix zonefs_iomap_begin() for reads	2022-06-25 15:18:40 +02:00
aio.c	aio: Fix incorrect usage of eventfd_signal_allowed()	2021-12-14 10:57:22 +01:00
anon_inodes.c
attr.c	fs: handle circular mappings correctly	2021-11-25 09:48:46 +01:00
bad_inode.c	vfs: add rcu argument to ->get_acl() callback	2021-08-18 22:08:24 +02:00
binfmt_aout.c	binfmt: a.out: Fix bogus semicolon	2021-09-05 10:15:05 -07:00
binfmt_elf.c	coredump: Use the vma snapshot in fill_files_note	2022-04-08 14:24:18 +02:00
binfmt_elf_fdpic.c	coredump: Snapshot the vmas in do_coredump	2022-04-08 14:24:17 +02:00
binfmt_flat.c	binfmt_flat: do not stop relocating GOT entries prematurely on riscv	2022-06-09 10:22:26 +02:00
binfmt_misc.c
binfmt_script.c
buffer.c	mm: fs: fix lru_cache_disabled race in bh_lru	2022-04-08 14:22:54 +02:00
char_dev.c
compat_binfmt_elf.c
coredump.c	coredump: Use the vma snapshot in fill_files_note	2022-04-08 14:24:18 +02:00
d_path.c	d_path: make 'prepend()' fill up the buffer exactly on overflow	2021-09-02 10:07:29 -07:00
dax.c	dax: fix cache flush on PMD-mapped pages	2022-06-09 10:23:09 +02:00
dcache.c
direct-io.c
drop_caches.c	fs: drop_caches: fix skipping over shadow cache inodes	2021-09-03 09:58:10 -07:00
eventfd.c	eventfd: Export eventfd_wake_count to modules	2021-09-06 07:20:56 -04:00
eventpoll.c	ARM development updates for 5.15:	2021-09-09 13:25:49 -07:00
exec.c	exec: Force single empty string when argv is empty	2022-04-08 14:23:01 +02:00
fcntl.c	Merge branch 'akpm' (patches from Andrew)	2021-09-03 10:08:28 -07:00
fhandle.c
file.c	fs: fix fd table size alignment properly	2022-04-08 14:23:54 +02:00
file_table.c	SUNRPC: Ensure we flush any closed sockets before xs_xprt_free()	2022-05-18 10:26:57 +02:00
filesystems.c	fs: simplify get_filesystem_list / get_all_fs_names	2021-08-23 01:25:40 -04:00
fs-writeback.c	writeback: Fix inode->i_io_list not be protected by inode->i_lock error	2022-06-14 18:36:26 +02:00
fs_context.c	vfs: fs_context: fix up param length parsing in legacy_parse_param	2022-01-20 09:13:14 +01:00
fs_parser.c	namei: Standardize callers of filename_lookup()	2021-09-07 16:07:47 -04:00
fs_pin.c
fs_struct.c
fs_types.c
fsopen.c
init.c
inode.c	writeback: Fix inode->i_io_list not be protected by inode->i_lock error	2022-06-14 18:36:26 +02:00
internal.h	block: simplify the block device syncing code	2022-04-27 14:38:50 +02:00
io-wq.c	io-wq: drop wqe lock before creating new worker	2021-12-22 09:32:51 +01:00
io-wq.h	io-wq: provide a way to limit max number of workers	2021-08-29 07:55:55 -06:00
io_uring.c	io_uring: fix races with buffer table unregister	2022-06-22 14:22:00 +02:00
ioctl.c	fs: fix an infinite loop in iomap_fiemap	2022-05-25 09:57:26 +02:00
Kconfig	4 cifs/smb3 fixes, one for DFS reconnect, and one to begin creating common headers for server and client and the other two to rename the cifs_common directory to smbfs_common to be more consistent ie change use of the name cifs to smb which is more accurate	2021-09-12 10:10:21 -07:00
Kconfig.binfmt	binfmt: remove support for em86 (alpha only)	2021-07-25 22:33:03 -07:00
kernel_read_file.c	vfs: check fd has read access in kernel_read_file_from_fd()	2021-10-18 20:22:03 -10:00
libfs.c
locks.c	Revert "memcg: enable accounting for file lock caches"	2021-09-07 11:21:48 -07:00
Makefile	4 cifs/smb3 fixes, one for DFS reconnect, and one to begin creating common headers for server and client and the other two to rename the cifs_common directory to smbfs_common to be more consistent ie change use of the name cifs to smb which is more accurate	2021-09-12 10:10:21 -07:00
mbcache.c
mount.h
mpage.c
namei.c	fs: add two trivial lookup helpers	2022-06-09 10:23:32 +02:00
namespace.c	fs/mount_setattr: always cleanup mount_kattr	2022-01-05 12:42:39 +01:00
no-block.c
nsfs.c
open.c	mm, thp: fix incorrect unmap behavior for private pages	2021-11-18 19:17:17 +01:00
pipe.c	pipe: Fix missing lock in pipe_resize_ring()	2022-06-06 08:43:37 +02:00
pnode.c
pnode.h
posix_acl.c	ovl: enable RCU'd ->get_acl()	2021-08-18 22:08:24 +02:00
proc_namespace.c
read_write.c	fs: clean up after mandatory file locking support removal	2021-08-24 07:52:45 -04:00
readdir.c
remap_range.c	fs: remove mandatory file locking support	2021-08-23 06:15:36 -04:00
select.c	select: Fix indefinitely sleeping task in poll_schedule_timeout()	2022-01-29 10:58:25 +01:00
seq_file.c
signalfd.c	signalfd: use wake_up_pollfree()	2021-12-14 10:57:15 +01:00
splice.c
stack.c
stat.c	stat: fix inconsistency between struct stat and struct compat_stat	2022-04-27 14:38:57 +02:00
statfs.c
super.c	vfs: make freeze_super abort when sync_filesystem returns error	2022-02-23 12:03:05 +01:00
sync.c	vfs: make sync_filesystem return errors from ->sync_fs	2022-04-27 14:38:50 +02:00
timerfd.c	timerfd: Provide timerfd_resume()	2021-08-10 17:57:22 +02:00
userfaultfd.c	userfaultfd: fix a race between writeprotect and exit_mmap()	2021-10-18 20:22:02 -10:00
utimes.c
xattr.c