Xin Long 9126fd82e9 sched: act_ct: add netns into the key of tcf_ct_flow_table ... [ Upstream commit 88c67aeb14 ] zones_ht is a global hashtable for flow_table with zone as key. However, it does not consider netns when getting a flow_table from zones_ht in tcf_ct_init(), and it means an act_ct action in netns A may get a flow_table that belongs to netns B if it has the same zone value. In Shuang's test with the TOPO: tcf2_c <---> tcf2_sw1 <---> tcf2_sw2 <---> tcf2_s tcf2_sw1 and tcf2_sw2 saw the same flow and used the same flow table, which caused their ct entries entering unexpected states and the TCP connection not able to end normally. This patch fixes the issue simply by adding netns into the key of tcf_ct_flow_table so that an act_ct action gets a flow_table that belongs to its own netns in tcf_ct_init(). Note that for easy coding we don't use tcf_ct_flow_table.nf_ft.net, as the ct_ft is initialized after inserting it to the hashtable in tcf_ct_flow_table_get() and also it requires to implement several functions in rhashtable_params including hashfn, obj_hashfn and obj_cmpfn. Fixes: 64ff70b80f ("net/sched: act_ct: Offload established connections to flow table") Reported-by: Shuang Li <shuali@redhat.com> Signed-off-by: Xin Long <lucien.xin@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/1db5b6cc6902c5fc6f8c6cbd85494a2008087be5.1718488050.git.lucien.xin@gmail.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-06-27 13:49:07 +02:00
..
act_api.c	net/sched: act_api: fix possible infinite loop in tcf_idr_check_alloc()	2024-06-27 13:49:07 +02:00
act_bpf.c	net/sched: avoid indirect act functions on retpoline kernels	2022-12-09 09:18:07 +00:00
act_connmark.c	net/sched: act_connmark: handle errno on tcf_idr_check_alloc	2023-03-01 08:19:09 +00:00
act_csum.c	net: skbuff: hide csum_not_inet when CONFIG_IP_SCTP not set	2023-04-19 13:04:30 +01:00
act_ct.c	sched: act_ct: add netns into the key of tcf_ct_flow_table	2024-06-27 13:49:07 +02:00
act_ctinfo.c	net/sched: act_ctinfo: use percpu stats	2023-02-13 20:09:01 -08:00
act_gact.c	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
act_gate.c	net/sched: act_gate: use percpu stats	2023-02-16 10:39:28 +01:00
act_ife.c	net/sched: avoid indirect act functions on retpoline kernels	2022-12-09 09:18:07 +00:00
act_ipt.c	net/sched: act_ipt: zero skb->cb before calling target	2023-06-29 12:10:37 +02:00
act_meta_mark.c
act_meta_skbprio.c
act_meta_skbtcindex.c
act_mirred.c	net/sched: act_mirred: don't override retval if we already lost the skb	2024-03-01 13:35:06 +01:00
act_mpls.c	net/sched: remove two skb_mac_header() uses	2023-03-22 22:43:23 -07:00
act_nat.c	net/sched: act_nat: transition to percpu stats and rcu	2023-02-16 10:39:28 +01:00
act_pedit.c	net/sched: act_pedit: Add size check for TCA_PEDIT_PARMS_EX	2023-07-04 10:31:38 +02:00
act_police.c	net: move gso declarations and functions to their own files	2023-06-10 00:11:41 -07:00
act_sample.c	net/sched: act_sample: fix action bind logic	2023-02-26 18:27:45 +00:00
act_simple.c	net/sched: avoid indirect act functions on retpoline kernels	2022-12-09 09:18:07 +00:00
act_skbedit.c	net/sched: avoid indirect act functions on retpoline kernels	2022-12-09 09:18:07 +00:00
act_skbmod.c	net/sched: act_skbmod: prevent kernel-infoleak	2024-04-10 16:35:51 +02:00
act_tunnel_key.c	net/sched: act_tunnel_key: add support for "don't fragment"	2023-03-30 23:24:24 -07:00
act_vlan.c	net/sched: avoid indirect act functions on retpoline kernels	2022-12-09 09:18:07 +00:00
cls_api.c	net/sched: flower: Fix chain template offload	2024-01-31 16:19:02 -08:00
cls_basic.c	net/sched: avoid indirect classify functions on retpoline kernels	2022-12-09 09:18:07 +00:00
cls_bpf.c	net: sched: cls_bpf: Undo tcf_bind_filter in case of an error	2023-07-17 07:33:39 +01:00
cls_cgroup.c	net/sched: avoid indirect classify functions on retpoline kernels	2022-12-09 09:18:07 +00:00
cls_flow.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
cls_flower.c	net/sched: flower: Add lock protection when remove filter handle	2024-03-01 13:35:09 +01:00
cls_fw.c	net/sched: cls_fw: No longer copy tcf_result on update to avoid use-after-free	2023-07-31 20:10:36 -07:00
cls_matchall.c	net: sched: cls_matchall: Undo tcf_bind_filter in case of failure after mall_set_parms	2023-07-17 07:33:38 +01:00
cls_route.c	net/sched: cls_route: No longer copy tcf_result on update to avoid use-after-free	2023-07-31 20:10:37 -07:00
cls_u32.c	net: sched: cls_u32: Fix allocation size in u32_init()	2023-10-06 11:43:05 +01:00
em_canid.c
em_cmp.c
em_ipset.c
em_ipt.c
em_meta.c	net: annotate data-races around sk->sk_lingertime	2023-08-21 07:41:57 +01:00
em_nbyte.c
em_text.c	net: sched: em_text: fix possible memory leak in em_text_destroy()	2024-01-10 17:16:49 +01:00
em_u32.c
ematch.c	net_sched: reject TCF_EM_SIMPLE case for complex ematch module	2022-12-19 09:43:18 +00:00
Kconfig	bpf: Add fd-based tcx multi-prog infra with link support	2023-07-19 10:07:27 -07:00
Makefile	net/sched: Retire rsvp classifier	2023-02-16 09:27:07 +01:00
sch_api.c	net/sched: fix lockdep splat in qdisc_tree_reduce_backlog()	2024-04-10 16:35:51 +02:00
sch_blackhole.c
sch_cake.c	net: move gso declarations and functions to their own files	2023-06-10 00:11:41 -07:00
sch_cbs.c
sch_choke.c	treewide: use get_random_u32_below() instead of deprecated function	2022-11-18 02:15:15 +01:00
sch_codel.c
sch_drr.c	net/sched: sch_drr: warn about class in use while deleting	2023-08-01 10:47:24 +02:00
sch_etf.c
sch_ets.c
sch_fifo.c
sch_fq.c	net/sched: sch_fq: fix integer overflow of "credit"	2023-04-21 20:24:29 -07:00
sch_fq_codel.c
sch_fq_pie.c	net/sched: fq_pie: avoid stalls in fq_pie_timer()	2023-08-31 11:21:52 +02:00
sch_frag.c
sch_generic.c	net/sched: fix false lockdep warning on qdisc root lock	2024-06-27 13:49:02 +02:00
sch_gred.c	net: sched: gred: prevent races when adding offloads to stats	2023-01-18 20:28:25 -08:00
sch_hfsc.c	net/sched: sch_hfsc: upgrade 'rt' to 'sc' when it becomes a inner curve	2023-10-18 18:08:28 -07:00
sch_hhf.c
sch_htb.c	net/sched: fix false lockdep warning on qdisc root lock	2024-06-27 13:49:02 +02:00
sch_ingress.c	tcx: Fix splat in ingress_destroy upon tcx_entry_free	2023-07-24 11:42:35 -07:00
sch_mq.c	net: sched: add rcu annotations around qdisc->qdisc_sleeping	2023-06-07 10:25:39 +01:00
sch_mqprio.c	net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64	2023-07-26 22:08:14 -07:00
sch_mqprio_lib.c	net/sched: mqprio: allow per-TC user input of FP adminStatus	2023-04-13 22:22:10 -07:00
sch_mqprio_lib.h	net/sched: mqprio: allow per-TC user input of FP adminStatus	2023-04-13 22:22:10 -07:00
sch_multiq.c	net: sched: sch_multiq: fix possible OOB write in multiq_tune()	2024-06-21 14:38:16 +02:00
sch_netem.c	netem: use seeded PRNG for correlated loss events	2023-08-17 19:15:06 -07:00
sch_pie.c	net: sched: add rcu annotations around qdisc->qdisc_sleeping	2023-06-07 10:25:39 +01:00
sch_plug.c	net: sched: sch_qfq: Fix UAF in qfq_dequeue()	2023-09-05 08:54:12 +02:00
sch_prio.c
sch_qfq.c	net: sched: sch_qfq: Fix UAF in qfq_dequeue()	2023-09-05 08:54:12 +02:00
sch_red.c	net: sched: add rcu annotations around qdisc->qdisc_sleeping	2023-06-07 10:25:39 +01:00
sch_sfb.c
sch_sfq.c	net: sched: add rcu annotations around qdisc->qdisc_sleeping	2023-06-07 10:25:39 +01:00
sch_skbprio.c
sch_taprio.c	net/sched: taprio: always validate TCA_TAPRIO_ATTR_PRIOMAP	2024-06-21 14:38:17 +02:00
sch_tbf.c	net: move gso declarations and functions to their own files	2023-06-10 00:11:41 -07:00
sch_teql.c	net: sched: add rcu annotations around qdisc->qdisc_sleeping	2023-06-07 10:25:39 +01:00