Trevor Wu d76b9c2424 ASoC: mediatek: mt8195: fix use-after-free in driver remove path ... [ Upstream commit dc93f0dcb4 ] During mt8195_afe_init_clock(), mt8195_audsys_clk_register() was called followed by several other devm functions. At mt8195_afe_deinit_clock() located at mt8195_afe_pcm_dev_remove(), mt8195_audsys_clk_unregister() was called. However, there was an issue with the order in which these functions were called. Specifically, the remove callback of platform_driver was called before devres released the resource, resulting in a use-after-free issue during remove time. At probe time, the order of calls was: 1. mt8195_audsys_clk_register 2. afe_priv->clk = devm_kcalloc 3. afe_priv->clk[i] = devm_clk_get At remove time, the order of calls was: 1. mt8195_audsys_clk_unregister 3. free afe_priv->clk[i] 2. free afe_priv->clk To resolve the problem, we can utilize devm_add_action_or_reset() in mt8195_audsys_clk_register() so that the remove order can be changed to 3->2->1. Fixes: 6746cc8582 ("ASoC: mediatek: mt8195: add platform driver") Signed-off-by: Trevor Wu <trevor.wu@mediatek.com> Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20230601033318.10408-3-trevor.wu@mediatek.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-06-14 11:17:02 +02:00
..
common	ASoC: mediatek: common: Fix refcount leak in parse_dai_link_info	2023-05-11 23:17:26 +09:00
mt2701	ASoC: mediatek: mt2701-wm8960: Register to module device table	2022-11-09 13:44:24 +00:00
mt6797	ASoC: mediatek: use helper function	2023-01-31 11:05:02 +00:00
mt8173	ASoC: mediatek: mt8173-rt5650-rt5514: fix refcount leak in mt8173_rt5650_rt5514_dev_probe()	2022-12-07 14:19:11 +00:00
mt8183	ASoC: mt8183: Fix event generation for I2S DAI operations	2023-02-28 13:58:47 +00:00
mt8186	ASoC: mediatek: mt8186: Fix use-after-free in driver remove path	2023-05-24 17:30:16 +01:00
mt8188	ASoC: mediatek: mt8188: fix use-after-free in driver remove path	2023-06-14 11:17:01 +02:00
mt8192	ASoC: mt8192: Fix range for sidetone positive gain	2023-02-28 13:58:55 +00:00
mt8195	ASoC: mediatek: mt8195: fix use-after-free in driver remove path	2023-06-14 11:17:02 +02:00
Kconfig	ASoC: mediatek: Add support for MT8188 SoC	2023-01-19 15:31:47 +00:00
Makefile	ASoC: mediatek: mt8188: add platform driver	2023-01-16 11:16:26 +00:00