Wang Cheng 777e563f10 mm/mempolicy: fix uninit-value in mpol_rebind_policy() ... commit 018160ad31 upstream. mpol_set_nodemask()(mm/mempolicy.c) does not set up nodemask when pol->mode is MPOL_LOCAL. Check pol->mode before access pol->w.cpuset_mems_allowed in mpol_rebind_policy()(mm/mempolicy.c). BUG: KMSAN: uninit-value in mpol_rebind_policy mm/mempolicy.c:352 [inline] BUG: KMSAN: uninit-value in mpol_rebind_task+0x2ac/0x2c0 mm/mempolicy.c:368 mpol_rebind_policy mm/mempolicy.c:352 [inline] mpol_rebind_task+0x2ac/0x2c0 mm/mempolicy.c:368 cpuset_change_task_nodemask kernel/cgroup/cpuset.c:1711 [inline] cpuset_attach+0x787/0x15e0 kernel/cgroup/cpuset.c:2278 cgroup_migrate_execute+0x1023/0x1d20 kernel/cgroup/cgroup.c:2515 cgroup_migrate kernel/cgroup/cgroup.c:2771 [inline] cgroup_attach_task+0x540/0x8b0 kernel/cgroup/cgroup.c:2804 __cgroup1_procs_write+0x5cc/0x7a0 kernel/cgroup/cgroup-v1.c:520 cgroup1_tasks_write+0x94/0xb0 kernel/cgroup/cgroup-v1.c:539 cgroup_file_write+0x4c2/0x9e0 kernel/cgroup/cgroup.c:3852 kernfs_fop_write_iter+0x66a/0x9f0 fs/kernfs/file.c:296 call_write_iter include/linux/fs.h:2162 [inline] new_sync_write fs/read_write.c:503 [inline] vfs_write+0x1318/0x2030 fs/read_write.c:590 ksys_write+0x28b/0x510 fs/read_write.c:643 __do_sys_write fs/read_write.c:655 [inline] __se_sys_write fs/read_write.c:652 [inline] __x64_sys_write+0xdb/0x120 fs/read_write.c:652 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x44/0xae Uninit was created at: slab_post_alloc_hook mm/slab.h:524 [inline] slab_alloc_node mm/slub.c:3251 [inline] slab_alloc mm/slub.c:3259 [inline] kmem_cache_alloc+0x902/0x11c0 mm/slub.c:3264 mpol_new mm/mempolicy.c:293 [inline] do_set_mempolicy+0x421/0xb70 mm/mempolicy.c:853 kernel_set_mempolicy mm/mempolicy.c:1504 [inline] __do_sys_set_mempolicy mm/mempolicy.c:1510 [inline] __se_sys_set_mempolicy+0x44c/0xb60 mm/mempolicy.c:1507 __x64_sys_set_mempolicy+0xd8/0x110 mm/mempolicy.c:1507 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x44/0xae KMSAN: uninit-value in mpol_rebind_task (2) https://syzkaller.appspot.com/bug?id=d6eb90f952c2a5de9ea718a1b873c55cb13b59dc This patch seems to fix below bug too. KMSAN: uninit-value in mpol_rebind_mm (2) https://syzkaller.appspot.com/bug?id=f2fecd0d7013f54ec4162f60743a2b28df40926b The uninit-value is pol->w.cpuset_mems_allowed in mpol_rebind_policy(). When syzkaller reproducer runs to the beginning of mpol_new(), mpol_new() mm/mempolicy.c do_mbind() mm/mempolicy.c kernel_mbind() mm/mempolicy.c `mode` is 1(MPOL_PREFERRED), nodes_empty(*nodes) is `true` and `flags` is 0. Then mode = MPOL_LOCAL; ... policy->mode = mode; policy->flags = flags; will be executed. So in mpol_set_nodemask(), mpol_set_nodemask() mm/mempolicy.c do_mbind() kernel_mbind() pol->mode is 4 (MPOL_LOCAL), that `nodemask` in `pol` is not initialized, which will be accessed in mpol_rebind_policy(). Link: https://lkml.kernel.org/r/20220512123428.fq3wofedp6oiotd4@ppc.localdomain Signed-off-by: Wang Cheng <wanngchenng@gmail.com> Reported-by: <syzbot+217f792c92599518a2ab@syzkaller.appspotmail.com> Tested-by: <syzbot+217f792c92599518a2ab@syzkaller.appspotmail.com> Cc: David Rientjes <rientjes@google.com> Cc: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-07-29 17:28:14 +02:00
..
damon	mm/damon: use set_huge_pte_at() to make huge pte old	2022-07-22 10:21:19 +02:00
kasan	kasan: prevent cpu_quarantine corruption when CPU offline and cache shrink occur at same time	2022-04-27 13:28:48 -07:00
kfence	mm/kfence: reset PG_slab and memcg_data before freeing __kfence_pool	2022-05-09 17:34:29 -07:00
backing-dev.c	init: Initialize noop_backing_dev_info early	2022-06-22 14:28:03 +02:00
balloon_compaction.c	mm/balloon_compaction: make balloon page compaction callbacks static	2022-03-28 16:52:57 -04:00
bootmem_info.c	bootmem: Use page->index instead of page->freelist	2022-01-06 12:27:03 +01:00
cma.c	Revert "mm/cma.c: remove redundant cma_mutex lock"	2022-06-09 10:30:52 +02:00
cma.h	mm/cma: provide option to opt out from exposing pages on activation failure	2022-03-22 15:57:09 -07:00
cma_debug.c
cma_sysfs.c
compaction.c	mm, compaction: fast_find_migrateblock() should return pfn in the target zone	2022-06-09 10:30:44 +02:00
debug.c	mm: unexport page_init_poison	2022-03-24 19:06:45 -07:00
debug_page_ref.c
debug_vm_pgtable.c	mm/debug_vm_pgtable: remove pte entry from the page table	2022-02-04 09:25:04 -08:00
dmapool.c	mm/dmapool.c: revert "make dma pool to use kmalloc_node"	2022-01-15 16:30:28 +02:00
early_ioremap.c	mm/early_ioremap: declare early_memremap_pgprot_adjust()	2022-03-22 15:57:11 -07:00
fadvise.c	remove inode_congested()	2022-03-22 15:57:01 -07:00
failslab.c
filemap.c	filemap: Handle sibling entries in filemap_get_read_batch()	2022-06-29 09:04:27 +02:00
folio-compat.c	mm/rmap: Convert rmap_walk() to take a folio	2022-03-21 13:01:35 -04:00
frontswap.c	frontswap: remove support for multiple ops	2022-01-22 08:33:38 +02:00
gup.c	mm/munlock: add lru_add_drain() to fix memcg_stat_test	2022-04-01 11:46:09 -07:00
gup_test.c
gup_test.h
highmem.c	highmem: fix checks in __kmap_local_sched_{in,out}	2022-04-08 14:20:36 -10:00
hmm.c	mm/hmm.c: remove unneeded local variable ret	2022-03-22 15:57:12 -07:00
huge_memory.c	mm/huge_memory: Fix xarray node memory leak	2022-06-14 18:45:19 +02:00
hugetlb.c	hugetlb: fix huge_pmd_unshare address update	2022-06-09 10:30:52 +02:00
hugetlb_cgroup.c	hugetlb: add hugetlb.*.numa_stat file	2022-01-15 16:30:29 +02:00
hugetlb_vmemmap.c	mm: hugetlb: replace hugetlb_free_vmemmap_enabled with a static_key	2022-03-22 15:57:08 -07:00
hugetlb_vmemmap.h
hwpoison-inject.c	mm/memory-failure: disable unpoison once hw error happens	2022-06-29 09:04:41 +02:00
init-mm.c	kernel/fork: Initialize mm's PASID	2022-02-14 19:51:47 +01:00
internal.h	mm/munlock: protect the per-CPU pagevec by a local_lock_t	2022-04-01 11:46:09 -07:00
interval_tree.c
io-mapping.c
ioremap.c
Kconfig	mm: generalize ARCH_HAS_FILTER_PGPROT	2022-03-24 19:06:51 -07:00
Kconfig.debug	mm: page table check	2022-01-15 16:30:28 +02:00
khugepaged.c	mm/khugepaged: remove reuse_swap_page() usage	2022-03-24 19:06:51 -07:00
kmemleak.c	mm: kmemleak: take a full lowmem check in kmemleak_*_phys()	2022-04-15 14:49:56 -07:00
ksm.c	Folio changes for 5.18	2022-03-22 17:03:12 -07:00
list_lru.c	mm/list_lru.c: revert "mm/list_lru: optimize memcg_reparent_list_lru_node()"	2022-04-08 14:20:36 -10:00
maccess.c	asm-generic updates for 5.18	2022-03-23 18:03:08 -07:00
madvise.c	mm/memory-failure: disable unpoison once hw error happens	2022-06-29 09:04:41 +02:00
Makefile	mm: move the migrate_vma_* device migration code into its own file	2022-03-03 12:47:33 -05:00
mapping_dirty_helpers.c	mm: move tlb_flush_pending inline helpers to mm_inline.h	2022-01-15 16:30:27 +02:00
memblock.c	memblock: test suite and a small cleanup	2022-03-27 13:36:06 -07:00
memcontrol.c	memcg: sync flush only if periodic flush is delayed	2022-04-21 20:01:09 -07:00
memfd.c	memfd: fix F_SEAL_WRITE after shmem huge page allocated	2022-03-05 11:08:32 -08:00
memory-failure.c	mm/memory-failure: disable unpoison once hw error happens	2022-06-29 09:04:41 +02:00
memory.c	mm: split huge PUD on wp_huge_pud fallback	2022-07-22 10:21:18 +02:00
memory_hotplug.c	Folio changes for 5.18	2022-03-22 17:03:12 -07:00
mempolicy.c	mm/mempolicy: fix uninit-value in mpol_rebind_policy()	2022-07-29 17:28:14 +02:00
mempool.c	mm: remove spurious blkdev.h includes	2021-10-18 06:17:01 -06:00
memremap.c	mm/memremap: fix missing call to untrack_pfn() in pagemap_range()	2022-06-09 10:30:52 +02:00
memtest.c
migrate.c	mm: migrate: use thp_order instead of HPAGE_PMD_ORDER for new page allocation.	2022-04-08 14:20:36 -10:00
migrate_device.c	mm/migrate: Convert remove_migration_ptes() to folios	2022-03-21 13:01:35 -04:00
mincore.c
mlock.c	mm/munlock: protect the per-CPU pagevec by a local_lock_t	2022-04-01 11:46:09 -07:00
mm_init.c
mmap.c	mm, hugetlb: allow for "high" userspace addresses	2022-04-21 20:01:09 -07:00
mmap_lock.c
mmu_gather.c	mm: move tlb_flush_pending inline helpers to mm_inline.h	2022-01-15 16:30:27 +02:00
mmu_notifier.c	mm/mmu_notifier.c: fix race in mmu_interval_notifier_remove()	2022-04-21 20:01:10 -07:00
mmzone.c	Folio changes for 5.18	2022-03-22 17:03:12 -07:00
mprotect.c	memory tiering: skip to scan fast memory	2022-03-22 15:57:09 -07:00
mremap.c	mm: mremap: fix sign for EFAULT error return value	2022-05-09 17:34:28 -07:00
msync.c
nommu.c	no-MMU: expose vmalloc_huge() for alloc_large_system_hash()	2022-04-25 10:11:49 -07:00
oom_kill.c	oom_kill.c: futex: delay the OOM reaper to allow time for proper futex cleanup	2022-04-21 20:01:10 -07:00
page-writeback.c	mm: warn on deleting redirtied only if accounted	2022-03-24 19:06:51 -07:00
page_alloc.c	mm/page_alloc: always attempt to allocate at least one page during bulk allocation	2022-06-09 10:30:52 +02:00
page_counter.c	mm/page_counter: remove an incorrect call to propagate_protected_usage()	2022-01-15 16:30:27 +02:00
page_ext.c	mm: make some vars and functions static or __init	2022-01-15 16:30:31 +02:00
page_idle.c	mm/rmap: Constify the rmap_walk_control argument	2022-03-21 13:01:35 -04:00
page_io.c	mm: fix unexpected zeroed page mapping with zram swap	2022-04-15 14:49:55 -07:00
page_isolation.c	Revert "mm/page_isolation: unset migratetype directly for non Buddy page"	2022-02-04 09:25:04 -08:00
page_owner.c	mm/page_owner: use strscpy() instead of strlcpy()	2022-06-09 10:30:52 +02:00
page_poison.c
page_reporting.c
page_reporting.h
page_table_check.c	mm/page_table_check.c: use strtobool for param parsing	2022-03-22 15:57:11 -07:00
page_vma_mapped.c	mm/rmap: Fix handling of hugetlbfs pages in page_vma_mapped_walk	2022-04-07 10:11:20 -04:00
pagewalk.c
percpu-internal.h	mm: memcg/percpu: account extra objcg space to memory cgroups	2022-01-15 16:30:31 +02:00
percpu-km.c
percpu-stats.c	mm: use vmalloc_array and vcalloc for array allocations	2022-03-08 09:30:46 -05:00
percpu-vm.c
percpu.c	bitmap patches for 5.17-rc1	2022-01-23 06:20:44 +02:00
pgalloc-track.h
pgtable-generic.c	mm: move tlb_flush_pending inline helpers to mm_inline.h	2022-01-15 16:30:27 +02:00
process_vm_access.c
ptdump.c	mm: sparsemem: use page table lock to protect kernel pmd operations	2022-03-22 15:57:08 -07:00
readahead.c	filemap: Fix serialization adding transparent huge pages to page cache	2022-06-29 09:04:35 +02:00
rmap.c	mm/munlock: protect the per-CPU pagevec by a local_lock_t	2022-04-01 11:46:09 -07:00
rodata_test.c
secretmem.c	mm/secretmem: fix panic when growing a memfd_secret	2022-04-15 14:49:54 -07:00
shmem.c	tmpfs: fix regressions from wider use of ZERO_PAGE	2022-04-15 14:49:54 -07:00
shuffle.c
shuffle.h
slab.c	mm, kfence: support kmem_dump_obj() for KFENCE objects	2022-04-15 14:49:55 -07:00
slab.h	mm, kfence: support kmem_dump_obj() for KFENCE objects	2022-04-15 14:49:55 -07:00
slab_common.c	mm, kfence: support kmem_dump_obj() for KFENCE objects	2022-04-15 14:49:55 -07:00
slob.c	mm, kfence: support kmem_dump_obj() for KFENCE objects	2022-04-15 14:49:55 -07:00
slub.c	mm/slub: add missing TID updates on slab deactivation	2022-06-29 09:04:27 +02:00
sparse-vmemmap.c	mm: sparsemem: fix missing higher order allocation splitting	2022-07-22 10:21:18 +02:00
sparse.c	mm/sparse: make mminit_validate_memmodel_limits() static	2022-03-22 15:57:05 -07:00
swap.c	mm: lru_cache_disable: use synchronize_rcu_expedited	2022-06-29 09:04:41 +02:00
swap_cgroup.c	mm: use vmalloc_array and vcalloc for array allocations	2022-03-08 09:30:46 -05:00
swap_slots.c	treewide: Add missing includes masked by cgroup -> bpf dependency	2021-12-03 10:58:13 -08:00
swap_state.c	Filesystem folio changes for 5.18	2022-03-22 18:26:56 -07:00
swapfile.c	mm/swapfile: remove stale reuse_swap_page()	2022-03-24 19:06:51 -07:00
truncate.c	Filesystem folio changes for 5.18	2022-03-22 18:26:56 -07:00
usercopy.c	Merge branch 'akpm' (patches from Andrew)	2022-03-22 16:11:53 -07:00
userfaultfd.c	mm: userfaultfd: fix UFFDIO_CONTINUE on fallocated shmem pages	2022-07-22 10:21:18 +02:00
util.c	random: move randomize_page() into mm where it belongs	2022-05-30 09:24:08 +02:00
vmacache.c
vmalloc.c	mm/vmalloc: huge vmalloc backing pages should be split rather than compound	2022-04-22 09:20:16 -07:00
vmpressure.c	mm/vmpressure: fix data-race with memcg->socket_pressure	2021-11-06 13:30:40 -07:00
vmscan.c	Folio changes for 5.18	2022-03-22 17:03:12 -07:00
vmstat.c	mm: only re-generate demotion targets when a numa node changes its N_CPU state	2022-03-22 15:57:11 -07:00
workingset.c	memcg: sync flush only if periodic flush is delayed	2022-04-21 20:01:09 -07:00
z3fold.c
zbud.c
zpool.c	zpool: remove the list of pools_head	2022-01-15 16:30:31 +02:00
zsmalloc.c	zsmalloc: fix races between asynchronous zspage free and page migration	2022-06-06 08:48:56 +02:00
zswap.c	mm/zswap.c: allow handling just same-value filled pages	2022-03-22 15:57:11 -07:00